* [PATCH v1 0/1] Mediatek PMIC patch
@ 2022-03-29 11:58 Zhiyong Tao
2022-03-29 11:58 ` [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue Zhiyong Tao
0 siblings, 1 reply; 5+ messages in thread
From: Zhiyong Tao @ 2022-03-29 11:58 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang,
a.zummo, alexandre.belloni, fshao
Cc: srv_heupstream, hui.liu, zhiyong.tao, hsin-hsiung.wang, sean.wang,
macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc,
Project_Global_Chrome_Upstream_Group, linux-arm-kernel,
linux-mediatek
This patch fix pwrap time out issue.
Zhiyong.Tao (1):
pwrap: mediatek: fix wait time out issue
drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue
2022-03-29 11:58 [PATCH v1 0/1] Mediatek PMIC patch Zhiyong Tao
@ 2022-03-29 11:58 ` Zhiyong Tao
2022-03-29 14:44 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Zhiyong Tao @ 2022-03-29 11:58 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang,
a.zummo, alexandre.belloni, fshao
Cc: srv_heupstream, hui.liu, zhiyong.tao, hsin-hsiung.wang, sean.wang,
macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc,
Project_Global_Chrome_Upstream_Group, linux-arm-kernel,
linux-mediatek
From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
add sleep delay before read "jiffies"
Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
old mode 100644
new mode 100755
index 952bc554f443..ac7139a67e87
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -12,6 +12,7 @@
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/reset.h>
+#include <linux/delay.h>
#define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
#define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
@@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
timeout = jiffies + usecs_to_jiffies(10000);
do {
- if (time_after(jiffies, timeout))
- return fp(wrp) ? 0 : -ETIMEDOUT;
if (fp(wrp))
return 0;
+
+ usleep_range(10, 11);
+
+ if (time_after(jiffies, timeout))
+ return fp(wrp) ? 0 : -ETIMEDOUT;
} while (1);
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue
2022-03-29 11:58 ` [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue Zhiyong Tao
@ 2022-03-29 14:44 ` Matthias Brugger
2022-04-18 1:29 ` zhiyong.tao
0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2022-03-29 14:44 UTC (permalink / raw)
To: Zhiyong Tao, lee.jones, robh+dt, lgirdwood, broonie, eddie.huang,
a.zummo, alexandre.belloni, fshao
Cc: srv_heupstream, hui.liu, hsin-hsiung.wang, sean.wang, macpaul.lin,
wen.su, devicetree, linux-kernel, linux-rtc,
Project_Global_Chrome_Upstream_Group, linux-arm-kernel,
linux-mediatek
On 29/03/2022 13:58, Zhiyong Tao wrote:
> From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
>
> add sleep delay before read "jiffies"
>
> Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> old mode 100644
> new mode 100755
> index 952bc554f443..ac7139a67e87
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -12,6 +12,7 @@
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/delay.h>
>
> #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
> #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
> @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
> timeout = jiffies + usecs_to_jiffies(10000);
>
> do {
> - if (time_after(jiffies, timeout))
> - return fp(wrp) ? 0 : -ETIMEDOUT;
> if (fp(wrp))
> return 0;
> +
> + usleep_range(10, 11);
> +
You need to explain this change. Why is it needed, are you sure it does not
break other platforms etc.
I can guess why you need that patch here. In any case in the code you provide,
it would make sense to move the first if out of the do loop and only after this
wait 10 us before reading again. Right now the code does usleep only after every
other read.
Regards,
Matthias
> + if (time_after(jiffies, timeout))
> + return fp(wrp) ? 0 : -ETIMEDOUT;
> } while (1);
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue
2022-03-29 14:44 ` Matthias Brugger
@ 2022-04-18 1:29 ` zhiyong.tao
0 siblings, 0 replies; 5+ messages in thread
From: zhiyong.tao @ 2022-04-18 1:29 UTC (permalink / raw)
To: Matthias Brugger, lee.jones, robh+dt, lgirdwood, broonie,
eddie.huang, a.zummo, alexandre.belloni, fshao
Cc: srv_heupstream, hui.liu, hsin-hsiung.wang, sean.wang, macpaul.lin,
wen.su, devicetree, linux-kernel, linux-rtc,
Project_Global_Chrome_Upstream_Group, linux-arm-kernel,
linux-mediatek
On Tue, 2022-03-29 at 16:44 +0200, Matthias Brugger wrote:
>
> On 29/03/2022 13:58, Zhiyong Tao wrote:
> > From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
> >
> > add sleep delay before read "jiffies"
> >
> > Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
> > ---
> > drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> > mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
> >
> > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
> > b/drivers/soc/mediatek/mtk-pmic-wrap.c
> > old mode 100644
> > new mode 100755
> > index 952bc554f443..ac7139a67e87
> > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> > @@ -12,6 +12,7 @@
> > #include <linux/platform_device.h>
> > #include <linux/regmap.h>
> > #include <linux/reset.h>
> > +#include <linux/delay.h>
> >
> > #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
> > #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
> > @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct
> > pmic_wrapper *wrp,
> > timeout = jiffies + usecs_to_jiffies(10000);
> >
> > do {
> > - if (time_after(jiffies, timeout))
> > - return fp(wrp) ? 0 : -ETIMEDOUT;
> > if (fp(wrp))
> > return 0;
> > +
> > + usleep_range(10, 11);
> > +
>
> You need to explain this change. Why is it needed, are you sure it
> does not
> break other platforms etc.
>
> I can guess why you need that patch here. In any case in the code you
> provide,
> it would make sense to move the first if out of the do loop and only
> after this
> wait 10 us before reading again. Right now the code does usleep only
> after every
> other read.
>
> Regards,
> Matthias
>
Hi Mattias,
we confirm the delay time with our pwrap designer.
we should add the 10us delay before reading again.
The patch is accord with all platforms pwrap design.
we will explain this in next version.
Thanks.
> > + if (time_after(jiffies, timeout))
> > + return fp(wrp) ? 0 : -ETIMEDOUT;
> > } while (1);
> > }
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 0/1] Mediatek PMIC patch
@ 2022-04-11 1:41 Zhiyong Tao
0 siblings, 0 replies; 5+ messages in thread
From: Zhiyong Tao @ 2022-04-11 1:41 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang,
a.zummo, alexandre.belloni, fshao
Cc: srv_heupstream, hui.liu, tinghan.shen, zhiyong.tao,
hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree,
linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group,
linux-arm-kernel, linux-mediatek
This patch fix pwrap document for mt8195.
Zhiyong.Tao (1):
dt-bindings: pwrap: mediatek: fix pwrap document for mt8195
.../devicetree/bindings/soc/mediatek/pwrap.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-18 1:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-29 11:58 [PATCH v1 0/1] Mediatek PMIC patch Zhiyong Tao
2022-03-29 11:58 ` [PATCH v1 1/1] pwrap: mediatek: fix wait time out issue Zhiyong Tao
2022-03-29 14:44 ` Matthias Brugger
2022-04-18 1:29 ` zhiyong.tao
-- strict thread matches above, loose matches on Subject: below --
2022-04-11 1:41 [PATCH v1 0/1] Mediatek PMIC patch Zhiyong Tao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).