From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72E06C433F5 for ; Thu, 31 Mar 2022 21:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tGGafngOT/q9/xNHM3W6jSED3rVxnMoG7ZRXCzlSG24=; b=EnWQLJdBgdfreX ST1Sgp5xB7ujp6Xs/i92Hyyyzi3fvVXBLiEAGD/Ziqh66Jz/Aa/uQVsMDPRcslikqQ0YZITjQTdV4 SGbx7m/g7dO6C3nnR883fbPBpJWkUNk/2AecBPKvi2mwKIkYYiuAB7KUwNBtHCW/pmEZ4p6PLScHU 9AwxECBA967Ne985SHKbB8ntDWhOzX+OR8Id9Zv44t3/1zfdYIz2KXbtcz4/bQQkToRTGw3Oony3W /cflXi5jfH5rBUev1X9+VcJa9ujQVukOdlro2et/q0lkREpojvxDhaEADfGPx0RgAzTW1/fUZz1qn bPC6CQ1UephhgmjbY8HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1na2oD-003nbV-1a; Thu, 31 Mar 2022 21:58:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1na2o8-003naG-KS; Thu, 31 Mar 2022 21:58:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C0A260B61; Thu, 31 Mar 2022 21:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F11BEC340F0; Thu, 31 Mar 2022 21:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648763899; bh=EdyYRv/RjH6voZpfK9AsnGWVtEgWXeOuukdtRC5UEKg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=lnycOEjlNdrSNQz4HWAciAAwYkiads1HaoBhzmckHhiGEx2FVc8VApvNG/U9fZnlr 7/clOK8vr/mk4bbIw/imRUg8mKlFLGoy3cP6lF6pfy8pQFAN9CSbTGH1aF7rXWFAwC 5eUCCuB8MPWi+ft9NaYXhMPh7WIgoijxWXzG3EvDuKREPSLVRmVUmawgEWVWzGnPN6 jdqsO4KjIYszy0jIQDN2bn/8Iq5wsP06a7Dx2wzyA5cDIyvc9MJaYk0dnifJpTE+yM 7DMl4xqMVdY5x0jyrH5A50uRGYv52Ykkt6t2QK5+3Hwm5mVrzYernar930y/vMNyzw Uhg6D24iOoTWQ== MIME-Version: 1.0 In-Reply-To: References: <20220325161144.1901695-1-maxime@cerno.tech> <20220325161144.1901695-4-maxime@cerno.tech> <366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com> <20220330084710.3r6b5pjspz5hdmy6@houat> <20220331095456.dyyxsiu2b3yw2vvs@houat> <20220331153134.h3alp24hzquajkly@houat> Subject: Re: [PATCH v2 3/3] clk: Drop the rate range on clk_put From: Stephen Boyd Cc: Marek Szyprowski , Mike Turquette , linux-clk@vger.kernel.org, Dmitry Osipenko , 'Linux Samsung SOC' , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Maxime Ripard , Tony Lindgren Date: Thu, 31 Mar 2022 14:58:17 -0700 User-Agent: alot/0.10 Message-Id: <20220331215818.F11BEC340F0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_145820_748247_B51D5BD4 X-CRM114-Status: GOOD ( 22.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Tony Lindgren (2022-03-31 10:00:09) > * Maxime Ripard [220331 15:29]: > > On Thu, Mar 31, 2022 at 06:00:42PM +0300, Tony Lindgren wrote: > > > * Maxime Ripard [220331 09:52]: > > > > On Thu, Mar 31, 2022 at 12:42:10PM +0300, Tony Lindgren wrote: > > > > > It seems the dts assigned-clock-parents no longer works now? > > > > > > > > That would make some kind of sense, __set_clk_parents calls clk_put on > > > > both the assigned clock and its parent. > > > > > > > > Could you see what parent (and why?) it tries to enforce then? > > > > > > It picks the other option available for the mux clock that only has > > > two options. No idea why, but if you have some debug patch in mind I > > > can give it a try. > > > > > > > It looks like the gpt1_fck driver might favor another parent for that > > > > rate, which, if it's an invalid configuration, shouldn't really happen? > > > > > > Hmm there's a gate clock and a mux clock, there's not really a rate > > > selection available here for the sources. > > > > If I followed the OMAP driver properly, clk_mux_determine_rate_flags is > > doing the heavy lifting, could you run your test with > > Thanks that produces some interesting output. In the working case with > the $subject patch reverted we have: I don't think clk_put() dropping a range request is very important right now. If this isn't fixed tomorrow then we should revert out this patch so systems can boot -rc1 and try to fix it in parallel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel