From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 793EFC433F5 for ; Tue, 5 Apr 2022 06:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ODqBoenGXjMurvC3tfXLgIPzxYKax62Y2dvmLVqVDoo=; b=cfiEbADNmpvJC1 HqQsNMdCd7aPwSSn9E2mJ+1rv2Co8FCf+WKcWR169J8bfsRAVnIxHduS2+6icWdJDBPh3N2xw/SAk XKQ7LanaS+11/8bthLeAQ7FBlNmYXTTjMtd0aq9TA2cWLGVRYYxJLgWSpVG/XkRHEWTYppg+M79xK M+8nf54yirljPeAXW2vNd5xJjdNfZpBprki2wnaFAcckz7HD5Sua2JgLx49oZZtUiElLUMOnjmxjB SwUZ3N0jF6/S/zny2V81JyCkz/t7Hd7I6nokrHxI5tlqRG7KpePKSmNZklFqbMGUbkqOg3+SBc9it fG6rOGQp4aFXkaFOyptg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbcwE-00HM8q-OZ; Tue, 05 Apr 2022 06:45:14 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbcwB-00HM7W-PO for linux-arm-kernel@lists.infradead.org; Tue, 05 Apr 2022 06:45:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 14A3DB81B99; Tue, 5 Apr 2022 06:45:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE323C340F3; Tue, 5 Apr 2022 06:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649141105; bh=jaRGetbQ2s3ZlsHzZOV4e30zP3uvS93CzT4nFqJ6LTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QXqVyolFovvtyoe4QyT8L5O/aljf5lAjYTjxj/H7N8rh4052dO8y31QGb86WyJ3uA mhWc+8kpGg2N5ohm7Ka5l5wNVFHi+e6aiiKBpSm1BQwVJt3kFd0qC1H37QxxrwecIX T9cEETcRA2MmSDmwdSZsCPN2xdRkNvThQKiEabdU6MkSU+blvsn5OEm/PZ1CDOAhmJ JcK1Yi3PWkKIXaNdtdpPQle0BbNCjWOWNFRI3uE8NpIK9iX0hRU/kevj0DxAZ0O5su l4SaiT3rLtTY7+2V+z5/fCPGjjqAMPRsdmNmiaX2MA6fw+w+4tZgT1M7cjm4i/MHWI vRE4A/bERervg== Date: Tue, 5 Apr 2022 14:44:58 +0800 From: Shawn Guo To: Adam Ford Cc: Lucas Stach , arm-soc , Tim Harvey , Adam Ford-BE , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Linux Kernel Mailing List Subject: Re: [PATCH] soc: imx: gpcv2: keep i.MX8MM VPU-H1 bus clock active Message-ID: <20220405064458.GA129381@dragon> References: <20211120193916.1309236-1-aford173@gmail.com> <319e976acb0a686e596b88520dbcda59c78afe9e.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_234512_166801_81A31146 X-CRM114-Status: GOOD ( 32.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 06:32:13AM -0500, Adam Ford wrote: > On Thu, Mar 31, 2022 at 4:28 AM Lucas Stach wrote: > > > > Hi Adam, hi Shawn, > > > > Am Samstag, dem 20.11.2021 um 13:39 -0600 schrieb Adam Ford: > > > Enable the vpu-h1 clock when the domain is active because reading > > > or writing to the VPU-H1 IP block cause the system to hang. > > > > > > Fixes: 656ade7aa42a ("soc: imx: gpcv2: keep i.MX8M* bus clocks enabled") > > > Signed-off-by: Adam Ford > > > > > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > > > index b8d52d8d29db..7b6dfa33dcb9 100644 > > > --- a/drivers/soc/imx/gpcv2.c > > > +++ b/drivers/soc/imx/gpcv2.c > > > @@ -734,6 +734,7 @@ static const struct imx_pgc_domain imx8mm_pgc_domains[] = { > > > .map = IMX8MM_VPUH1_A53_DOMAIN, > > > }, > > > .pgc = BIT(IMX8MM_PGC_VPUH1), > > > + .keep_clocks = true, > > > }, > > > > > I missed this patch and just stumbled across it when looking at the git > > history. I don't think this patch is correct. The H1 GPC domain does > > not even have clocks assigned in the DT, so there is nothing to keep > > active. Also H1 is not a MIX domain, so it should not keep any bus > > clocks active, that is the job of the VPUMIX domain. > > > > While this patch is a no-op, as far as I can see, it still seems wrong > > and I think it should be reverted. > > At the time I sent this, I was working with some people in the media > group to split the G1 and G2 up in the imx8mq and add G1 and G2 > support in the imx8mm. I had inquired about the feasibility of using > the H1 encoder on the imx8mm, but I needed to read some registers from > the IP block to see which features were fused out. I tried several > different options to get the H1 to not hang when reading registers, > and that was the only solution I found that worked. I thought it odd > as well since the G1 and G2 decoders didn't appear to need this. > However, during the course of my investigation, I learned that the > JPEG encoder was fused out of the imx8mm, and there wasn't a plan to > add VP8 or H.264 encodering any time soon. Since it is, as you put > it, a no-op, I have no objections to reverting it. I do not quite follow. You claimed that the change fixes a system hang. Are we getting the hang back if we revert the change? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel