From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84C3AC433F5 for ; Tue, 5 Apr 2022 17:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tAafQ+lUphS22ewlKcNS0Z3ekcItML8WAQj+Q8w9OxA=; b=QqxwrJps+1oeC7 7e/5FXFno9w/6hC/znVsbSWxD8ieADpCTAWpaI0ZXwaEiGtpD/rqvjEmz2wb8pnXb1TJt00n1N+VK Nk3i2DjFqTVjIOc9H43rJo5D8CricEP26wXS4i2iaW4mf7LPan5SsD6ahHL0egjxfkb0QPLFKknYG ix2yDfHWyHbKjBrNyoUGIVl+E+jwyJIQJXyKnAULslp15L4tDo3LNfIzuCDDJHqzMSKA1WbASsXMG xgwJuH33xFZ9pI+Hr8YuCJiVwg0LkTzvz4096slbRQSzTZq+3eZvQADSLSR1w5GathJIG6tr1zzWz zBNAVMBEA/FqsTnwcvEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbnBJ-0027MH-V8; Tue, 05 Apr 2022 17:41:30 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbnBG-0027Lw-7p for linux-arm-kernel@lists.infradead.org; Tue, 05 Apr 2022 17:41:27 +0000 Received: by mail-pf1-x42d.google.com with SMTP id x31so107155pfh.9 for ; Tue, 05 Apr 2022 10:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IkrrilMM8vPsmx+VpWiR6px3NxapwiWmPC+AasuvZE8=; b=Datb68c4sOzmS3KAbBa6PyUYdyJ17D79lLPYJzoWhs3BeAyLFELAj+R9a+KcOWc+5W DNx5wiIcpUrCZlaZCscavPD13Cb3RkyEz4A6lIPgwCB+7lRID/d66EX2YUT1FgPAyZx+ Dg4s5mGuM7eH0+q+n07Ff5/Ha2ky9gCFGRDvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IkrrilMM8vPsmx+VpWiR6px3NxapwiWmPC+AasuvZE8=; b=q1+cYz24LqtMmOONX9fGkdy8kX2HtpzucWf7cC2gHruCV7Vs56dMEjDg9OiO5eTKid k84M/3CoK720DyQMPZXwzGbkoLuY28jgNRN59s8BKlmUIdvFTQ9o4t68ZnY9iuNgE/6a pEYeivvmg/ym0F2RksUHWOlSLVtKdcW58tfMaQVuL/bUi6ZHMXyzJ1L1EddN9DS4oR4c KVFZh0/dChuqrhP9QpKHqIn3JgbRjm72jlkjiqIBCvNVBTI8dqziq3BMpkqZg9Kzq3kt jSrsLXPRxpMKrgbmRBfcb3ieb4vKFQq4BxJtjvlM/9hvjuSEwBW4Uxwr+9SPBfTdY7gq kSVg== X-Gm-Message-State: AOAM530t+ZxwdgQ4VHX6F2H7GSaE/RGYRzmUnECtwsRn4TQB//nMvq4H bKc3Zf5JROtMqoPJXx5LJBuKsA== X-Google-Smtp-Source: ABdhPJxsWNDaC40UM+MnSnIoTD46uB68hwQTDo2A0CGxl9BAvT7Y9LhChBMIgAPSWOBUmghmiEeIbQ== X-Received: by 2002:a05:6a00:228b:b0:4fa:e12b:2c7b with SMTP id f11-20020a056a00228b00b004fae12b2c7bmr4720541pfe.79.1649180484232; Tue, 05 Apr 2022 10:41:24 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c18-20020a056a000ad200b004f0f9696578sm17576189pfl.141.2022.04.05.10.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 10:41:23 -0700 (PDT) Date: Tue, 5 Apr 2022 10:41:23 -0700 From: Kees Cook To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com, catalin.marinas@arm.com, masahiroy@kernel.org, vincenzo.frascino@arm.com, will@kernel.org Subject: Re: [PATCH v1 1/2] arm64: vdso: put ELF related sections in the linker script Message-ID: <202204051040.812AD550F@keescook> References: <20220405160246.1991-1-joey.gouly@arm.com> <20220405160246.1991-2-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220405160246.1991-2-joey.gouly@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220405_104126_333304_BE3E9993 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 05, 2022 at 05:02:45PM +0100, Joey Gouly wrote: > These are the same sections as ELF_DETAILS in include/asm-generic/vmlinux.lds.h Can include/asm-generic/vmlinux.lds.h be included to just use ELF_DETAILS directly? Outside of that, yeah, this series looks good. Thanks! -Kees > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Masahiro Yamada > Cc: Vincenzo Frascino > Cc: Kees Cook > --- > arch/arm64/kernel/vdso/vdso.lds.S | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S > index a5e61e09ea92..e453e74e98f9 100644 > --- a/arch/arm64/kernel/vdso/vdso.lds.S > +++ b/arch/arm64/kernel/vdso/vdso.lds.S > @@ -54,6 +54,11 @@ SECTIONS > _end = .; > PROVIDE(end = .); > > + .comment 0 : { *(.comment) } > + .symtab 0 : { *(.symtab) } > + .strtab 0 : { *(.strtab) } > + .shstrtab 0 : { *(.shstrtab) } > + > /DISCARD/ : { > *(.data .data.* .gnu.linkonce.d.* .sdata*) > *(.bss .sbss .dynbss .dynsbss) > -- > 2.17.1 > -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel