From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98D7EC433EF for ; Wed, 6 Apr 2022 18:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zaBiTlKyY7Ucmm8Kw9NavME3sx57htYrTCm8e2iNoAE=; b=al2dZ0kLRQp8NL egeOuxSBCdy81tnp4MD81NE/fW6ZmLEgQvuyQyW0tXBQLRdDrpcf49gIP/FanSZd6IwN11ZBjoetr rm647uqe1gL75J9HeAxs44Gq1qbRLtASm0YPARVLvLpFpX1jtv9gZ2ZxHMSEgSU/WVX40rwE491bA QSHXYhtOlZx8Gr05V5wd5HOnSDmq5FZAERT2+zusZxydmp7yfqumc0uBVEsGCFzCTvTIxEWXen+As uATEIRd11tB9lmgmO3Y4ZQCggKiyKuu7YGOUsoK8JAe91nVZV28SQFiJi9ppZsRDwMSKB/j2A5fml /UGMSV47b8TG69TuhbGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncAm0-007cZf-RO; Wed, 06 Apr 2022 18:52:56 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncAlx-007cYw-Pg; Wed, 06 Apr 2022 18:52:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 813FE61655; Wed, 6 Apr 2022 18:52:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D6D2C385A5; Wed, 6 Apr 2022 18:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649271171; bh=nrUs+OgbcF/TQelOzfe+pb1CAB4eIs6PKGZnjXJNeW0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sTqP7d7u46gWoHKsoDtLH6oUOKjFyXMNobx2YOZta7MBmWAk83Fzg2xZIjxlKCDqS YdJlxgfSqKwvj3UL40BRLWVMRl2aGJGLNhg82iqQcuEAj1BEN469pl/QsynugJX7Ee dIO+0fCETGGeaYCt/N2u16tJSzXdO2C+XSnPJDiAWzf9rjL2KtTZdQ8pfjAcY3e4UU j6Uy1SjxMhJuM0b5cSwLZS2s2uKpAgL+oOJ44gZnhQSpNsbwXBrnS8iPV14ohpKCGU zfhjIbmERwVvTeYgkcScq6WVIZYIawSennGQ0kACk5Iax8VcWd/k1xD+xjJT5iKqeA vI0L8CKmrsz4g== Date: Wed, 6 Apr 2022 11:52:50 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Landen Chao , DENG Qingfang , Sean Wang , Marek Beh__n , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes that can be supported Message-ID: <20220406115250.047570c1@kernel.org> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_115253_919349_8A4606E1 X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 06 Apr 2022 11:48:57 +0100 Russell King (Oracle) wrote: > - if (state->interface != PHY_INTERFACE_MODE_MII) { > + if (state->interface != PHY_INTERFACE_MODE_MII && > + state->interface != PHY_INTERFACE_MODE_2500BASEX) > phylink_set(mask, 1000baseT_Full); > phylink_set(mask, 1000baseX_Full); > } Missing { here. Dunno if kbuild bot told you already. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel