From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0E09C433EF for ; Wed, 6 Apr 2022 08:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/kLX6f3IWxteIVuS4af2usLsQZyb4LTZkeyMc/21FPk=; b=b9PvNW53tdfnp0 HPxo8SRSPl9CkzHvEONHhYRHbTY3d9Efdc1GUwT3bsrEJRRMuYFoPxZSkp2WBpoQZht00N1j2GKGr CfSfOpsyFkpxYD+lR33cnPhANpIMQ9M2HGtnZlSKSyBmXyjP3NpISv0sDyCJKbRp1Yty1ZMBP2/kI 7Iftp6bCjkDzUQ3gHH+yRLi0+WULuplMa3p5IUk24RWwa/CN9YLoNEyzVIsyRWCaKFLxS28+ENjYW 8m75jnCmNSi3xw0BAFRZ+I1/ORxnyovartr1sSRezaJ4PTzTbo5I8MvRtLUt/u9yiD7my0sIntBpj dU52d58eP8kVIeYUApXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc0xp-004gVV-UV; Wed, 06 Apr 2022 08:24:30 +0000 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc0xO-004gJ4-L8 for linux-arm-kernel@lists.infradead.org; Wed, 06 Apr 2022 08:24:04 +0000 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2366bmFw004892; Wed, 6 Apr 2022 08:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=+zfl4b4jpnf2k67W0p67+cyN8S9JaG6yb9sB6bCdLd0=; b=PbIk056reu1ZtDpHOIZh3IgBVHKQR1hUO/ayJraYiMvTO/+e/W5nhiK+oz0uj6UlssjO LQtbyD2cf/vWU2llICQVSrJAKJlVaJmzsM3FsP/oDMpsy/PqYw1JT87KWHzZbGEmNMgj wFHUhmZBjUiumtRMjv1OAmHnkDwWBfDjFasws1KVPTGJNwky2/oDddjNUH6spr4d2hQ0 ytafH36AqXPC7ePd8nwaHb55kXHV8+FhI9B0vVL2b2vCzmNEPPeImklmOclPMUII0Nwc 3CQEp+KjpHFAhYFGK3q1k6uoUD4JbGfYUbgy6eU9xswWaygLnPYFRt3wDLRliFXPZgI9 OA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com with ESMTP id 3f6d93074v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Apr 2022 08:23:55 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2368GqdH026731; Wed, 6 Apr 2022 08:23:54 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3f974cg9qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Apr 2022 08:23:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+9p+RQlE7FtZXsZBMts6qr/PlnBSwopvNoX/9cXncxiJ7grEdjaqyRTWTLpNhqFGRHreoFERMIDaFz6dRPnh7eoZ6I5zqx9ZoLWKlmIQ127td0DAMjR/e68+NfAbBoj2pFosM6AKtQKHYfY+RTIyvk84abQ9Tl25x7cE2CmBg9+B24wQXImO5QcKmgM+2Q5ihJ9GHwCbdFP3JNz7sP/T11OZ2nZ+D7Hoo/4z6GBNLxNaJBNMy8yYmpiPqGlgJQI0fTNEqTGiZ8n/RH26z0rhzrpRmQVtKdPm1a2tmqavEmHUFMtXs+29CnXoL61FPMa5Q7AIOXZoL55FkeQk7UiLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+zfl4b4jpnf2k67W0p67+cyN8S9JaG6yb9sB6bCdLd0=; b=OgcrkKcOQu5KrNG/djb9rn997DxzlOOAl3iX3iVtNrkqAyKrYm6VruKAB9D8d5QYz7DgxWGmPHnXB1g7HrdeF4heINrzVOeA91X5Hjb3QA4HkisyNfTEjSmqgHmgLufmz3v63FVqxQNX+mZf9r+NF5jYxV2ztEyO7GNReW7RrUzf2lkRX43zJXykFxZ/L9soPimRIB+yS+tXbNNHg8kBjXT35jzFjwFW2V+mwblp0zZVaYZMmFfiEZWO5vSUnlbvCAavDSMrpKiNCqNm+mWilcdUIM5zRMXoUqenu3WS1Sur7htCrm/BUnUGS2L5kQfndMscO3VrUpwPki2x3nEKPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zfl4b4jpnf2k67W0p67+cyN8S9JaG6yb9sB6bCdLd0=; b=G+iXsxTb9RUsRdkeQSVrI9IwX1js1Lq5cNmpuU0d4HCUzg0eN+F/Z8F8WDNJcGFwR3JBMc6fPimRQ1c2c3vKVR/ILYRysjAN9wOZ56cgc7qly3cWN9qA5Q7eqJBemd0eJ1taFb2EM8kQ+8E+6AsKfBXy6v/ZUQc3t5JO+coN0w0= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DM6PR10MB4076.namprd10.prod.outlook.com (2603:10b6:5:1f7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr 2022 08:23:52 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b5d5:7b39:ca2d:1b87]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b5d5:7b39:ca2d:1b87%5]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022 08:23:51 +0000 Date: Wed, 6 Apr 2022 11:23:28 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Michal Simek Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, Shubhrajyoti Datta , Radhey Shyam Pandey Subject: [xilinx-xlnx:xlnx_rebase_v5.15_LTS 304/1079] drivers/tty/serial/xilinx_uartps.c:1518 cdns_get_id() warn: inconsistent returns '&bitmap_lock'. Message-ID: <202204061608.ed0SVSJO-lkp@intel.com> Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JN2P275CA0004.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:3::16) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6970e1e1-2a3c-4562-204b-08da17a6c834 X-MS-TrafficTypeDiagnostic: DM6PR10MB4076:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H+fpPbdycEHbsFhrvRvtaXUJj802gFKEtl1chj3MQPRSyanjw5z+P/vlHe4ecrch6n55kVN7a5tSN+E87EPNJVGS5/HhDjHEsurVnE1hu/S7zc74+1NwdPTqysVdX1CD2vgFqCoBwU4lcSvoxxXHUC784EPlJ5RS2S/L8F/n3E5Wh5D90OmNwj8nTxCtO/DLhAv8PcLAIg6Do7nzIPo/81IKxolDO2tgvWp6Tx+lRKTc1Tpz2T+XJdoZBV3YFncmzEsAmEir0dAhvumlvSVcDkEzLJWN30Q96GvkusG73wJE+B4VZVgfKNyovW/4fx9km8aUtiZhH/GeMBfvGDQm5AzHY7rKFGKdq5jJSlr/6ZgO09xueWrvOZJqytqhfHQZCv4+B8mSumZlzdpwoGP2erbrGKr4RO9LcB1cPBsTRTx9W1V+mB9dfjxHqalxUjGjVc7m7upBowztpk2C2Nn+Dtr1mUfanG+Ig/rPpZwWN8tbJLJrtfONvJW1gXgOKpkS2PukWsHQCdtGF7KIWijGJLLVkfuhAIZ+6kzdrOnQD1NCUoHiTteqghqwpO6CfOu36IgV1YmRigUkUOgKLAVouB5h1V4DhrTPOW5sq3D8TjOqcMd4McNuE6rNY5f6ZJFNZfJ9doZ3jUGc+72p2pQMupLIyLtdyBxnaQbGSUspLzoeu/IVWofqaCbvAhVOBAPkcHLzZIN4wIESN7M2RAnqyfjcxw6+B2qZgS95u8agdlBgwrUg8uX3uSr+aYepRZiIWnr00yjwrnjJPZoZtMpqymx6IL8+Gp8pWiExDauSuuNM9qq9O0CqLZbO1SlGMG1c X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2365.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(8676002)(8936002)(66556008)(186003)(26005)(66946007)(66476007)(6486002)(966005)(44832011)(1076003)(83380400001)(5660300002)(38350700002)(508600001)(38100700002)(52116002)(6506007)(9686003)(6512007)(316002)(6916009)(2906002)(54906003)(6666004)(36756003)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zxzxWQyC0bF1UnL1vnPHd2Xebl4KYsxBwHvxsE8poLwkBwwzO3870Z4MHqKG?= =?us-ascii?Q?repiOkBJBscMeCQ+YWuLqv43DbCaoKZLjecPkdQj7TTS0cZdF1YQrpF416RT?= =?us-ascii?Q?tlIpQh+UVysQRop+2xKYo352X1z7Oi+U4VrCPmS4hKNQyRLrxc/issyXzig8?= =?us-ascii?Q?I80NB70QTsVG0z25cZjXNp9GZaUomniB/Y3YGBTwMTRHltB4j/k9LPDahrH9?= =?us-ascii?Q?5Dh1i8bE+LtxFuVduvYT/gvalEwzmOSAeRVbcfwc/xicxJebvhVSzmK/psJT?= =?us-ascii?Q?D6By3l7TKjpe8SlswzKke4keodlBdGr0EkD9qUqq/VqV/9zTDpqtceywWjV/?= =?us-ascii?Q?DHLL0P+Re/Q34HGOou3rGbyixgrWi1XUGBjukGa/dAPfgP3K5/VA8TzMz4nt?= =?us-ascii?Q?hHhpfOVq2Jj//Omuo2D8IsJNz1hZbrOyEbe63pp3P/M1zYRjiVD7rWTZdtGG?= =?us-ascii?Q?0HdaCF64zfYxv7kiT97uNiAcUgTsExXz/a1Pn5apXSoIkIx1+M1wcHKx53Q4?= =?us-ascii?Q?Geb1PMwTxVtfwsxFS0RVAOERlC5BPvroHJEkqcMVrRk1t9UytSoFBPVPLh01?= =?us-ascii?Q?y5Omf0UVj0cJ+EU1+AYc33tiZ+IZ31rR5sOFBHWOIttRR3MyJhnCT8LTiccV?= =?us-ascii?Q?glQkNM5SdQTLeiodnY2kkq4zwNOlctFlx8xkHbpNXveGRVdlsSr51ItSlJO/?= =?us-ascii?Q?fuFqPiefJ35WEaQlm613ay2vc0utj6P4TgTgBw1CtDYx/2FEmLMQiCEE0gk8?= =?us-ascii?Q?kRtSSI4FqjhE42x74Ycgph6bLQc8CVfjY0QHgUwz3OUn0yfa8xihNY3ejIoP?= =?us-ascii?Q?/hmkR815ekUbHT1Ob3cuPBQnGyO5q9uKUSMN0hqlyG853SBeEMTDYVeDNigd?= =?us-ascii?Q?VS0rcM8vwXKtgxPjO6VjEDrjJ6pgNVb/viftIX6Wv7GKWIezzIgSNawrWqXs?= =?us-ascii?Q?rlCLte3jbTe7lD5KxzfiQTWhCE8xO8PTcJBRqvpsTXbSGe20/U6SVyH3LYGI?= =?us-ascii?Q?1DOm5Nbnt30Yj8wLzO1+loqL2cT5G7jn4lcK0uFB4d4MsONIZ7qiCxg/Okb0?= =?us-ascii?Q?4/Rl647CDsj7Bj0gcdt9NwT25KP+9pTs22I/v+b7BGGfaFEwAoZAsFvMGoGt?= =?us-ascii?Q?Dwlos+GwMA6X3ubYP626YO3MGY1AoO4kwf3KSqLw7joQs4ZbTUnVC8gUp6AJ?= =?us-ascii?Q?tNoYJdKH82MRIZBv2MQMOVmcX9wIMUQdz2gDjPVL+q3/vpqTvxD7IS1WmCmU?= =?us-ascii?Q?6bh4gX77BsTJsGrSO7svbYBEoiOIUjG27adVRIZKR9o9W+zsLRb8ztxSqSvS?= =?us-ascii?Q?Z0TY4dO/n4BFFNIL9oPW+uWHnxRc2XqRWAq8rrgHIRlOuhzlcDn4kGURws2Y?= =?us-ascii?Q?IEJVI8orLg1KbQqSKGaGU9FyRMZ5hGfrYQc8WKtgGXElImFdlJsxZ4+mpYfu?= =?us-ascii?Q?1S9NVytUDwyWgbFqyPAoOScSIKqdIYvdbDLs6x5w5pBXUhksd7GKT3I3vPw0?= =?us-ascii?Q?FgczD3MTaXvTdvK7IVPTaNsapilQOkc5FKoIM4zgWgqNtD9VKAqY3nlGCvRv?= =?us-ascii?Q?V+CocgJeVSxeOAA3OF4Ae1jo6tmR583zwMrSaIx02y1MvYr8k7SuQGVlXsGv?= =?us-ascii?Q?EXGPnlu8BJqoNfaVpw8zeMy7WjzoP6Jok2IXo9q8A9L81G3N0/vHZRPUvvE4?= =?us-ascii?Q?MjeH6Qk0e5pDJVyLfpbXLdXzqm6NmTVNX4KiQn//cdba/EIodRdY6J5x930/?= =?us-ascii?Q?5yXgvucoUNtfPoWszUd9K0Ze6Q7wrcc=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6970e1e1-2a3c-4562-204b-08da17a6c834 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 08:23:51.8778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82ffll2CPzi83sgQ8++Y3xjMq90fcNNOqEBuw7o+s28R2W8m5CTqsPGfaEmA0YE/XVnxcMIA5drhN7Yccr9laiTjfEDL7AP/7AeVuPtMdQs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4076 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.850 definitions=2022-04-06_02:2022-04-04, 2022-04-06 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204060039 X-Proofpoint-ORIG-GUID: NvsvoPzjRVfbdBknSYSfPgyCJFAT4c2V X-Proofpoint-GUID: NvsvoPzjRVfbdBknSYSfPgyCJFAT4c2V X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_012402_856757_08D20799 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS head: 26346d468f90100952de38511adf57513f801cf7 commit: f0090478ae8a76b733a846f50dc5559fff3c461f [304/1079] serial: uartps: Change uart ID port allocation config: powerpc64-randconfig-m031-20220405 (https://download.01.org/0day-ci/archive/20220406/202204061608.ed0SVSJO-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/tty/serial/xilinx_uartps.c:1518 cdns_get_id() warn: inconsistent returns '&bitmap_lock'. vim +1518 drivers/tty/serial/xilinx_uartps.c f0090478ae8a76b Michal Simek 2018-09-20 1454 static int cdns_get_id(struct platform_device *pdev) f0090478ae8a76b Michal Simek 2018-09-20 1455 { f0090478ae8a76b Michal Simek 2018-09-20 1456 int id, ret; f0090478ae8a76b Michal Simek 2018-09-20 1457 f0090478ae8a76b Michal Simek 2018-09-20 1458 mutex_lock(&bitmap_lock); f0090478ae8a76b Michal Simek 2018-09-20 1459 f0090478ae8a76b Michal Simek 2018-09-20 1460 /* Alias list is stable that's why get alias bitmap only once */ f0090478ae8a76b Michal Simek 2018-09-20 1461 if (!alias_bitmap_initialized) { f0090478ae8a76b Michal Simek 2018-09-20 1462 ret = of_alias_get_alias_list(cdns_uart_of_match, "serial", f0090478ae8a76b Michal Simek 2018-09-20 1463 alias_bitmap, CDNS_UART_NR_PORTS); f0090478ae8a76b Michal Simek 2018-09-20 1464 if (ret) f0090478ae8a76b Michal Simek 2018-09-20 1465 return ret; Missing mutex_unlock(&bitmap_lock); f0090478ae8a76b Michal Simek 2018-09-20 1466 f0090478ae8a76b Michal Simek 2018-09-20 1467 alias_bitmap_initialized++; f0090478ae8a76b Michal Simek 2018-09-20 1468 } f0090478ae8a76b Michal Simek 2018-09-20 1469 f0090478ae8a76b Michal Simek 2018-09-20 1470 /* Make sure that alias ID is not taken by instance without alias */ f0090478ae8a76b Michal Simek 2018-09-20 1471 bitmap_or(bitmap, bitmap, alias_bitmap, CDNS_UART_NR_PORTS); f0090478ae8a76b Michal Simek 2018-09-20 1472 f0090478ae8a76b Michal Simek 2018-09-20 1473 dev_dbg(&pdev->dev, "Alias bitmap: %*pb\n", f0090478ae8a76b Michal Simek 2018-09-20 1474 CDNS_UART_NR_PORTS, bitmap); f0090478ae8a76b Michal Simek 2018-09-20 1475 f0090478ae8a76b Michal Simek 2018-09-20 1476 /* Look for a serialN alias */ f0090478ae8a76b Michal Simek 2018-09-20 1477 id = of_alias_get_id(pdev->dev.of_node, "serial"); f0090478ae8a76b Michal Simek 2018-09-20 1478 if (id < 0) { f0090478ae8a76b Michal Simek 2018-09-20 1479 dev_warn(&pdev->dev, f0090478ae8a76b Michal Simek 2018-09-20 1480 "No serial alias passed. Using the first free id\n"); f0090478ae8a76b Michal Simek 2018-09-20 1481 f0090478ae8a76b Michal Simek 2018-09-20 1482 /* f0090478ae8a76b Michal Simek 2018-09-20 1483 * Start with id 0 and check if there is no serial0 alias f0090478ae8a76b Michal Simek 2018-09-20 1484 * which points to device which is compatible with this driver. f0090478ae8a76b Michal Simek 2018-09-20 1485 * If alias exists then try next free position. f0090478ae8a76b Michal Simek 2018-09-20 1486 */ f0090478ae8a76b Michal Simek 2018-09-20 1487 id = 0; f0090478ae8a76b Michal Simek 2018-09-20 1488 f0090478ae8a76b Michal Simek 2018-09-20 1489 for (;;) { f0090478ae8a76b Michal Simek 2018-09-20 1490 dev_info(&pdev->dev, "Checking id %d\n", id); f0090478ae8a76b Michal Simek 2018-09-20 1491 id = find_next_zero_bit(bitmap, CDNS_UART_NR_PORTS, id); f0090478ae8a76b Michal Simek 2018-09-20 1492 f0090478ae8a76b Michal Simek 2018-09-20 1493 /* No free empty instance */ f0090478ae8a76b Michal Simek 2018-09-20 1494 if (id == CDNS_UART_NR_PORTS) { f0090478ae8a76b Michal Simek 2018-09-20 1495 dev_err(&pdev->dev, "No free ID\n"); f0090478ae8a76b Michal Simek 2018-09-20 1496 mutex_unlock(&bitmap_lock); f0090478ae8a76b Michal Simek 2018-09-20 1497 return -EINVAL; f0090478ae8a76b Michal Simek 2018-09-20 1498 } f0090478ae8a76b Michal Simek 2018-09-20 1499 f0090478ae8a76b Michal Simek 2018-09-20 1500 dev_dbg(&pdev->dev, "The empty id is %d\n", id); f0090478ae8a76b Michal Simek 2018-09-20 1501 /* Check if ID is empty */ f0090478ae8a76b Michal Simek 2018-09-20 1502 if (!test_and_set_bit(id, bitmap)) { f0090478ae8a76b Michal Simek 2018-09-20 1503 /* Break the loop if bit is taken */ f0090478ae8a76b Michal Simek 2018-09-20 1504 dev_dbg(&pdev->dev, f0090478ae8a76b Michal Simek 2018-09-20 1505 "Selected ID %d allocation passed\n", f0090478ae8a76b Michal Simek 2018-09-20 1506 id); f0090478ae8a76b Michal Simek 2018-09-20 1507 break; f0090478ae8a76b Michal Simek 2018-09-20 1508 } f0090478ae8a76b Michal Simek 2018-09-20 1509 dev_dbg(&pdev->dev, f0090478ae8a76b Michal Simek 2018-09-20 1510 "Selected ID %d allocation failed\n", id); f0090478ae8a76b Michal Simek 2018-09-20 1511 /* if taking bit fails then try next one */ f0090478ae8a76b Michal Simek 2018-09-20 1512 id++; f0090478ae8a76b Michal Simek 2018-09-20 1513 } f0090478ae8a76b Michal Simek 2018-09-20 1514 } f0090478ae8a76b Michal Simek 2018-09-20 1515 f0090478ae8a76b Michal Simek 2018-09-20 1516 mutex_unlock(&bitmap_lock); f0090478ae8a76b Michal Simek 2018-09-20 1517 f0090478ae8a76b Michal Simek 2018-09-20 @1518 return id; f0090478ae8a76b Michal Simek 2018-09-20 1519 } -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel