From: Yong Wu <yong.wu@mediatek.com>
To: Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Tomasz Figa <tfiga@chromium.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>,
Hsin-Yi Wang <hsinyi@chromium.org>, <yong.wu@mediatek.com>,
<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
<xueqi.zhang@mediatek.com>, <yen-chang.chen@mediatek.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
<mingyuan.ma@mediatek.com>, <yf.wang@mediatek.com>,
<libo.kang@mediatek.com>, <chengci.xu@mediatek.com>
Subject: [PATCH v6 04/34] iommu/mediatek: Add list_del in mtk_iommu_remove
Date: Thu, 7 Apr 2022 15:56:56 +0800 [thread overview]
Message-ID: <20220407075726.17771-5-yong.wu@mediatek.com> (raw)
In-Reply-To: <20220407075726.17771-1-yong.wu@mediatek.com>
Lack the list_del in the mtk_iommu_remove, and remove
bus_set_iommu(*, NULL) since there may be several iommu HWs.
we can not bus_set_iommu null when one iommu driver unbind.
This could be a fix for mt2712 which support 2 M4U HW and list them.
Fixes: 7c3a2ec02806 ("iommu/mediatek: Merge 2 M4U HWs into one iommu domain")
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/iommu/mtk_iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 95c82b8bcc35..e4b4ebbcb73f 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -955,8 +955,7 @@ static int mtk_iommu_remove(struct platform_device *pdev)
iommu_device_sysfs_remove(&data->iommu);
iommu_device_unregister(&data->iommu);
- if (iommu_present(&platform_bus_type))
- bus_set_iommu(&platform_bus_type, NULL);
+ list_del(&data->list);
clk_disable_unprepare(data->bclk);
device_link_remove(data->smicomm_dev, &pdev->dev);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-07 8:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 7:56 [PATCH v6 00/34] MT8195 IOMMU SUPPORT Yong Wu
2022-04-07 7:56 ` [PATCH v6 01/34] dt-bindings: mediatek: mt8195: Add binding for MM IOMMU Yong Wu
2022-04-07 7:56 ` [PATCH v6 02/34] dt-bindings: mediatek: mt8195: Add binding for infra IOMMU Yong Wu
2022-04-07 7:56 ` [PATCH v6 03/34] iommu/mediatek: Fix 2 HW sharing pgtable issue Yong Wu
2022-04-07 7:56 ` Yong Wu [this message]
2022-04-07 7:56 ` [PATCH v6 05/34] iommu/mediatek: Remove clk_disable in mtk_iommu_remove Yong Wu
2022-04-07 7:56 ` [PATCH v6 06/34] iommu/mediatek: Add mutex for m4u_group and m4u_dom in data Yong Wu
2022-04-07 7:56 ` [PATCH v6 07/34] iommu/mediatek: Add mutex for data in the mtk_iommu_domain Yong Wu
2022-04-07 7:57 ` [PATCH v6 08/34] iommu/mediatek: Adapt sharing and non-sharing pgtable case Yong Wu
2022-04-07 7:57 ` [PATCH v6 09/34] iommu/mediatek: Add 12G~16G support for multi domains Yong Wu
2022-04-07 7:57 ` [PATCH v6 10/34] iommu/mediatek: Add a flag DCM_DISABLE Yong Wu
2022-04-07 7:57 ` [PATCH v6 11/34] iommu/mediatek: Add a flag NON_STD_AXI Yong Wu
2022-04-28 14:52 ` Matthias Brugger
2022-04-07 7:57 ` [PATCH v6 12/34] iommu/mediatek: Remove the granule in the tlb flush Yong Wu
2022-04-07 7:57 ` [PATCH v6 13/34] iommu/mediatek: Always enable output PA over 32bits in isr Yong Wu
2022-04-07 7:57 ` [PATCH v6 14/34] iommu/mediatek: Add SUB_COMMON_3BITS flag Yong Wu
2022-04-07 7:57 ` [PATCH v6 15/34] iommu/mediatek: Add IOMMU_TYPE flag Yong Wu
2022-04-28 14:17 ` Matthias Brugger
2022-04-07 7:57 ` [PATCH v6 16/34] iommu/mediatek: Contain MM IOMMU flow with the MM TYPE Yong Wu
2022-04-07 7:57 ` [PATCH v6 17/34] iommu/mediatek: Adjust device link when it is sub-common Yong Wu
2022-04-07 7:57 ` [PATCH v6 18/34] iommu/mediatek: Allow IOMMU_DOMAIN_UNMANAGED for PCIe VFIO Yong Wu
2022-04-07 7:57 ` [PATCH v6 19/34] iommu/mediatek: Add a PM_CLK_AO flag for infra iommu Yong Wu
2022-04-07 7:57 ` [PATCH v6 20/34] iommu/mediatek: Add infra iommu support Yong Wu
2022-04-07 7:57 ` [PATCH v6 21/34] iommu/mediatek: Add PCIe support Yong Wu
2022-04-07 7:57 ` [PATCH v6 22/34] iommu/mediatek: Add mt8195 support Yong Wu
2022-04-07 7:57 ` [PATCH v6 23/34] iommu/mediatek: Only adjust code about register base Yong Wu
2022-04-07 7:57 ` [PATCH v6 24/34] iommu/mediatek: Just move code position in hw_init Yong Wu
2022-04-07 7:57 ` [PATCH v6 25/34] iommu/mediatek: Separate mtk_iommu_data for v1 and v2 Yong Wu
2022-04-07 7:57 ` [PATCH v6 26/34] iommu/mediatek: Remove mtk_iommu.h Yong Wu
2022-04-07 7:57 ` [PATCH v6 27/34] iommu/mediatek-v1: Just rename mtk_iommu to mtk_iommu_v1 Yong Wu
2022-04-07 7:57 ` [PATCH v6 28/34] iommu/mediatek: Add mtk_iommu_bank_data structure Yong Wu
2022-04-07 7:57 ` [PATCH v6 29/34] iommu/mediatek: Initialise bank HW for each a bank Yong Wu
2022-04-07 7:57 ` [PATCH v6 30/34] iommu/mediatek: Change the domid to iova_region_id Yong Wu
2022-04-07 7:57 ` [PATCH v6 31/34] iommu/mediatek: Get the proper bankid for multi banks Yong Wu
2022-04-28 14:14 ` Matthias Brugger
2022-05-01 2:33 ` Yong Wu
2022-04-07 7:57 ` [PATCH v6 32/34] iommu/mediatek: Initialise/Remove for multi bank dev Yong Wu
2022-04-07 7:57 ` [PATCH v6 33/34] iommu/mediatek: Backup/restore regsiters for multi banks Yong Wu
2022-04-07 7:57 ` [PATCH v6 34/34] iommu/mediatek: mt8195: Enable multi banks for infra iommu Yong Wu
2022-04-19 9:00 ` [PATCH v6 00/34] MT8195 IOMMU SUPPORT AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407075726.17771-5-yong.wu@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yen-chang.chen@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).