Re: [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer

Tony Lindgren
2022-04-08T04:39:38Z

Hi,

* Nishanth Menon <nm@ti.com> [220407 13:31]:
> On 10:10-20220407, Tony Lindgren wrote:
> > diff --git a/Documentation/devicetree/bindings/timer/ti,timer.txt b/Documentation/devicetree/bindings/timer/ti,timer.txt
> > --- a/Documentation/devicetree/bindings/timer/ti,timer.txt
> > +++ b/Documentation/devicetree/bindings/timer/ti,timer.txt
> > @@ -14,6 +14,7 @@ Required properties:
> > ti,omap5430-timer (applicable to OMAP543x devices)
> > ti,am335x-timer (applicable to AM335x devices)
> > ti,am335x-timer-1ms (applicable to AM335x devices)
> > + ti,am6-timer (applicable to AM6 devices)
>
> Suggestion:
>
> Could we call this ti,am65-timer instead? AM6 is a bit nuanced and spans
> a couple of sub SoC architectures.

I think the timer hardware is the same across am64, am65 and j7. So we
should pick something to represent the am6 timers as it would allow using
shared dtsi files for the 16 - 30 timers there are.

Using shared timer dtsi files should work as long as the clocks are
defined in include/dt-bindings/clock for each SoC, and assuming we can use
the same compatible property for the timers.

Of course if the timers are really different across am64, am65 and j72
then multiple compatible properties are neeeded.

If the timer hardware is the same, then I guess we should just pick the
earliest version, so how about using ti,am64-timer?

Regards,

Tony