From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64836C433EF for ; Fri, 8 Apr 2022 07:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7NwsXUMb/HYkKyBLUlT0CP/miPp6naRUHI9melEVAU8=; b=wWCh4vHRWHFxvghjKgrACzZOxp FfS21BVzJF4gcsLshvMl/LM/2a845su48Smn5brPFCWIVeD7++qkfg6OZUC7moIuH01r8ckbsciVZ yr/uCRY1HdzvtzKJ8Sd8poVu+AHcZkFfxcuZQpspwE5cReaPrHyUy7lLvjjL8yvoos+2660L9jb5w VUVr85KRc8JL+1CFVDXMo+Z9Q+D/IoCSfFVs3/Wh5zPpAEbcgqU3ocsEbT38fo9ggYa0izaznnhck x9osbdV1iu1oBgpx2GvOBlaRI7nnZJBeIxClTosObgkYRpN+Ak3RYHmw9NVtARxc3DGUWmvCnrD5g ZQc3M/Ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncjL6-00Fc0l-CY; Fri, 08 Apr 2022 07:47:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncjL2-00FbzO-El for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 07:47:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649404042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g9nCNxmKb6VL/bN0CRtBOBvo2QBXMAIr2GAVqDlq1GI=; b=Sh6cd9vscKhn0fr0FSPoz7X7Iy4TK41fkpDZ0Jsfi6XZhY9Z+SOclU/qSj0SVZwiYbflsJ rAjdmlIiyXfddBDJEfgFSuu2/ZOZtEFyD8ywf7J6RjonrB/ygydwEFNDgGxSqiL+NOjI1G vsT87zPYFVHQmegLZmwgvKgndiuCLs4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-SLZDjppYOg6nwy_9JuvUdA-1; Fri, 08 Apr 2022 03:47:21 -0400 X-MC-Unique: SLZDjppYOg6nwy_9JuvUdA-1 Received: by mail-pj1-f71.google.com with SMTP id gq2-20020a17090b104200b001ca93cdc0f2so4315824pjb.7 for ; Fri, 08 Apr 2022 00:47:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g9nCNxmKb6VL/bN0CRtBOBvo2QBXMAIr2GAVqDlq1GI=; b=G+09NuiGUosM7juqUTt6Tt843gBN/txAEi/seaTll0ViMoHUCuwvKzA4EmBuCvCAmq 5qK5gHqXBmGSQ4nmumx9kgE6IhtWBlt3pyTLGhKdHf/u3IhmadU17B3vB6E7gvFUmb0d AaQBtC6yOaig0VLTyrGJYHXU2SofZ2FOQ89A692ghcbRkPGQwmKhMceu7SlKF9ZqO+8a yHlA772awwVfW2pZqcj0Nvu8msxpiVVPfWyIhXD7ocRm3JOdwL5h///4SoNChnE/Xgo7 wr90G+qCKm9S6zd4i6QwYHjDe6q37TOMA5a0dFfYt0LDfFucDsLJ1ARz1GU+pMPAY25p aX6Q== X-Gm-Message-State: AOAM530QCBGE1YGJ7pufFbdLw1uQsW7DH//x2NDD62U/fVIxlNaWsBpU Bcx8ag0XADqtMZM2G0Joh/yp4oGVav9OI5nx9iwI4NBC2A/fTGkNFYfQLaFTP3aUP2S82orA6zv VDa9m3y7Toudq8e/paOeMt7IA0URrByAE7Ck= X-Received: by 2002:a17:903:124a:b0:154:c7a4:9375 with SMTP id u10-20020a170903124a00b00154c7a49375mr17953398plh.0.1649404039951; Fri, 08 Apr 2022 00:47:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsJjxqFSErmPWDmi5nwu8F53ijnirAHxNY2giI2+zUq/FPsFy4myWA73fqbdFtNPDdOCtDUw== X-Received: by 2002:a17:903:124a:b0:154:c7a4:9375 with SMTP id u10-20020a170903124a00b00154c7a49375mr17953360plh.0.1649404039614; Fri, 08 Apr 2022 00:47:19 -0700 (PDT) Received: from localhost ([240e:3a1:31c:360:52fc:c968:cb41:efbc]) by smtp.gmail.com with ESMTPSA id x38-20020a056a0018a600b004fafd05ac3fsm25584490pfh.37.2022.04.08.00.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 00:47:19 -0700 (PDT) Date: Fri, 8 Apr 2022 15:47:04 +0800 From: Coiby Xu To: Michal Suchanek Cc: Catalin Marinas , Will Deacon , Heiko Carstens , Vasily Gorbik , "Lee, Chun-Yi" , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Philipp Rudo , Baoquan He , Alexander Egorenkov , AKASHI Takahiro , James Morse , Dave Young , Mimi Zohar , Kairui Song , Martin Schwidefsky , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH 0/4] Unifrom keyring support across architectures and functions Message-ID: <20220408074704.wkyyv2qnx66iinzo@Rk> References: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=coxu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_004724_621923_F38B4894 X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, As mentioned by Baoquan, I have a patch set "[PATCH v5 0/3] use more system keyrings to verify arm64 kdump kernel image signature" [1]. The differences between your patch set and mine are as follows, - my patch set only adds support for arm64 while yours also extends to s390 - I made the code for verifying signed kernel image as PE file in x86 public so arm64 can reuse the code as well which seems to be better approach - I also cleaned up clean up arch_kexec_kernel_verify_sig Would you mind if I integrate your first 3 patches with mine as follows - for arm64, I'll use my version - for s390, I'll use your version For your last patch which allows to use of platform keyring for signature verification of kernel module, I'll leave it to yourself. How do you think about it? [1] https://lore.kernel.org/all/20220401013118.348084-1-coxu@redhat.com/ On Tue, Feb 15, 2022 at 08:39:37PM +0100, Michal Suchanek wrote: >While testing KEXEC_SIG on powerpc I noticed discrepancy in support for >different keyrings across architectures and between KEXEC_SIG and >MODULE_SIG. Fix this by enabling suport for the missing keyrings. > >The latter two patches obviously conflict with the ongoing module code >cleanup. If they turn out desirable I will add them to the other series >dealing with KEXEC_SIG. > >The arm patches can be merged independently. > >Thanks > >Michal > >Michal Suchanek (4): > Fix arm64 kexec forbidding kernels signed with keys in the secondary > keyring to boot > kexec, KEYS, arm64: Make use of platform keyring for signature > verification > kexec, KEYS, s390: Make use of built-in and secondary keyring for > signature verification > module, KEYS: Make use of platform keyring for signature verification > > arch/arm64/kernel/kexec_image.c | 13 +++++++++++-- > arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++----- > kernel/module_signing.c | 14 ++++++++++---- > 3 files changed, 34 insertions(+), 11 deletions(-) > >-- >2.31.1 > -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel