Re: [PATCH 00/11] drm: bridge: Add Samsung MIPI DSIM bridge

Adam Ford
2022-04-11T14:41:08Z

On Mon, Apr 11, 2022 at 8:56 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> On 08.04.2022 18:20, Jagan Teki wrote:
> > This series supports common bridge support for Samsung MIPI DSIM
> > which is used in Exynos and i.MX8MM SoC's.
> >
> > Previous RFC can be available here [1].
> >
> > The final bridge supports both the Exynos and i.MX8MM DSI devices.
> >
> > On, summary this patch-set break the entire DSIM driver into
> > - platform specific glue code for platform ops, component_ops.
> > - common bridge driver which handle platform glue init and invoke.
> >
> > Patch 0000: Samsung DSIM bridge
> >
> > Patch 0001: platform init flag via driver_data
> >
> > Patch 0002/9: bridge fixes, atomic API's
> >
> > Patch 0010: document fsl,imx8mm-mipi-dsim
> >
> > Patch 0011: add i.MX8MM DSIM support
> >
> > Tested in Engicam i.Core MX8M Mini SoM.
> >
> > Anyone interested, please have a look on this repo [2]
> >
> > [2] https://protect2.fireeye.com/v1/url?k=930e329a-f28527b5-930fb9d5-74fe485cbfe7-b0c53e2d688ddbc5&q=1&e=e6aa727d-5ae2-4ca5-bff3-7f62d8fae87e&u=https%3A%2F%2Fgithub.com%2Fopenedev%2Fkernel%2Ftree%2Fimx8mm-dsi-v1
> > [1] https://lore.kernel.org/linux-arm-kernel/YP2j9k5SrZ2%2Fo2%2F5@ravnborg.org/T/
> >
> > Any inputs?
>
> I wanted to test this on the Exynos, but I wasn't able to find what base
> should I apply this patchset. I've tried linux-next as well as
> 95a2441e4347 ("drm: exynos: dsi: Switch to atomic funcs").
>
> Please note that pointing a proper base for the patchset is really
> essential if you really want others to test it.

Can you clone his repo and test that? He posted it above. I was
going to clone it at some point this week to give it a try.

adam
>
>
> > Jagan.
> >
> > Jagan Teki (11):
> > drm: bridge: Add Samsung DSIM bridge driver
> > drm: bridge: samsung-dsim: Handle platform init via driver_data
> > drm: bridge: samsung-dsim: Mark PHY as optional
> > drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()
> > drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset
> > drm: bridge: samsung-dsim: Add module init, exit
> > drm: bridge: samsung-dsim: Add atomic_check
> > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts
> > drm: bridge: samsung-dsim: Add input_bus_flags
> > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support
> > drm: bridge: samsung-dsim: Add i.MX8MM support
> >
> > .../bindings/display/exynos/exynos_dsim.txt | 1 +
> > MAINTAINERS | 12 +
> > drivers/gpu/drm/bridge/Kconfig | 12 +
> > drivers/gpu/drm/bridge/Makefile | 1 +
> > drivers/gpu/drm/bridge/samsung-dsim.c | 1803 +++++++++++++++++
> > drivers/gpu/drm/exynos/Kconfig | 1 +
> > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1704 +---------------
> > include/drm/bridge/samsung-dsim.h | 97 +
> > 8 files changed, 1982 insertions(+), 1649 deletions(-)
> > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
> > create mode 100644 include/drm/bridge/samsung-dsim.h
> >
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland