From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD756C433F5 for ; Fri, 8 Apr 2022 23:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dM/QDX7I4wZBw+2M4BL0caQZb2qMR5GHJpob3EIQV9w=; b=YaIEo1Oyd+Uab5 bkIKE+oFRFWBG0StY63q5tRxKqrvCca+B4o8Qmj+BpCCXtsl2URIRgtQCRLF7msSmgcJfE5Mlr228 quH/HtgOFyOcvJ+lujvCYxzsot7Tvg3JvJHNCVasQxfIq2XG70r7wAw7CtcUVaYVHYq4pFZhWxhQx HD5rF1qSoepPAL1OGl/AmoitjfbzHVfvAM4QVE9wHlEIDhbN9Xtv4y9/yTNAJkOYUcBaGArLozTIi BPLThCdEz+zsxT9aGr9klCj7AfyxCyF7+28trfZ4e/Q+qPiO1VsmopnCFxRs92Oms085T4xW5TqTp zQ1XVr8Cc1VAcoXhvyrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncyNY-001V7B-5w; Fri, 08 Apr 2022 23:51:00 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncyNU-001V69-Pm for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 23:50:58 +0000 Received: by mail-ej1-x631.google.com with SMTP id bq8so20136104ejb.10 for ; Fri, 08 Apr 2022 16:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SUqMtItyQZq0VImWzHlQNyf9xOR5YZgjl7HG7ggaASA=; b=nJriARLQYTMhH8chWXt44TKYI93PSDPUJtZYNgzWWUVvzVxPGiCZEEj1or0iOTefo6 cFscWaA85nZ2Y/kClhUqsgDfbrhKPUZDkkzyM5PK+amxjD4B9bkaMfh3UvILoEcBIGVp pD9y/wuXRsQe30azkivrcgDlMms0jSrgpc0B4YRML0nOkZ8W8oa2xa3dmJEJI48q7Lph hERaCN4LvyngWLcE/nNTdaJoURQxBLZ0UWrRoEU5cNkW9BTCN6Tydlp6kYyBV95RnXZw p2O6zP4x77KUbOQ1olKZSBNoc7+rWVjcHZXqzKdeMH9GniNs2g4IkkVS8/3XGbjIDWwo 0yJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SUqMtItyQZq0VImWzHlQNyf9xOR5YZgjl7HG7ggaASA=; b=66E4rAopaX24Ee30A+6DIYu4YnpY5vBPmwyNZHrsKzD4I+4nwKcgEBsC/BjAP7pqYH SRQOUDp1Q6hPdyWIqXEKlUS/T7LBGDrPDWR5LISoh3BvGq9smLR5mIX589Wo7m9vJzLN YBjqsUYO8gkEDvX42sIFpV1oMkIJSAuoPanlydeXiZWirhLd90Hw+F2oj1qlmSyN8SPd F2U310/E9o1s7ZVLk1R7fVcTZeUvOMrHENAnmzRHRoElz0FVIKyujFYL/U3L/KL7fxht yJ1ARMTBa4IBGMy+UKh35oAnIO0uV8xZ9y5iOcTOyDetaFz4kWNfAwF6NOx5s0daMB/d R+Mg== X-Gm-Message-State: AOAM532nRgNG1PrlUJJcaBK+HkJ7bHpFHswWDMLVJbbRTThIb3EBcc/F ULopEJzC+2lx5WY34vqGNsA= X-Google-Smtp-Source: ABdhPJx48I6qNVXy5JRlDDppagH8Z8UT68EDC0Z1VNqIiGnngdmjei8lBxcmBqvnL8jnUCdrueVd4Q== X-Received: by 2002:a17:906:9c82:b0:6df:baa2:9f75 with SMTP id fj2-20020a1709069c8200b006dfbaa29f75mr20667399ejc.762.1649461854531; Fri, 08 Apr 2022 16:50:54 -0700 (PDT) Received: from skbuf ([188.26.57.45]) by smtp.gmail.com with ESMTPSA id w14-20020a509d8e000000b0041cd217726dsm7443672ede.4.2022.04.08.16.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 16:50:54 -0700 (PDT) Date: Sat, 9 Apr 2022 02:50:51 +0300 From: Vladimir Oltean To: Jakob Koschel Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Florian Fainelli , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Casper Andersson , Bjarni Jonasson , Colin Ian King , Michael Walle , Christophe JAILLET , Arnd Bergmann , Eric Dumazet , Di Zhu , Xu Wang , Netdev , LKML , Linux ARM , linuxppc-dev , Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Subject: Re: [PATCH net-next 03/15] net: dsa: mv88e6xxx: Replace usage of found with dedicated iterator Message-ID: <20220408235051.2a4hh7p3lee3a3xv@skbuf> References: <20220407102900.3086255-1-jakobkoschel@gmail.com> <20220407102900.3086255-4-jakobkoschel@gmail.com> <20220408123101.p33jpynhqo67hebe@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_165056_878602_7AB99530 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 09, 2022 at 01:44:00AM +0200, Jakob Koschel wrote: > > Let's try to not make convoluted code worse. Do the following 2 patches > > achieve what you are looking for? Originally I had a single patch (what > > is now 2/2) but I figured it would be cleaner to break out the unrelated > > change into what is now 1/2. > > I do agree with not making convoluted code worse, but I was reluctant with > e.g. introducing new functions for this because others essentially > have the opposite opinion on this. > > I however like solving it that way, it makes it a lot cleaner. Yeah, I think 'just adapt to the context and style and intentions of the code you're changing and don't try to push a robotic one-size-fits-all solution' is sensible enough for an initial guiding principle. > > If you want I can submit these changes separately. > > Sure if you want to submit them separately, go ahead. Otherwise I can > integrate it into a v2, whatever you prefer essentially. If you're moving quickly feel free to pick them up. I have lots of other things on my backlog so it won't be until late next week until I even consider submitting these. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel