From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38505C433F5 for ; Sat, 9 Apr 2022 10:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qfffdl3LcUQQHgST+qAAlrPx5VrD9E6QoGBWcWB1UgI=; b=BYj3dfIYg06qH8 b1irfiTMTdBw6L2KfdNelwaP2rYQO/Jfc8Tu+l/vE2xf30mHZX0ro0O3OYT4cjAVLR2Fz5CyO7nBT wVViFivCUMYkL3kTHz0/XbMWOPdvJShj5WtD/eBfqhmYp01wcLCKQawWPUMPtqDh9X+DGhhQY3nHC +/ntd+x9vYb7E6EwDPMuZT4lJzFLvr+NtkKWwvgcwZ13pKPXo86g/Tmi0m4WKA8gzlyWxWPFpcZTb uXNRab2ED/sfrqYsKXozfQLASIZcyiNJva9E6MGq1EYfJtQ4kIDbh9tlzu42Dr13DLzMRVdL0EAy3 78a1Q1nEnR/k+nF6RkBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd7sp-002kw3-13; Sat, 09 Apr 2022 09:59:55 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd7sl-002kvf-PZ for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 09:59:53 +0000 Received: by mail-ej1-x62d.google.com with SMTP id bh17so21655585ejb.8 for ; Sat, 09 Apr 2022 02:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=N4XJfs2B+Cri2iOejBgjUkpCtU57s9kSfpppvvyrQ3Y=; b=nCAc3eD+ukkUEzJ+5m0uI1Yk9ZLxaGw4gCZilaLJMFu3LwVidMWBJNsv4nCr4xaFGB XOIkpON+cxcV0sSDyCxcFz5tweWwxjl9pdmg0McvIABk/wSL/C+uMof2TytvT2k9Oarf PC2DoRXaIxsNglfmCcQxingTPZYXnWhaJ/boelOQH7dFSim74h9FwvMRioIuyTwgjFUC XlrKg1kHS2sba/oQ3SU1Uhbe8MnpsKj2wigGrocU99fnvELvlqkvlBEQowo5iObfwgsz iO9bddAjlwOWkyQGR9KkUmGJ6rXwkt7WgAXs/laz4ew5+arw4DsV9MMHAej1ogrYxiBn 5v3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N4XJfs2B+Cri2iOejBgjUkpCtU57s9kSfpppvvyrQ3Y=; b=n0Ayd6AEQPySTW5e8y9cAh+A8TwE/TGLRNhcS9oUdCuNsGgoP/BJdjviT/O6qXp1ZJ mB/SVpYWBgg7YpjfiJiUCUMBrk+49BiQxw3TgpiQ235DWgs5BZDhOz5yPhopqFrYC4d4 EOv0WzE1CEqM0hjuAoX6YbJxOqzkctE5hFQKnnjA/pwa7vT1Zruxw/5oyQ3XPPHv2gbL a8gEffw4Rb1aEAy3Tjoml8l2KkqwM/PlrDbw2Ms2VprKmNoMdC2Et25IyzwlTdqvyv7h 42lMnrffURVN2jqWaGpJb9hV73Zy5mDW8AbsTU/n1QrBtld+2itPg00YFlAgqPttpC8e v2FA== X-Gm-Message-State: AOAM532LJuFcvTabzWHJcrfrA0Lz3BBcvD6VHHD9vsjTo/j2Rau27f6t AcVmBWiGyABjFvZ50+u6KiK82w== X-Google-Smtp-Source: ABdhPJzia8lT1grS0oZhObzaXk1Mxby37e8QeLtr75r2MAWa1O9h8k6Ly94DLakgv4ib364h5bhSKA== X-Received: by 2002:a17:907:72c7:b0:6e8:442c:1722 with SMTP id du7-20020a17090772c700b006e8442c1722mr8607936ejc.120.1649498388695; Sat, 09 Apr 2022 02:59:48 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id e11-20020a17090681cb00b006e86b594e1fsm785527ejx.207.2022.04.09.02.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 02:59:48 -0700 (PDT) Date: Sat, 9 Apr 2022 17:59:41 +0800 From: Leo Yan To: Namhyung Kim Cc: James Clark , Arnaldo Carvalho de Melo , linux-perf-users , leo.yan@linaro.com, German Gomez , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Arnaldo Carvalho de Melo , Ravi Bangoria , linux-arm-kernel@lists.infradead.org, linux-kernel Subject: Re: [PATCH] perf: arm-spe: Fix perf report --mem-mode Message-ID: <20220409095941.GA1000846@leoy-ThinkPad-X240s> References: <20220408144056.1955535-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_025951_939272_C9C9AB19 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 08, 2022 at 11:13:09AM -0700, Namhyung Kim wrote: > Hello, > > On Fri, Apr 8, 2022 at 7:41 AM James Clark wrote: > > > > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info > > is not available") "perf mem report" and "perf report --mem-mode" don't > > allow opening the file unless one of the events has PERF_SAMPLE_DATA_SRC > > set. > > > > SPE doesn't have this set even though synthetic memory data is generated > > after it is decoded. Fix this issue by setting DATA_SRC on SPE events. > > This has no effect on the data collected because the SPE driver doesn't > > do anything with that flag and doesn't generate samples. > > > > Fixes: bb30acae4c4d ("perf report: Bail out --mem-mode if mem info is not available") > > Signed-off-by: James Clark > > Acked-by: Namhyung Kim Tested-by: Leo Yan It's a bit awkward that after the commit bb30acae4c4d we cannot be backward compatible and any old perf data file will be failed to support by 'perf mem report' tool. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel