From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8FCBC433F5 for ; Sun, 10 Apr 2022 01:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oODEC381h4ibSCHPW+Sp1Tn8llxKSvRimeDIPYiVlbc=; b=RAnk/csxinPE9X Y8tyec+4rZxIewiCdlehLEH213vKrGIGRSYqVZnne5O7UM3iMyzeEYavCI7jSRPSJh0Bg5aerbSIt CDs1Y2bGXZG6uUdC+24NZlHWjPTjEgYvNZib/+6LzYMHXI/tjA2mL2PIEYiad5aqf9r793Dc/oCwG EVWk+lLxMyIZSW43UNT3tHxM8DAosQDHAjkcqIah+8+AmSZReqGM/oA/t82XYoI1JUA+Inl5W4I2M czpg9uMdzM/XdDwHE7/B+luAB1F4cyXpgjvIVYdXUjQAvuQL4R/fwuS7QVEbliMC1Eo0A5+zQe+jB FdunyZmjTIIPM3fyZvjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndM67-003zmu-1V; Sun, 10 Apr 2022 01:10:35 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndM63-003zmK-9m for linux-arm-kernel@lists.infradead.org; Sun, 10 Apr 2022 01:10:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C38DCB80185; Sun, 10 Apr 2022 01:10:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87877C385A0; Sun, 10 Apr 2022 01:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649553028; bh=Z/tB8bGdmjpVmeRIP8sMA1pejWdPqmHeBhXIGj4yzYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TL0xNjwIZ21uqdRMy1dk9YwQ7+cgGccIyBHB7AH2RPPdVxM606wNPd4nImAe+QO0K bOzBwMXP7j/WDw7bTdmVnaiEXlJSfZs7SAM7NERp4dCHz1i9XtcC/O5otJvByFEEmj Po20k7R2gwrsLZLnCgLpcJRQk7AmN9sjPADqwrws3IPN4QBz75R4c7w+g8oxkU2nVF uCZ/SE9jM7ROhnNNfVi0ksc4MD5s67ukPR9a6fXplI9TCTW9MePOt7V9KKiF7fFDns 5Yvmff+2bTZ0DGogT4jugFQYsnwbX8Oa/7O6P1ztbSpAZgcJbWYggLg5/9AkJ7ZuJI 7z+Zag8d1h85Q== Date: Sun, 10 Apr 2022 09:10:23 +0800 From: Shawn Guo To: Li Yang Cc: Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] arm64: dts: ls2080a-qds: add mdio mux nodes from on-board FPGA Message-ID: <20220410011023.GG129381@dragon> References: <20220317190109.3742-1-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220317190109.3742-1-leoyang.li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_181031_524869_35B63BE0 X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 17, 2022 at 02:01:04PM -0500, Li Yang wrote: > Add mmio mdio mux nodes from the on-board FPGA. > > Signed-off-by: Li Yang > --- > .../boot/dts/freescale/fsl-ls2080a-qds.dts | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts > index f6c3ee78ace0..c3caca1c0ab6 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts > @@ -23,3 +23,72 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > }; > + > +/* Update DPMAC connections to external PHYs, under SerDes 0x2a_0x49. */ > +&dpmac9 { > + phy-handle = <&mdio0_phy12>; > + phy-connection-type = "sgmii"; > +}; > + > +&dpmac10 { > + phy-handle = <&mdio0_phy13>; > + phy-connection-type = "sgmii"; > +}; > + > +&dpmac11 { > + phy-handle = <&mdio0_phy14>; > + phy-connection-type = "sgmii"; > +}; > + > +&dpmac12 { > + phy-handle = <&mdio0_phy15>; > + phy-connection-type = "sgmii"; > +}; > + > +&ifc { > + boardctrl: board-control@3,0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "fsl,tetra-fpga", "fsl,fpga-qixis", "simple-mfd"; > + reg = <3 0 0x300>; > + ranges = <0 3 0 0x300>; > + > + mdio_mux_emi1 { > + compatible = "mdio-mux-mmioreg", "mdio-mux"; > + mdio-parent-bus = <&emdio1>; > + reg = <0x54 1>; /* BRDCFG4 */ Please ensure the patch doesn't introduce additional DTC warnings. I think 'reg' should present only in nodes with a matching unit-address. Shawn > + mux-mask = <0xe0>; /* EMI1_MDIO */ > + > + #address-cells=<1>; > + #size-cells = <0>; > + > + /* Child MDIO buses, one for each riser card: > + * reg = 0x0, 0x20, 0x40, 0x60, 0x80, 0xa0. > + * VSC8234 PHYs on the riser cards. > + */ > + > + mdio_mux3: mdio@60 { > + reg = <0x60>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mdio0_phy12: mdio_phy0@1c { > + reg = <0x1c>; > + }; > + > + mdio0_phy13: mdio_phy1@1d { > + reg = <0x1d>; > + }; > + > + mdio0_phy14: mdio_phy2@1e { > + reg = <0x1e>; > + }; > + > + mdio0_phy15: mdio_phy3@1f { > + reg = <0x1f>; > + }; > + }; > + }; > + }; > +}; > + > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel