From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D3FEC433EF for ; Sun, 10 Apr 2022 14:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3knGnk7dFmswFH1H0OejWSdutVf9xYp/ADYs/uDspQo=; b=o+LOCvTYS1gRtz 3mubP6Sm2lvipx2y2Yc1RpAx7MRp/oH2xl7/4TkoUHqdXRoEYkmuloTkt0zdmZMsx0syeXshemhI7 94335t+6j0Piq9bZgtr54cu0jP2zRngvPwNGmkXUtiDKKUIldNvyvJSy93nFW/OrcxlCkBghrpAZ+ gwI/DUdd9EvcNGH48gwodqNhgLIwiJV9Qiv/KQ+gzoC3Nsk6QItMSK0N7HBPyOMF7Yl8agFtv8DmG W+yreryNT2nq+XDawbfyKJXl+e90xHbSkrVjJSRfYwPGg4A6NjC5pDn/GVuzC8eDwP3PwOAp/LrAQ 2/n1cqtNgcigfLkXclSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndYf5-004zEV-3o; Sun, 10 Apr 2022 14:35:31 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndYf1-004zE8-Vz for linux-arm-kernel@lists.infradead.org; Sun, 10 Apr 2022 14:35:29 +0000 Received: by mail-ed1-x531.google.com with SMTP id v4so1814981edl.7 for ; Sun, 10 Apr 2022 07:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eTOdXk23m0jnDdzRGCxaR/MFXhCBLn0KmXc705LQ8io=; b=tYI1JyIFHFrHxxOvc576qb1b2qrpxDEj7uajtZkxxxbP//OHX6b8tpkcaMrxgncmua Kl4X8exdveN7R3HkpJv7yWBfznp5G1V1YjzMy3FRUhqIBy5Rfah0kpAsu/26CiEPsYXG RwQ17Lea3XNoY1sF5CzJ7nhPYQ22woI5g+hwX7D/z3n2nnaFj/gbke5Ean/2WUnfgetC /21FdUUv93ZkooS8jezWHqW8/FBwsjG9p6mNj5bY111Fz0ISzX0p0aC65O3jBSLTPONH vAPtKdTiWV3VtA/evfGNjcv4/c0R0D923QvZQhj5gdqYrn9eBVHTmlinhrM1w3B6Wzbk 4fJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eTOdXk23m0jnDdzRGCxaR/MFXhCBLn0KmXc705LQ8io=; b=z9C+JUNgFxphxu29DfsNGllp1ugDgrUHsIoWyTMAPs0QgtiuODBZ64o5kQ50nhKNYP KUIokIYqiwM7GVGm2Nxt2tFnmdPgTzFvn6wN+9qmXtdRthxw1gPfal1ifAHikbCFDcnh FA9kpEN3kmsJbTqueLbdR7e9nid/rzF+itEKPOdP+OEmEpVJCpeB7k2TrPYJFvzsI920 nWs44QtM6Rm35Gty+n7lej3sU6+l0LN8mRskqY+xAiev+C6Jm4K8sHAFRtGgyZenw1tS sVqYEPKuzv4kul0a0RjbN2umoh2MaiwYLiUU3OsQnV1xVzAEDoOudVZGEcptWvtABm+U bqjw== X-Gm-Message-State: AOAM533iTuDjbhgGvweQzDPQvaxR94f0W2V3o8pfIdD9bkf+Wr95lRVd B2ksYA/3XyDWHDUKs0H13ITpGA== X-Google-Smtp-Source: ABdhPJxreNnaYua1edc9AwH1IrWzc7BaRzLjxEf+3cBwCy80r76YN6goNZuhnEDAWvwRKvMoMZHppw== X-Received: by 2002:a05:6402:158e:b0:41d:176:7594 with SMTP id c14-20020a056402158e00b0041d01767594mr18638652edv.214.1649601325090; Sun, 10 Apr 2022 07:35:25 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id c13-20020a17090654cd00b006e0db351d01sm10912522ejp.124.2022.04.10.07.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 07:35:24 -0700 (PDT) Date: Sun, 10 Apr 2022 22:35:17 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo Cc: Namhyung Kim , James Clark , linux-perf-users , leo.yan@linaro.com, German Gomez , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Arnaldo Carvalho de Melo , Ravi Bangoria , linux-arm-kernel@lists.infradead.org, linux-kernel Subject: Re: [PATCH] perf: arm-spe: Fix perf report --mem-mode Message-ID: <20220410143517.GA226043@leoy-ThinkPad-X240s> References: <20220408144056.1955535-1-james.clark@arm.com> <20220409095941.GA1000846@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220410_073528_133273_768DA16C X-CRM114-Status: GOOD ( 28.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 09, 2022 at 12:12:37PM -0300, Arnaldo Carvalho de Melo wrote: > Em Sat, Apr 09, 2022 at 05:59:41PM +0800, Leo Yan escreveu: > > On Fri, Apr 08, 2022 at 11:13:09AM -0700, Namhyung Kim wrote: > > > Hello, > > > > > > On Fri, Apr 8, 2022 at 7:41 AM James Clark wrote: > > > > > > > > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info > > > > is not available") "perf mem report" and "perf report --mem-mode" don't > > > > allow opening the file unless one of the events has PERF_SAMPLE_DATA_SRC > > > > set. > > > > > > > > SPE doesn't have this set even though synthetic memory data is generated > > > > after it is decoded. Fix this issue by setting DATA_SRC on SPE events. > > > > This has no effect on the data collected because the SPE driver doesn't > > > > do anything with that flag and doesn't generate samples. > > > > > > > > Fixes: bb30acae4c4d ("perf report: Bail out --mem-mode if mem info is not available") > > > > Signed-off-by: James Clark > > > > > > Acked-by: Namhyung Kim > > > > Tested-by: Leo Yan > > > > It's a bit awkward that after the commit bb30acae4c4d we cannot be > > backward compatible and any old perf data file will be failed to > > support by 'perf mem report' tool. > > oh well, I think we should put in place a mechanism to run perf record > before some change, then make sure that a new perf is able to process > it after a rebuild. > > If its something unsurmountable, then a proper explanation should be > done with a workaround to process those older files, even if pointing > out to the perf version that is able to process the old file. I will follow up to add a sub test case for Arm SPE with 'perf mem'. I tried to find possible workround for old perf data files but failed, the 'perf mem' tool reports error in a very early time so I cannot add workaround in Arm SPE specific code (e.g. arm_spe_process_auxtrace_info()). I will check furthermore, as a backup will send a patch to remind suitable perf version. A backlog task for me is to setup an automatic testing envoirnment for daily testing perf on Arm64. I will setup an automatic testing for this. > Anyway, applying this pa tch. Thanks! Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel