From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3904CC433F5 for ; Mon, 11 Apr 2022 00:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d/iZyMCL1nTS0rHDs71xJAonp4Fi8ZfAokwzDbOigjc=; b=uNMHs3WRkcbRG3 qv4YIl/Z0bL1EiiS09VMEDMSaEzOU1tin7a1Z6rI6xVTLZlXYdaXnXvA2S9xUg9BRpsdUsKGjmWgO BtFxnXoT7W0yshKM3YSxnl+70rfJp+z3c8mn1xUZ+o0zOZymhG2XcAll0cnQSaWLKVehgFEdqox/v 1Fe22a0MD83By34gpKPMBSBU/iPrpZOFxupDhtN2CEsXEAq58FrZmUR0N21bIaKC51AkgOoRYUx5R fvANGmGQyPMSSS3Ae7/vPf3Xdz51Rse1Xelc7hhW0yt/WCPXgjkq3NfZl+KATh/gf8G5H8nmFJ+FT QQ5ANWFiMrtwqnsyJ5aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndiKD-0061O8-Dr; Mon, 11 Apr 2022 00:54:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndiKB-0061NA-2I for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 00:54:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C7B560EF4; Mon, 11 Apr 2022 00:54:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EF8EC385A4; Mon, 11 Apr 2022 00:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649638474; bh=rHmqtbKujz1oumBfQyH6US6UQG40oo7hEHJvzLUxX4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qqw1DzrX8HDF4Z8nDWHUPix5K+JLU8m7wz3curLSEb8A6dPWFanpmUvRALJzJ4rwb eLrQPp195BXch5ljoCiN+7mTFo3itcQFSlsucNmTopPdeGElp/PIvPHaVwTvPG68ll sqAeCYSJ7QU6fZnLCNu8mTvVZoNbC3KeSS7uxTo4ZbuiXGSHbAnfVL4oJh2Fah/d+e dgBNCVgBUaQ/GukWqW8wA5lZoy2lsQ90OO4Tt0z9hhj++Bj3T1THztmdoz7uE1M2zS A3aQ39OwkZwksmEtjN8+wLlk8hZQ5hF2MSfJfS0LnkjHx9klG/OYA42qwdSGeb3hb3 Bs5zFMFf7ziXQ== Date: Mon, 11 Apr 2022 08:54:28 +0800 From: Shawn Guo To: Michael Walle Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: ls1028a: default to OTG mode for USB Message-ID: <20220411005428.GV129381@dragon> References: <20220330113442.3402940-1-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220330113442.3402940-1-michael@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220410_175435_185746_474D0A18 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 30, 2022 at 01:34:42PM +0200, Michael Walle wrote: > At the moment, the dtsi will force the dr_mode to host. This is > problematic because it will always turn on the Vbus voltage regardless > if the port is host or device. This might lead to a "shortcut" between > the two USB endpoints because both might have their Vbus supplies > enabled. Therefore, the default should be "otg" for any ports which > aren't host only (from a SoC point of view) and have a user of the dtsi > file overwrite that explicitly. > > Move the 'dr_mode = "host";' into the board dts. Now that the dtsi > doesn't set the dr_mode anymore, we can also drop the 'dr_mode = "otg";' > in the board dts because that is the default value if dr_mode is not > set. > > Signed-off-by: Michael Walle Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel