From: Shawn Guo <shawnguo@kernel.org>
To: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: linux-arm-kernel@lists.infradead.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
kernel test robot <lkp@intel.com>,
weiyongjun1@huawei.com
Subject: Re: [PATCH] bus: imx-weim: Mark weim_of_notifier static
Date: Mon, 11 Apr 2022 16:06:55 +0800 [thread overview]
Message-ID: <20220411080655.GA391514@dragon> (raw)
In-Reply-To: <20220411074525.yjdhyz2mezz6v4sq@h-e2.ddg>
On Mon, Apr 11, 2022 at 10:45:25AM +0300, Ivan Bornyakov wrote:
> Hi, Shawn!
>
> On Mon, Apr 11, 2022 at 10:56:18AM +0800, Shawn Guo wrote:
> > Mark weim_of_notifier static to fix the sparse warning below.
> >
> > drivers/bus/imx-weim.c:373:23: sparse: sparse: symbol 'weim_of_notifier'
> > was not declared. Should it be static?
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: e6cb5408289f ("bus: imx-weim: add DT overlay support for WEIM bus")
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> > drivers/bus/imx-weim.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> > index 60fbd42041dd..d10c9f1031b6 100644
> > --- a/drivers/bus/imx-weim.c
> > +++ b/drivers/bus/imx-weim.c
> > @@ -370,7 +370,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
> > return ret;
> > }
> >
> > -struct notifier_block weim_of_notifier = {
> > +static struct notifier_block weim_of_notifier = {
> > .notifier_call = of_weim_notify,
> > };
> > #endif /* IS_ENABLED(CONFIG_OF_DYNAMIC) */
> > --
> > 2.25.1
> >
>
> There was a similar patch already.
> See: https://lore.kernel.org/all/20220226094333.3269016-1-weiyongjun1@huawei.com/
Ah, for some reason, the patch did not appear in my mailbox. Thanks for
point it to me! Applied that instead.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-11 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 2:56 [PATCH] bus: imx-weim: Mark weim_of_notifier static Shawn Guo
2022-04-11 7:45 ` Ivan Bornyakov
2022-04-11 8:06 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411080655.GA391514@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=i.bornyakov@metrotek.ru \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=lkp@intel.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).