From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B1EEC433EF for ; Mon, 11 Apr 2022 08:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7DdtKT/d2uD0VhVwhUM+cYAlOMLOnz8/jYbJd5Ey+jg=; b=zoTDa9LKsFUC35 bfNS99PZ3Tjqe2hRlbwBnyRzIy5JJaZ6YvX55yPNZwr9JFjQvPQlrbTO1jnYm2l0cKd9kZQ4qOAXV LLE/KvWdUwoY5UdFkhrsVandiW2oRbodqPcJ8381Raj5Mytzi0xZzCW9ii3aJDj51GtuXCQ3cZsKK 9EUEo2gOKGkVVBcDRh8w6QGPywUlvnbuj3k6Iagq423bKAApF3M8/SusV00nUpi2+jl+JM1NBJpzI 381ZbqEPNbu1WL+o0n5HoPyCv8bKyCZnafA/8ArQu1mRkfB7Mi+1qMlFa94WUN2nT8ZZk/LkkD4XV bHDHCrCy2YLvNpOXL8vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndp4l-007S1P-D6; Mon, 11 Apr 2022 08:07:07 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndp4i-007S0i-8E for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 08:07:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 92C07B81126; Mon, 11 Apr 2022 08:07:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1F23C385A5; Mon, 11 Apr 2022 08:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649664421; bh=9dLC2DV+bsYRZsUWwLY5rxVOK5ZjHG191v4ok6TdrKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=avj80udDMu8fQvPVWzQ5SePAmZbn8Xy4GuPjelaCKDr6dPX9vCkfzcmBpc9BvTGqo JsR6l94tmmHhr1EpBeptouWSO3zjcf4cANM60tteMTSGgOryE7ISiRrAyge8jnVzH3 +WFReTTiC2L5J2YoxKzmD1JmApL955QUZo7KwUHSNLevGqSSzW5LdKq+0ipVWTOgYw 0L2L7R0KGzaqFx443Pr3p2HYINqUY6T7UZRfu+3ATc/vgyBNmJpQg8gXHh5soe/gpm JjhyhSNKQi+uprlmOuC0MEcbrSnC4f2XraoqGn9qL/IZlVVFMC7LsR5hM6oQv69izP 1CO6Ig4r1jJXQ== Date: Mon, 11 Apr 2022 16:06:55 +0800 From: Shawn Guo To: Ivan Bornyakov Cc: linux-arm-kernel@lists.infradead.org, Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , kernel test robot , weiyongjun1@huawei.com Subject: Re: [PATCH] bus: imx-weim: Mark weim_of_notifier static Message-ID: <20220411080655.GA391514@dragon> References: <20220411025618.387648-1-shawnguo@kernel.org> <20220411074525.yjdhyz2mezz6v4sq@h-e2.ddg> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220411074525.yjdhyz2mezz6v4sq@h-e2.ddg> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_010704_478678_8F53A22E X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 10:45:25AM +0300, Ivan Bornyakov wrote: > Hi, Shawn! > > On Mon, Apr 11, 2022 at 10:56:18AM +0800, Shawn Guo wrote: > > Mark weim_of_notifier static to fix the sparse warning below. > > > > drivers/bus/imx-weim.c:373:23: sparse: sparse: symbol 'weim_of_notifier' > > was not declared. Should it be static? > > > > Reported-by: kernel test robot > > Fixes: e6cb5408289f ("bus: imx-weim: add DT overlay support for WEIM bus") > > Signed-off-by: Shawn Guo > > --- > > drivers/bus/imx-weim.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > > index 60fbd42041dd..d10c9f1031b6 100644 > > --- a/drivers/bus/imx-weim.c > > +++ b/drivers/bus/imx-weim.c > > @@ -370,7 +370,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action, > > return ret; > > } > > > > -struct notifier_block weim_of_notifier = { > > +static struct notifier_block weim_of_notifier = { > > .notifier_call = of_weim_notify, > > }; > > #endif /* IS_ENABLED(CONFIG_OF_DYNAMIC) */ > > -- > > 2.25.1 > > > > There was a similar patch already. > See: https://lore.kernel.org/all/20220226094333.3269016-1-weiyongjun1@huawei.com/ Ah, for some reason, the patch did not appear in my mailbox. Thanks for point it to me! Applied that instead. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel