From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26918C433EF for ; Mon, 11 Apr 2022 21:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qNah91X+pyQkne206HH5VjWC4IZuSM4VQVZESbk5MiQ=; b=GRMLGLjyNxVi1w UVhl7W3pPJI0ny0UqKPiCR9SthxlUcz5yl0yRXzbK22LSAeASyid0ezB35xVLnLXlzQJrCvgXyiN9 KtoyX7F40phPOY/ZGXwPWbcslauzxsYvqpUykmqQRPWHFfyY24UmJOWnNWpwWVH7DPB/8fozCw2oU bB7YPg4BX83qdoY4IHJfKLWASGQZgyjUDyEJfuZvisf4ku7NGGrMaqjNFzH3/TkoXtcx3EavFK1J9 E9XBFrnwkBjVlJzT74Qz0IA0QoT2i6HWjIB4OSD0XhqT2PvOROSUD5NPgZkZlk9qkBYEjcUo/0U7H aoJx0R36IRgBR9rXmkoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne1Q4-00AWwI-Qh; Mon, 11 Apr 2022 21:17:56 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne1Q1-00AWvT-8D for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 21:17:54 +0000 Received: by mail-lj1-x22d.google.com with SMTP id r18so6068669ljp.0 for ; Mon, 11 Apr 2022 14:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=i0zDKPAt/qufZ/2jxiglBqBb3LU9NVf66CHpPtR+y0U=; b=SL7bvtN5kIiGOoqp4g1eJjN4b+D1XnkBCJjrGWEx3fqmVWNV2vI3QsrsCAwL+/TUhH TaofrnTJq7QNBNJw1e8Hxs7NXBWGMmBaGE5L5QP/YOlU5zTKHE3AyTO8ScvY9hOLqPXg 165zanGQoZQO7gSM5qDrimAma3Iv27KTx/Pl65umQPJepvY146IlZQs7xww2soJstFqy jzbT/zaC85v9AuzePoFQYXQ6AFN+O+PWwH12KBX0P6uUpD9aTCjoAKo7qN04bIF0BZrp dro1Q37yiqwcHLriURQwEa9/0YW/kq4nMfn90QVZe4ndX/h3wwYh7W/8Tz0mitK5uDp4 Q2pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i0zDKPAt/qufZ/2jxiglBqBb3LU9NVf66CHpPtR+y0U=; b=Qo2umXjHQKKa+zdDNNeP3W2tWmiLTUFsF9GzlfsOXRo2GYvmXtlZfLiF9/PtstFFUW vuCt/AKsjvzmtjyuWItvwkuh1DsLw6BYVHum9QRECculIstcecUEZPN/v4baFYDYp2s5 SQzxFGgVHVsQIftSDBGkn4006+wuzmMAv+rcCD21u8yqjXxuvG+v7cw489KBwgEpcAFV 5fTVS36hPlHkx0mHUEiDyVVYzgHI/VxtazheYaejTEQswIf4dkn2DELR4zepGw57Bp2B QwfaeqAQmndNtL7hvnG0onsmu4EYZHysB12I5Ey2dZyMIryRk9rB1BsY3hfmCn/zQ1WK gNKQ== X-Gm-Message-State: AOAM533pYZEpIx8EwK9GyzKn9KXzG82soT4gKRToZn6+g4X3HDDHJKrS koH72nV++Ljqjz79tvTtufE= X-Google-Smtp-Source: ABdhPJxeTr2tnLXOWLID+EcB1R5yGfZdzHA5Pr5lRRx+5q2f6Pvr7LZvKQK3f8TLdcv5bY3x5nnvXg== X-Received: by 2002:a2e:9a8b:0:b0:24b:4ffa:638f with SMTP id p11-20020a2e9a8b000000b0024b4ffa638fmr11338355lji.192.1649711870402; Mon, 11 Apr 2022 14:17:50 -0700 (PDT) Received: from mobilestation ([95.79.134.149]) by smtp.gmail.com with ESMTPSA id i4-20020a056512318400b0044a31d60589sm3428966lfe.86.2022.04.11.14.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 14:17:49 -0700 (PDT) Date: Tue, 12 Apr 2022 00:17:47 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Serge Semin , Brad Larson , linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings Message-ID: <20220411211747.ttpqk7s37j3gpzxp@mobilestation> References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-6-brad@pensando.io> <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_141753_334950_DC95C97E X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 07, 2022 at 08:52:34PM +0200, Krzysztof Kozlowski wrote: > On 07/04/2022 01:36, Brad Larson wrote: > > The Pensando Elba SoC has integrated the DW APB SPI Controller > > and requires the property pensando,syscon-spics for access > > to the spics control register. > > > > Signed-off-by: Brad Larson > > --- > > Change from V3: > > - Add required property pensando,syscon-spics to go with > > pensando,elba-spi > > Thank you for your patch. There is something to discuss/improve. > > > > .../bindings/spi/snps,dw-apb-ssi.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > index d7e08b03e204..41c3bbf5a55c 100644 > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > @@ -37,6 +37,21 @@ allOf: > > else: > > required: > > - interrupts > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - pensando,elba-spi > > + then: > > + properties: > > + pensando,syscon-spics: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the system control device node which provides access to > > + the spics control register > > It looks you only need to poke one register from spics, so it could be > something like: > > items: > - items: > - description: Phandle to the system control device node > - description: spics control register offset Right, especially seeing that's the way the elba-specific part of the DW APB SSI driver expects the property being initialized. -Sergey > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel