From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A471C433EF for ; Tue, 12 Apr 2022 07:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tOTONwOH9G8si2XzQktGlmo9VSQQ2OuLgq1Lr0Ghs3I=; b=gPmTdgU5pXRCNZ nGoc7tdfwEiw53VhXm0u2+st5bNMNT3vSmu7TlA52VWYx+HPhg8WgWdBzzewRprhBZdW3+saf+cGu isoYfIaxmpmqO7VEGZ/2H6xd5uW6W/iVkrcZB4xYvw5jW6HcL2Gi/7jo7PmBGNeD6NuBG9WEZf/F9 iilTtmHJ5tBFo/U/B4rJeBtcWNKtn/TNgYmepE1lOoH9D2T6HFawdMLXIeN7d2Pxv+VkowZBLoGzL UOjPiYkkL8OpZ8iRdJp95uyGKMfJW0mlTdt+ClIywYClahUHZkFutf6ySAGiq1PpZ640fzZRfR7WJ SFen7ZLliNVu5hiuWkTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neAgf-00C6c5-SZ; Tue, 12 Apr 2022 07:11:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neAfY-00C619-58 for linux-arm-kernel@bombadil.infradead.org; Tue, 12 Apr 2022 07:10:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vPcJ0Jyf7TJXhPIUKaJIMiRr+nnNAGQ8o4ZIzMyfJYY=; b=JfeLXhwuu380orBQHL6JRm1SVF ECgAYHr9tIUbUxfb+zKByQ6M5m+UdFOUQ3oWMUgfARd8XUeBIcoZKH4jMTF0OLs1YmEiCyYE8hkGF XeAvGXsdinDYUCjJZxz8av+f1EguCiwG6ujUBcMZk64iEp/JwJs2onTAAlsbh9dlFgQyuTN/rfqH1 CXc/7TG6vwZodEaUB48AU2zdyv0KpVtqtNVkG1Etqm5djS39M0C2LM1Q4BHXQmYYinaJ2TknXylvG 79BlEtn404BwdqU+lAF3zdqB1ZAjc0YYEabv0Pb9CRim3qTlsCFdSU9sav2J9o8doCeMah26Wz5SW foWlpEMA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1neAfS-004F93-S8; Tue, 12 Apr 2022 07:10:27 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 2AA8D98619A; Tue, 12 Apr 2022 09:10:26 +0200 (CEST) Date: Tue, 12 Apr 2022 09:10:26 +0200 From: Peter Zijlstra To: Andrew Morton Cc: Yu Zhao , Stephen Rothwell , linux-mm@kvack.org, Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, page-reclaim@google.com, x86@kernel.org, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v10 08/14] mm: multi-gen LRU: support page table walks Message-ID: <20220412071026.GU2731@worktop.programming.kicks-ass.net> References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-9-yuzhao@google.com> <20220411191621.0378467ad99ebc822d5ad005@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220411191621.0378467ad99ebc822d5ad005@linux-foundation.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 07:16:21PM -0700, Andrew Morton wrote: > On Wed, 6 Apr 2022 21:15:20 -0600 Yu Zhao wrote: > > +#ifdef CONFIG_LRU_GEN > > +static void mem_cgroup_attach(struct cgroup_taskset *tset) > > +{ > > + struct cgroup_subsys_state *css; > > + struct task_struct *task = NULL; > > + > > + cgroup_taskset_for_each_leader(task, css, tset) > > + break; > > Does this actually do anything? Yeah, it finds the first leader if there is any, but this is indeed quite terrible coding style. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel