From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E662FC433EF for ; Tue, 12 Apr 2022 11:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RvPDOEYVpDubgYP0p+pvuhewgbSB3cNEl0uhU5GAeMk=; b=MXlGn6mlpMqOjg l6IpgmEDcUxEGYOx6kfNbUTDnPJgh+g8xs4jw9z2lzR/4k5oa/hdLaUsmz3L9RwK+Q4j4mozPckSn spzlUeEZozXvjXftx2o+CWygEDrtxIoeTMNRJgXq5jUThy1ns3MJ54b7tQqB1y7qmDP9mgkzwIBAZ 8HZ8SwbWiEb5GGL1b9746SnS7AbHmN6jMguDOesnwjhjCVLORyN4rLPkmBkhMc6hoOvVKFarjKznH KRJ+1GIDa2bnxI+2pQy3ytL6BI5Q+V2Tq/Rknx2T2nA3XsexZ6NWygTf29/9RRh73UJwOvkZHxxBJ 0D7anhLoctQa9rjJcwcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEjC-00DhZi-Qm; Tue, 12 Apr 2022 11:30:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neETB-00Dagr-In for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 11:14:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7DCB1570; Tue, 12 Apr 2022 04:13:56 -0700 (PDT) Received: from lpieralisi (unknown [10.57.8.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DD5F3F5A1; Tue, 12 Apr 2022 04:13:55 -0700 (PDT) Date: Tue, 12 Apr 2022 12:14:01 +0100 From: Lorenzo Pieralisi To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT , Miquel Raynal , rafael@kernel.org Subject: Re: [PATCH 16/18] PCI: aardvark: Add suspend to RAM support Message-ID: <20220412111401.GA20749@lpieralisi> References: <20220220193346.23789-1-kabel@kernel.org> <20220220193346.23789-17-kabel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220220193346.23789-17-kabel@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_041401_712469_A9BE0A66 X-CRM114-Status: GOOD ( 26.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+Rafael] On Sun, Feb 20, 2022 at 08:33:44PM +0100, Marek Beh=FAn wrote: > From: Miquel Raynal > = > Add suspend and resume callbacks. The priority of these are > "_noirq()", to workaround early access to the registers done by the > PCI core through the ->read()/->write() callbacks at resume time. This commit log should be rewritten to clarify it. IIUC, you are hooking up the _noirq() callbacks to take advantage of callbacks ordering rather than needing the IRQ disabled per-se. Thread here: https://lore.kernel.org/linux-pci/20220220193346.23789-17-kabel@kernel.org I'd ask Rafael please if this is common practice or a workaround and whether that's how it should be done. Thanks, Lorenzo > Signed-off-by: Miquel Raynal > Signed-off-by: Pali Roh=E1r > Signed-off-by: Marek Beh=FAn > --- > drivers/pci/controller/pci-aardvark.c | 39 +++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > = > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controll= er/pci-aardvark.c > index 3b51f47abd72..8c9ac7766ac7 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -1896,6 +1896,44 @@ static int advk_pcie_setup_phy(struct advk_pcie *p= cie) > return ret; > } > = > +static int __maybe_unused advk_pcie_suspend(struct device *dev) > +{ > + struct advk_pcie *pcie =3D dev_get_drvdata(dev); > + > + advk_pcie_disable_phy(pcie); > + > + clk_disable_unprepare(pcie->clk); > + > + return 0; > +} > + > +static int __maybe_unused advk_pcie_resume(struct device *dev) > +{ > + struct advk_pcie *pcie =3D dev_get_drvdata(dev); > + int ret; > + > + ret =3D clk_prepare_enable(pcie->clk); > + if (ret) > + return ret; > + > + ret =3D advk_pcie_enable_phy(pcie); > + if (ret) > + return ret; > + > + advk_pcie_setup_hw(pcie); > + > + return 0; > +} > + > +/* > + * The PCI core will try to reconfigure the bus quite early in the resum= e path. > + * We must use the _noirq() alternatives to ensure the controller is rea= dy when > + * the core uses the ->read()/->write() callbacks. > + */ > +static const struct dev_pm_ops advk_pcie_dev_pm_ops =3D { > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(advk_pcie_suspend, advk_pcie_resume) > +}; > + > static int advk_pcie_probe(struct platform_device *pdev) > { > struct device *dev =3D &pdev->dev; > @@ -2171,6 +2209,7 @@ static struct platform_driver advk_pcie_driver =3D { > .driver =3D { > .name =3D "advk-pcie", > .of_match_table =3D advk_pcie_of_match_table, > + .pm =3D &advk_pcie_dev_pm_ops, > }, > .probe =3D advk_pcie_probe, > .remove =3D advk_pcie_remove, > -- = > 2.34.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel