From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE92DC433EF for ; Tue, 12 Apr 2022 22:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/XqTK9yn/InDh6v/vaDawbNwmp2Y5S+/AYFmbXk2MDI=; b=zWi7aI+Ka+9W7e JnGPYEAqna2J6NiGFnEcdlO+5JMjPwHG1K4bF7pJxVCpvhMhCP9ADLXb+rvNf0F0nAxz/HW5p6eLa 47E+k03+wurnahHo1tHloCrXmD5oguKK6oJbS3cXl6wvZCygqBKmf1rTlXRdTR+c2gPyOdZ/ppgTb aLVx1zoQ02vdz/yNWL0Ceo2US7quxuDSmxzEn73x1poZh2aN4+a8yAhzjd83EYGC2Unop8KuxDN9Y VjSfYgYkXMw0FZUzmlfcDRDI1fctmkFBxRY0UwolOFXqQw1IFQ2LsF1Ir5yxa5wG3O7ZktPqfElIR 4VvNyUYQ75BZ/Dx7g2mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neOpi-00Fx7s-9I; Tue, 12 Apr 2022 22:17:58 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neOpd-00Fx7J-VZ for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 22:17:55 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 23CMHiDr025325; Tue, 12 Apr 2022 17:17:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1649801864; bh=nyNY/m9ONJlCKzS4q3CdtgYdHO/OxuVygYMFfJGfbVc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=wNWOhax4SJjeNOYOlDh/guaxqjCaoCnetpB9byCEN81YlcKpAgDhE3L3VluOSuYVf 5wvXqx1oDqR/KaHrL+B1Mo/lENn677nehWEtZATpnawi/WT3skoWn/metfU/7ftVtr vxU8vwSn+rFAxwY24SnlVBT5XZcoPCVrKWPNVA/A= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 23CMHi3n059118 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 12 Apr 2022 17:17:44 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 12 Apr 2022 17:17:43 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 12 Apr 2022 17:17:43 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 23CMHhdk128579; Tue, 12 Apr 2022 17:17:43 -0500 Date: Tue, 12 Apr 2022 17:17:43 -0500 From: Nishanth Menon To: Krzysztof Kozlowski CC: Krzysztof Kozlowski , Rob Herring , Alexandre Belloni , Alessandro Zummo , , , , , Vignesh Raghavendra Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add TI K3 RTC devicetree bindings documentation Message-ID: <20220412221743.vbectb4bcghau2b7@confider> References: <20220412073138.25027-1-nm@ti.com> <20220412073138.25027-2-nm@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_151754_132649_0471B252 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14:06-20220412, Krzysztof Kozlowski wrote: > > +properties: > > + compatible: > > + items: > > No need for items. Just enum under the compatible. Will fix in next rev. Thanks for catching. > > > + - enum: > > + - ti,am62-rtc > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: VBUS Interface clock > > + - description: 32k Clock source (external or internal). > > + > > + clock-names: > > + items: > > + - const: "vbus" > > + - const: "osc32k" > > No quotes. Uggh.. my bad. yup > > > + > > + power-domains: > > + maxItems: 1 > > + > > + assigned-clocks: > > + description: | > > + override default osc32k parent clock reference to the osc32k clock entry > > + maxItems: 1 > > + > > + assigned-clock-parents: > > + description: | > > + override default osc32k parent clock phandle of the new parent clock of osc32k > > + maxItems: 1 > > Usually assigned-clockXXX are not needed in the bindings. Is here > something different? They are put only to indicate something special. I wonder if I should rather use unevaluatedproperties instead? If I use additionalProperties: False, then the second example below fails. Thoughts? > > > + > > + wakeup-source: true > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + rtc@2b1f0000 { > > + compatible = "ti,am62-rtc"; > > + reg = <0x2b1f0000 0x100>; > > + interrupts = ; > > + power-domains = <&bar 0>; > > + clocks = <&foo 0>, <&foo 1>; > > + clock-names = "vbus", "osc32k"; > > + wakeup-source; > > + }; > > + > > + - | > > + #include > > + rtc@2b1f0000 { > > + compatible = "ti,am62-rtc"; > > + reg = <0x2b1f0000 0x100>; > > + interrupts = ; > > + power-domains = <&bar 0>; > > + clocks = <&foo 0>, <&foo 1>; > > + clock-names = "vbus", "osc32k"; > > + wakeup-source; > > + assigned-clocks = <&foo 1>; > > + assigned-clock-parents = <&foo 2>; > > + > > Unneeded blank line. Ack. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel