From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA13DC433F5 for ; Wed, 13 Apr 2022 14:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M1HweIPOBW6l4ka7+gGEfH13KXz17zMB0rEOmzbr6a8=; b=LcXQ1GZOFEQm5F n0JjSmbPqfnQ2zQZIf0VK5jRLFtO7XH9Rl297wzQZs7eo1N5C/X4q4HZXylPv+CUufQzxYbPPhirP NVDfz35RG38lLntvhfJXmewDIAW0cYL+MaPaciLUdh9x9y0BIVjFlqtpLZ3ISqHb8ul5VERXOB6oJ pG0ejM6zo8FQiHfywNghGnVljo6IPgCzQf4rLhcp4igGOT6zrVD5AKKArTCCNgXJiwbyc6zJ7hPSN eGgotCdNoXiJy+8spErK+c+JT5r0j9PeIY52YmsXBSlEIsNCkbCxuulIPTK+ydj1KLkcqRWYfEJmB crBtt2n4AlD4RapVjh2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nedeQ-001KSe-7B; Wed, 13 Apr 2022 14:07:18 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neddm-001K6a-Gj for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 14:06:40 +0000 Received: by mail-ej1-x629.google.com with SMTP id s18so4283927ejr.0 for ; Wed, 13 Apr 2022 07:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1K/RPiyzv/rwySVDedqK5ecMTT01CdoSCB+tdz/b9HI=; b=bYPycsGq1Dy1M+2s+8o3DuKr3Bt4dqO5oF3Q7J8B4f7KxwxbLRYfMcws+fXB8veOYp gsCxuu8nkIQXuF9wTkli8wllqevhX7i6IMDRjr4Xoqts7Xg4p3emJNgGeV20sO/FJuDn YaYFdNPeg/d6GeUVOTslta7snioXVLoz3cajM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1K/RPiyzv/rwySVDedqK5ecMTT01CdoSCB+tdz/b9HI=; b=Ycc8Zudxxglci+SiaFGL7F+jNsi5LV/qIlS92kzYC26yhXYLbgqcykipMV4phGeZ8B vLVKvwRvPS0veKtlCgecOWMp2/ltveraDxWd9o8C8FfyTs7Y/5L1hJsuAdOrvuZlaGGC qOoNbGPOmVbO9JwBYpL58c3ZyHsl1y3TVFJmQy3VFfWFAWYB3HfR9TgSxwcBm2hpa2N0 sMrjhV8ZClpi0ChcBg22TCLmmyFxSzpVBmxGfldUTHWL2sc6Y7CN3dvQUkoDiHD8oQKD lHHgWR3NMfUoA2/DowdWAEtg+43ygjNLuJetV12KVq6khZnMDklecXLMqyO31voC62V7 P+CQ== X-Gm-Message-State: AOAM5333XiE9dqt8G9U1o6MrIeUnYw1qGctyJB6VrkVs3qrrKqNngl9F Ku2XcTp6KLRkojj5c8yURZX9KA== X-Google-Smtp-Source: ABdhPJyDLkxYfQJbdeaHEzd/tsYxg3C6HOqAziPxNHd+yNsF3Zci7M5aRWaWBaPd2d5DkowAVVjbXA== X-Received: by 2002:a17:906:c282:b0:6ce:369d:3d5 with SMTP id r2-20020a170906c28200b006ce369d03d5mr38884028ejz.425.1649858794786; Wed, 13 Apr 2022 07:06:34 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (host-95-245-147-71.retail.telecomitalia.it. [95.245.147.71]) by smtp.gmail.com with ESMTPSA id o5-20020a50c905000000b0041d828d0c58sm1197762edh.53.2022.04.13.07.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 07:06:34 -0700 (PDT) Date: Wed, 13 Apr 2022 16:06:32 +0200 From: Tommaso Merciai To: Krzysztof Kozlowski Cc: linux-amarula@amarulasolutions.com, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Joakim Zhang , Li Jun , Tim Harvey , Richard Zhu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mm-evk: add pwm1/backlight support Message-ID: <20220413140632.GC4713@tom-ThinkPad-T14s-Gen-2i> References: <20220413125636.28650-1-tommaso.merciai@amarulasolutions.com> <8283132d-c271-d1b8-cb28-8f95305b11ec@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8283132d-c271-d1b8-cb28-8f95305b11ec@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_070638_700149_208F1D1C X-CRM114-Status: GOOD ( 21.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 03:45:44PM +0200, Krzysztof Kozlowski wrote: > On 13/04/2022 14:56, Tommaso Merciai wrote: > > Add pwm1/backlight support nodes for imx8mm_evk board. > > Align with u-boot dts > > > > Thank you for your patch. There is something to discuss/improve. > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > index 6d67df7692f1..4c18f8fcd377 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > @@ -59,6 +59,15 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > > enable-active-high; > > }; > > > > + backlight: backlight { > > + status = "okay"; > > All nodes have status=okay by default, so no need for this. > > > + compatible = "pwm-backlight"; > > + pwms = <&pwm1 0 5000000>; > > + brightness-levels = <0 255>; > > + num-interpolated-steps = <255>; > > + default-brightness-level = <250>; > > + }; > > + > > ir-receiver { > > compatible = "gpio-ir-receiver"; > > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > > @@ -395,6 +404,12 @@ &wdog1 { > > status = "okay"; > > }; > > > > +&pwm1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_backlight>; > > + status = "okay"; > > This is needed if the node was disabled in DTSI (I did not check it). > > > Best regards, > Krzysztof Hi Krzysztof, Thanks for review, I'll update in v3. Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel