From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: broonie@kernel.org, catalin.marinas@arm.com,
kaleshsingh@google.com, madvenka@linux.microsoft.com,
mark.rutland@arm.com, will@kernel.org
Subject: [PATCH 6/6] arm64: stacktrace: align with common naming
Date: Wed, 13 Apr 2022 15:59:10 +0100 [thread overview]
Message-ID: <20220413145910.3060139-7-mark.rutland@arm.com> (raw)
In-Reply-To: <20220413145910.3060139-1-mark.rutland@arm.com>
From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
For historical reasons, the naming of parameters and their types in the
arm64 stacktrace code differs from that used in generic code and other
architectures, even though the types are equivalent.
For consistency and clarity, use the generic names.
There should be no functional change as a result of this patch.
Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
---
arch/arm64/kernel/stacktrace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index d5a195748aff..0467cb79f080 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -159,12 +159,12 @@ NOKPROBE_SYMBOL(unwind_next);
static void notrace unwind(struct task_struct *tsk,
struct unwind_state *state,
- bool (*fn)(void *, unsigned long), void *data)
+ stack_trace_consume_fn consume_entry, void *cookie)
{
while (1) {
int ret;
- if (!fn(data, state->pc))
+ if (!consume_entry(cookie, state->pc))
break;
ret = unwind_next(tsk, state);
if (ret < 0)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-13 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 14:59 [PATCH 0/6] arm64: stacktrace cleanups Mark Rutland
2022-04-13 14:59 ` [PATCH 1/6] arm64: stacktrace: remove NULL task check from unwind_frame() Mark Rutland
2022-04-13 14:59 ` [PATCH 2/6] arm64: stacktrace: delete PCS comment Mark Rutland
2022-04-13 15:02 ` Madhavan T. Venkataraman
2022-04-13 15:59 ` Mark Brown
2022-04-13 16:11 ` Mark Rutland
2022-04-13 14:59 ` [PATCH 3/6] arm64: stacktrace: make struct stackframe private to stacktrace.c Mark Rutland
2022-04-13 15:03 ` Madhavan T. Venkataraman
2022-04-13 15:59 ` Mark Brown
2022-04-13 14:59 ` [PATCH 4/6] arm64: stacktrace: rename unwinder functions Mark Rutland
2022-04-13 14:59 ` [PATCH 5/6] arm64: stacktrace: rename stackframe to unwind_state Mark Rutland
2022-04-13 14:59 ` Mark Rutland [this message]
2022-04-13 16:00 ` [PATCH 6/6] arm64: stacktrace: align with common naming Mark Brown
2022-04-19 17:10 ` [PATCH 0/6] arm64: stacktrace cleanups Kalesh Singh
2022-04-22 18:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413145910.3060139-7-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kaleshsingh@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=madvenka@linux.microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).