From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1B1AC433F5 for ; Wed, 13 Apr 2022 17:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mG8JYcStKiP29YtmF2jOz5qPvtWkzjRw9ZMno8uEg4M=; b=z7vCPI59cw46JZ CjruHeJ79yg6lPjNDQ0koYePxQ6wRaMCTazoISo7HBRGJRR5nQk9SD0urf2XgyxNaxzFVxem0cEeM J4F13gG6195UELD0Pw5scTnmU8zQN1LoC3abDIM/l79JGWlMZD1hFKf6+u7BKwLzsQb7wv1e3PGKC oH0s6MjFGp+D/PajKeyCaqGWDEs7P8sfSTORUAEfPx3WdqPUccS7vwar5TfSj9uQWDdOCbJtSePWI pyoskQHPyYjXOEYshYqYFk6lD9duU910YhiYHQpBtb7nzKOWuOQ2/8s5ecAr+Lkb3YMaCeRmIGlxx qMQOoUimWuITz+9olO9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1negUB-001taX-US; Wed, 13 Apr 2022 17:08:56 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1negU8-001tYu-71 for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 17:08:53 +0000 Received: by mail-pg1-x52d.google.com with SMTP id bg9so2351060pgb.9 for ; Wed, 13 Apr 2022 10:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gb2pwnJxQCeX1p5Gf89t6OOnZOca+zkoLeUQmGIHLHg=; b=CPs3vqLTF09CMgTab8x9Ri+G24uOHBXWWWEAUkRO1S+OWraBkrJq2shwEm9GPg7RQp 8SpZhaUK+5lZROHq9Jucju2hEkLgBcW3G5Vbuyt9DLVRH+PjXVq8DsL7XoKIo1Lcc9Qn 1K7Hk+G232f2zSFp6O3WQ6xXFiYd1k8EIa1X8azyZZCMcC4P+3rfDVaHoeZrXBXBSM7v yhgHkCKe0hV1xvZ8DIkS1+lNs5vPd979sU8m/1Wj/4MoycAgiiRL8pAcIzlLHHLj0HcZ t6w2AWyS8gAbuL9gdsnH44PEZaHMXqwEmARFEgff+m8boc/1sys19LTAxZKNKS0NWSPh LLsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gb2pwnJxQCeX1p5Gf89t6OOnZOca+zkoLeUQmGIHLHg=; b=qvB4ZNVvJHiAaCajjdGa4B0Wo/ZDdLGth58i9/dtmXJOe+anNnAOIn7u4c9pp7UNmh cSjakRgoqBM8dCgllgs+aqUc9MJuRf0RnfsXb/arflOVLuXtCRA5CNYLZK3i19zSmbYR H0IUZPNqo/sLF0frJFGdeJtiO6xOk+KtjXusJ6iIZUt/LMNZRzfcI7abiFE2FAE/SQ/F Aphq9r4hvMiOMB9CxfkneNERtxWRxnkuVRPKSkvydZrNTo7adYFOJAqe+QpwA/JuuRNb XJdSWvRwTwu5ltAI66LkWTs6gaLELsjSXupBvIIJw3jTWueK7GmcJPkxemlaeeUR7zuc MKDw== X-Gm-Message-State: AOAM531WJLW57SljsDb4NO1Su89kjOsErp66bGVy/fYaK1k2s3ttnCfi jPq9Bh5jRu/IHdgl/j4yhXy+RQ== X-Google-Smtp-Source: ABdhPJzmyeNTjT8payfffo2e+zvZZNQy61/OLXQEWbtTcsIzOAYNKWCGTLx3Omt4qhWj92tC0Y7utw== X-Received: by 2002:a05:6a00:1a01:b0:505:b3e5:b5fc with SMTP id g1-20020a056a001a0100b00505b3e5b5fcmr18828315pfv.53.1649869728158; Wed, 13 Apr 2022 10:08:48 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id rj13-20020a17090b3e8d00b001c77bc09541sm3618780pjb.51.2022.04.13.10.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 10:08:46 -0700 (PDT) Date: Wed, 13 Apr 2022 11:08:44 -0600 From: Mathieu Poirier To: James Clark Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, mike.leach@linaro.org, anshuman.khandual@arm.com, leo.yan@linaro.com, Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/15] Make ETM register accesses consistent with sysreg.h Message-ID: <20220413170844.GA547134@p14s> References: <20220304171913.2292458-1-james.clark@arm.com> <20220323162257.GC3248686@p14s> <4ef77445-b58d-a71a-0ddc-70e308ea99c8@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4ef77445-b58d-a71a-0ddc-70e308ea99c8@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_100852_297415_C6A985B2 X-CRM114-Status: GOOD ( 26.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 28, 2022 at 11:41:48AM +0100, James Clark wrote: > > > On 23/03/2022 16:22, Mathieu Poirier wrote: > > On Fri, Mar 04, 2022 at 05:18:57PM +0000, James Clark wrote: > >> Changes since v2: > >> * Implement Mike's suggestion of not having _SHIFT and using the existing > >> FIELD_GET and FIELD_PREP methods. > >> * Dropped the change to add the new REG_VAL macro because of the above. > >> * FIELD_PREP could be used in some trivial cases, but in some cases the > >> shift is still required but can be calculated with __bf_shf > >> * Improved the commit messages. > >> * The change is still binary equivalent, but requires an extra step > >> mentioned at the end of this cover letter. > >> > >> Applies to coresight/next 3619ee28488 > >> Also available at https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-cs-register-refactor-v3 > >> > >> To check for binary equivalence follow the same steps in the cover letter > >> of v2, but apply the following change to coresight-priv.h. This is because > >> the existing version of the macros wrap the expression in a new scope {} > >> that flips something in the compiler: > >> > >> #undef FIELD_GET > >> #define FIELD_GET(_mask, _reg) (((_reg) & (_mask)) >> __bf_shf(_mask)) > >> #undef FIELD_PREP > >> #define FIELD_PREP(_mask, _val) (((_val) << __bf_shf(_mask)) & (_mask)) > >> > >> Thanks > >> James > >> > >> James Clark (15): > >> coresight: etm4x: Cleanup TRCIDR0 register accesses > >> coresight: etm4x: Cleanup TRCIDR2 register accesses > >> coresight: etm4x: Cleanup TRCIDR3 register accesses > >> coresight: etm4x: Cleanup TRCIDR4 register accesses > >> coresight: etm4x: Cleanup TRCIDR5 register accesses > >> coresight: etm4x: Cleanup TRCCONFIGR register accesses > >> coresight: etm4x: Cleanup TRCEVENTCTL1R register accesses > >> coresight: etm4x: Cleanup TRCSTALLCTLR register accesses > >> coresight: etm4x: Cleanup TRCVICTLR register accesses > >> coresight: etm3x: Cleanup ETMTECR1 register accesses > >> coresight: etm4x: Cleanup TRCACATRn register accesses > >> coresight: etm4x: Cleanup TRCSSCCRn and TRCSSCSRn register accesses > >> coresight: etm4x: Cleanup TRCSSPCICRn register accesses > >> coresight: etm4x: Cleanup TRCBBCTLR register accesses > >> coresight: etm4x: Cleanup TRCRSCTLRn register accesses > >> > >> .../coresight/coresight-etm3x-core.c | 2 +- > >> .../coresight/coresight-etm3x-sysfs.c | 2 +- > >> .../coresight/coresight-etm4x-core.c | 136 +++++-------- > >> .../coresight/coresight-etm4x-sysfs.c | 180 +++++++++--------- > >> drivers/hwtracing/coresight/coresight-etm4x.h | 122 ++++++++++-- > >> 5 files changed, 244 insertions(+), 198 deletions(-) > > > > I am done reviewing this set. I will wait until rc1 or rc2 before moving > > forward. If there are other comments needing a respin then I will wait for the > > next revision. Otherwise I will apply this one after correcting the extra lines > > at the end of patch 15. > > > > Thanks for the review! > I have applied this set. > > Thanks, > > Mathieu > > > >> > >> -- > >> 2.28.0 > >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel