From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3A66C433EF for ; Wed, 13 Apr 2022 17:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5C/hP4g+zu/tlLO2VP1ZbdgiahqF3N6F9kAxCxqVsRE=; b=nmBuigdmu73FdH kO/aKfbTqJcfQR53aJt3F78DHbhrr6wCGthYqpkP/WNBMeoKK8Srli02nOxUDh0D4YQicuPDoioRa R0Wi0VWS6XJNE9M1UZAanS+Ue+CYgaCjU8HGYsfAeFVUo8Bdg6J+P3O45Z9CWMA/YT0btSxyHv4rh cX8+4emmP23o1W3YZscisUh99q2pv4+mm6BDcEgKsdVgvNacLkNtm4h6QeXlDPWJL2dY1Rn+rrTXI VyiY9KysJinaQynSrf+hep7B5UgMhAmlF1ychIyoM7PCT0vvFxRZl1Qb9WfViXvjlp6Yqufr0JoX5 qQE4tNRlERI3SP5pJq4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1negn3-001wBD-95; Wed, 13 Apr 2022 17:28:25 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1negmw-001wAg-OW for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 17:28:22 +0000 Received: by mail-pj1-x102e.google.com with SMTP id s14-20020a17090a880e00b001caaf6d3dd1so6895514pjn.3 for ; Wed, 13 Apr 2022 10:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oPjJy3dQKXL/NVMdEMFDpnuu4GwZdQiN6uOaWjrqUgM=; b=AA6I0XevM8oRDN4X6QpC2zn0EDmfUSOh0wPDMo7EAoisQ4gpanTJOM/J/IgotusHeG pIWQz/2UrFV3BIZ16i6WaD4U9iUIO3GIV8P5FgTikbYexkuD5SUM+cICxG6Zamg6DOL5 bvIkpd6EJMdpd9185XVU5KsKltnBvI5KMDnncM8p+g5yH/yv9Zigb7i48PvvBBgHOhaR 98LGwsGGwQtBAVJe/dUn/2+ur+wGraNR2a6+uk73CI/mGec59GMXAE+8TkdE4rUlNVcu 7DduURr4pL6qohv5csvfNJHmJWgKNPZMMahVAFHb7BHLZWT+pkui0Y8f2gSWUpGZRPfH Sqrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oPjJy3dQKXL/NVMdEMFDpnuu4GwZdQiN6uOaWjrqUgM=; b=YhBfsrZz2cVilyF0on146zKLhvnMA8KRq0QCjZFYUpMA2db5Klcdj5xXE2xE4slviF DZIr/xfs2K/mCo74D0voILwQ5WNSrAagczsMI53M4v3AUcxjKeo+uAnNWHB2Jm2T877j uP9MjkBZCpYOFeFq727Eki6FJrdYVZreROVCBKnA2JUjEREC4WO0QlwPpMIU/oveKyZK FtAWtz86ks40dNMWcBM6cM77y57rDsnJ9tMxvsl3McQBXc8mSAQW2ffyhncjyf/U2FG/ k/f9ImkVPkmr/wP0ypDQdu+61KFuDOd8anhcHjUNBrDGxOcYbHVUehZrzO/URjGUpRPn DD6A== X-Gm-Message-State: AOAM5326n7sS3iFrX+6H7osPVaFBnyfH9tjtV7FYLP9DtFkazXDkUmlI PJ6m8xVoCsK8bmYlPnwaivhJbQ== X-Google-Smtp-Source: ABdhPJxtpeKEZYfLhves0pNUvt6LwEjEbSP8Nc+TPS3DGkf0lcrtdLD7bZ9ZMYH3gqaSm0Zu/4H36g== X-Received: by 2002:a17:90a:eb0e:b0:1cb:7d07:52f6 with SMTP id j14-20020a17090aeb0e00b001cb7d0752f6mr11993279pjz.66.1649870897150; Wed, 13 Apr 2022 10:28:17 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 26-20020a630f5a000000b0039d83ab8655sm6778661pgp.0.2022.04.13.10.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 10:28:16 -0700 (PDT) Date: Wed, 13 Apr 2022 11:28:13 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shengjiu.wang@nxp.com, Peng Fan Subject: Re: [PATCH V2 0/2] remoteproc: elf: ignore PT_LOAD type segment with memsz as 0 Message-ID: <20220413172813.GB547134@p14s> References: <20220413033038.1715945-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220413033038.1715945-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_102818_813114_0F724CC0 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 11:30:36AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > V2: > Add R-b/A-b tag > Drop inaccurate comment in patch 1 > > i.MX DSP firmware has segments with PT_LOAD and memsz/filesz as zero. > It is valid case the memsz set to zero according to elf spec: > https://refspecs.linuxbase.org/elf/elf.pdf page 40 > > So we could let remoteproc elf loader handle this case, then no > duplicate code in imx dsp rproc driver > > Tested i.MX8MP DSP and M7 remoteproc > > Peng Fan (2): > remoteproc: elf_loader: skip segment with memsz as zero > remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments > > drivers/remoteproc/imx_dsp_rproc.c | 95 +--------------------- > drivers/remoteproc/remoteproc_elf_loader.c | 2 +- > 2 files changed, 2 insertions(+), 95 deletions(-) > I have applied this set but as I pointed out in the previous revision, it will have to be backed-out if something breaks. Hopefully it won't get to that. Thanks, Mathieu > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel