From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22107C433EF for ; Wed, 13 Apr 2022 18:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AtTjOl7IomXhL0FjIE4uXObpgNOQ5aTriCT4MkzXQ6I=; b=ZQ8sG5qtE5pDxR ApJi/d4NMZiojQ1+g08bdM3mFkwQI3vK8Mj0TKdx+M41UmlCUbwu/BDsnhfyQkYUdhZ6tq6QeKnzd /KDanbOE5HzzMgZ8ueQKfB9r+YTDpl/o6evNnwVSCXIkp69NJRyQutsYnw6FTmR24Oxqro+WKgFRu nGMMw6RQr5EnbrwdoLz7E/WssgphoU++6cPLNuvdSoUzN4nScuOixNJzgRqteIJ1lb9eXS8sZkH/D 8Gto9aMTSwXhGWULO72jRtWjp7shtX2xyFZYS5iEE7iIyastdISp5s/zaTEULyaOxjRYDqMxwSowE DAXGuV6mUjy1j575wiWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nehdA-00241b-9L; Wed, 13 Apr 2022 18:22:16 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nehd6-00240F-Bd for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 18:22:13 +0000 Received: by mail-ej1-x635.google.com with SMTP id l7so5702484ejn.2 for ; Wed, 13 Apr 2022 11:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M8MM9hNtlsb/0mGDP5Eh6d8xwozIxiEbRd1Lk53Q2x8=; b=AfZ4ojV7fGDgQo6baXqWP9xdlkYefBtN6ONQTTRuj8YW5P2oU0QyTcPPmn+Qxq0ZaR TeTnw1PMzTpBgAImuYmnFPpMiKL27rUSGi4C1ILlwrq1DJDDhrhwTB8XUkvAPNIV/4rr 3NBCZpZ0baJ4dl5uLGHLzbuEVqwo6i07CLCYI0KDsrJNbTdBTB2DOpbJZ2aaLAF4Jcul mHKHI/wwctHmTYeN7OB0gqAFtNik2gp7zxAHtdodVor1kh1t8Je3eTVwBL+w1DYL5Eii xdb5BObNy4KVYMXF+HCCjEBgLiDEkuUxazh0123t0A+Uf1tTJHP2Ya2HzwhGZJ8ddjEV llcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M8MM9hNtlsb/0mGDP5Eh6d8xwozIxiEbRd1Lk53Q2x8=; b=JIVGmxR8I646ZqNRI2iw8dMQes41CSqewVGLLFiR5BdYl4aMMCe38SLOkgyDoQPqlR Huec0U8h+UVR7OSd4hW3kUve3YVDnvcu3d+O7UVYnwp1hu2dlHUnzkBPLSqx8Uef7RBY fShiI+CFzcWXQq4DlnD7F2vR+vECyoTxIrM71tQUyBofgpmpKMEnf6RxyLx5IYhf12cD 5QVlcqbVcC/WHx98tb2O4Ic1oPoFk9wPfMSQ7sOLXBfD05XHUBszGBXajwCd06hfaF4N FEttXO4UcEO+Mhf0sNjoWaMVux5pjksNnQzi/dqoNzpEZrB2f7V29NuBIK/g126PsPfD /ICg== X-Gm-Message-State: AOAM531hq0AH1NziqYG6S6SWQBVjNiZDe9KVWqTobSQUNR1lC3/+qWAK eP5XyKy2Scqttur61PzX9Xc= X-Google-Smtp-Source: ABdhPJwcJwJXD3ZxALW/ZXITseVCZhS4IB+VdRINSiXel6dSLaZhXSnfpbAaUOm0d7snfmaUQfhUQg== X-Received: by 2002:a17:907:7ea1:b0:6e8:9325:c9ce with SMTP id qb33-20020a1709077ea100b006e89325c9cemr14756806ejc.368.1649874129175; Wed, 13 Apr 2022 11:22:09 -0700 (PDT) Received: from skbuf ([188.26.57.45]) by smtp.gmail.com with ESMTPSA id k14-20020a170906128e00b006e4b67514a1sm222798ejb.179.2022.04.13.11.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 11:22:08 -0700 (PDT) Date: Wed, 13 Apr 2022 21:22:07 +0300 From: Vladimir Oltean To: Leo Li Cc: "Z.Q. Hou" , Shawn Guo , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Xiaowei Bao Subject: Re: [PATCH v3 1/8] arm64: dts: ls1028a: Add PCIe EP nodes Message-ID: <20220413182207.chvdbqnmmm5vbz2b@skbuf> References: <20211214093240.23320-1-leoyang.li@nxp.com> <20211214093240.23320-2-leoyang.li@nxp.com> <20220413163209.4pqqpyqdklhlzp5p@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_112212_458029_CC9028EA X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 06:03:37PM +0000, Leo Li wrote: > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:631.23-656.5: Warning > > (unique_unit_address): /soc/pcie@3400000: duplicate unit-address (also > > used in node /soc/pcie-ep@3400000) > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:670.23-695.5: Warning > > (unique_unit_address): /soc/pcie@3500000: duplicate unit-address (also > > used in node /soc/pcie-ep@3500000) > > This would be a common problem for all the layerscape PCIe controller. > The controller can either work in RC mode or EP mode. The current > binding of the controller defined two compatibles, one for RC and one > for EP. Therefore the SoC dtsi will have two nodes with the same unit > address one for EP one for RC. Fixing this probably requires > comprehensive updates to the binding which breaks backward > compatibility. So we have to live with these warnings forever now? How are the PCIe controllers configured for RC or EP mode? Via RCW? Is dynamic configuration possible? Can't U-Boot detect the operating mode from the RCW and fix up the compatible string in case the controller is in endpoint mode? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel