Re: [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes

Vladimir Oltean
2022-04-13T16:34:25Z

On Tue, Dec 14, 2021 at 03:32:35AM -0600, Li Yang wrote:
> From: Biwen Li <biwen.li@nxp.com>
>
> Add pwm nodes using flextimer controller.
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 95 +++++++++++++++++++
> 1 file changed, 95 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index f2564faf7067..5a7b26a1bad2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -66,6 +66,13 @@ CPU_PW20: cpu-pw20 {
> };
> };
>
> + rtc_clk: rtc-clk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + clock-output-names = "rtc_clk";
> + };
> +
> sysclk: sysclk {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -1186,6 +1193,94 @@ ierb@1f0800000 {
> reg = <0x01 0xf0800000 0x0 0x10000>;
> };
>
> + pwm0: pwm@2800000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2800000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm1: pwm@2810000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2810000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm2: pwm@2820000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2820000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm3: pwm@2830000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2830000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm4: pwm@2840000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2840000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm5: pwm@2850000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2850000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm6: pwm@2860000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2860000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> + pwm7: pwm@2870000 {
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x2870000 0x0 0x10000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&rtc_clk>, <&clockgen 4 1>;
> + status = "disabled";
> + };
> +
> rcpm: power-controller@1e34040 {
> compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-2.1+";
> reg = <0x0 0x1e34040 0x0 0x1c>;
> --
> 2.25.1
>

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1210.21-1219.5: Warning (unique_unit_address): /soc/pwm@2800000: duplicate unit-address (also used in node /soc/timer@2800000)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1221.21-1230.5: Warning (unique_unit_address): /soc/pwm@2810000: duplicate unit-address (also used in node /soc/timer@2810000)