From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C3F1C433EF for ; Thu, 14 Apr 2022 16:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ix9zzUa2kJRvT8+zPCnIzV9fmh5/U/Nglz2pQucRXdY=; b=jfaQDgIhdNXPqU TPWbIaMj28ijsHbMuWeHPhqHjak4q3jMwKRO8FK1OZqRxjeWoW27PLBBYq4247wPZXLUqpkboJXUl QB6XyqXYEoYb6BYSP+rl5BekOidgTrF7kz4wD5bHsErFe5/k2hiTaCdHfK3GKmJJr9t0r/6gMbArQ OMLBqg3tFjD4r0UwodCiQEKw6UbYBn5UZappDLy8uL7m0CmrU0uuRBepsKoQwqf2M/FMWDG81Q5MF o3yKoezLWLc08Qd5+5X6DFEmqAZOJayCq1zrrW+Yq5StRdfm9LG7LWAVhBdkQraUCvkA98WD339M9 d6yi4qo2YpMhzmCbZtDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf236-006M9J-HH; Thu, 14 Apr 2022 16:10:24 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf22s-006M5t-1y for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 16:10:14 +0000 Received: by mail-pg1-x529.google.com with SMTP id r66so5157857pgr.3 for ; Thu, 14 Apr 2022 09:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=++TmBWO1YM92e9/sGWADvMXzGuWQuA2AD0SMUsAqv+Q=; b=JoUoj8n/GW9gkKQC1j6p3chTuhXkvPltZdV1WwSw3ET/WW2qintUx7JYtkS0C+Dn/n ns41TCv2Olei9/sxo0eUZ6hHo9JfC+Trb6vcLuwZh6A7JSmFouitlK62Cb5YStHALyFh 1VNfCeG6hcoCkRApyt101mCwSPXCqKHG3qS8sqybkuQ12StcZEU88yEQ7V1/f6dG8muy juNzghTVH02wdgsShkpXvpNZkhU1aGjLJglQ5xXIixshsCHv3ihuCBu1AHfggTZGnHua keDc8HOIKevZPwnSlFBnU4Jae0ocHwcMypk++/5KUNdSzXOJyS01Mrmj/w92B5fDvTSH ZWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=++TmBWO1YM92e9/sGWADvMXzGuWQuA2AD0SMUsAqv+Q=; b=7aZgOhopGPmkKHzxeXVsA7FUHUInJqBnAEWZUE+tISVoN/lkK+VxvLcCTAT06S8YCp Lb2DuP93QPt1AtbozwvlwirWFxf2KMW6Vps5BAY86wKzEB080bmUh6SrXce23kIP4720 btVJTroPeiPIB6/URCm99iCxDYtUxs3Nipjr/4XLJKOyHw/Prs31KysyPxSxFzk4yASg N2PAgqZc+bmd7A1SSvWlNsvycilFOsRlK5j4aZUSjz/P7gEdmFHy1+zWvzlWEtniEtAM scTkDjM4aWNWL/zkbaZvFCg9mXv/PEHzPkSHn5p04R50j3eFqTqqs/20LAXEXrp/noKC V84g== X-Gm-Message-State: AOAM532Em+A0NoVCC7tiglM4Q1aOjo5LeAjwfOG3f4z0pORHEiNtZs9D hJ/Z/DvwE1nqZYZE8Fzk9c/G7A== X-Google-Smtp-Source: ABdhPJwvTXSLjFWKJT2b2kUclniIMf+jXP1VUhMPADLUMQgcA+BzmtbVUrDr4ZpIjDVNMHi3GupQLQ== X-Received: by 2002:a63:310f:0:b0:39d:90e3:6a44 with SMTP id x15-20020a63310f000000b0039d90e36a44mr2847254pgx.281.1649952608633; Thu, 14 Apr 2022 09:10:08 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id m21-20020a17090a7f9500b001c97c6bcaf4sm6336845pjl.39.2022.04.14.09.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 09:10:06 -0700 (PDT) Date: Thu, 14 Apr 2022 10:10:03 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH V3] remoteproc: imx_rproc: Ignore create mem entry for resource table Message-ID: <20220414161003.GA698343@p14s> References: <20220331084007.2323377-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220331084007.2323377-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_091010_137541_9503372F X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 04:40:07PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Resource table is used by Linux to get information pubished by s/pubished/published > remote processor. It should be not be used for memory allocation, so > not create rproc mem entry. > > Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook") > Signed-off-by: Peng Fan > --- > > V3: > Update commit log > Update Fixes tag > > V2: > Add Fixes tag > Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/ > Address typo > > drivers/remoteproc/imx_rproc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 7a096f1891e6..f2bfc9077c19 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc) > if (!strcmp(it.node->name, "vdev0buffer")) > continue; > > + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table"))) > + continue; > + Any reason the handling of vdev0buffer is using strcmp() and the resource table strncmp()? Thanks, Mathieu > rmem = of_reserved_mem_lookup(it.node); > if (!rmem) { > dev_err(priv->dev, "unable to acquire memory-region\n"); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel