[PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups

linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups
@ 2022-04-14 18:16 Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 1/5] staging: bcm2835-audio: fully describe config symbol Adrien Thierry
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Adrien Thierry @ 2022-04-14 18:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolas Saenz Julienne, Florian Fainelli,
	Ray Jui, Scott Branden, bcm-kernel-feedback-list, Maxime Ripard,
	Takashi Iwai
  Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Adrien Thierry

This series contains minor code style cleanups to fix checkpatch warnings.

This handles TODO item "Fix the remaining checkpatch.pl errors and
warnings"

---

Changes since v1:
- removed mention of vc4 in Kconfig help text
- split patches so that each patch fixes only one checkpatch warning

Adrien Thierry (5):
  staging: bcm2835-audio: fully describe config symbol
  staging: bcm2835-audio: fix line ending with '('
  staging: bcm2835-audio: fix unnecessary space after cast
  staging: bcm2835-audio: fix mutex definition without comment
  staging: bcm2835-audio: fix mutex definition without comment

 drivers/staging/vc04_services/bcm2835-audio/Kconfig         | 6 ++++--
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c   | 5 ++---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
 drivers/staging/vc04_services/bcm2835-audio/bcm2835.h       | 2 +-
 4 files changed, 8 insertions(+), 7 deletions(-)


base-commit: 194193dd06848c1839d928090cb2032eec8b2f9c
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/5] staging: bcm2835-audio: fully describe config symbol
  2022-04-14 18:16 [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups Adrien Thierry
@ 2022-04-14 18:16 ` Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 2/5] staging: bcm2835-audio: fix line ending with '(' Adrien Thierry
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Adrien Thierry @ 2022-04-14 18:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolas Saenz Julienne, Florian Fainelli,
	Ray Jui, Scott Branden, bcm-kernel-feedback-list, Maxime Ripard,
	Takashi Iwai
  Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Adrien Thierry

Explain SND_BCM2835 config option in more detail to fix checkpatch
warning:

WARNING: please write a help paragraph that fully describes the config
symbol
FILE: drivers/staging/vc04_services/bcm2835-audio/Kconfig:2

Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
 drivers/staging/vc04_services/bcm2835-audio/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
index d32ea348e846..307f2d6a9599 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/Kconfig
+++ b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
@@ -5,5 +5,7 @@ config SND_BCM2835
 	select SND_PCM
 	select BCM2835_VCHIQ
 	help
-	  Say Y or M if you want to support BCM2835 built in audio
-
+	  Say Y or M if you want to support BCM2835 built in audio.
+	  This driver handles both 3.5mm and HDMI audio, by leveraging
+	  the VCHIQ messaging interface between the kernel and the firmware
+	  running on VideoCore.
\ No newline at end of file
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/5] staging: bcm2835-audio: fix line ending with '('
  2022-04-14 18:16 [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 1/5] staging: bcm2835-audio: fully describe config symbol Adrien Thierry
@ 2022-04-14 18:16 ` Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 3/5] staging: bcm2835-audio: fix unnecessary space after cast Adrien Thierry
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Adrien Thierry @ 2022-04-14 18:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolas Saenz Julienne, Florian Fainelli,
	Ray Jui, Scott Branden, bcm-kernel-feedback-list, Maxime Ripard,
	Takashi Iwai
  Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Adrien Thierry

Fix issue reported by checkpatch:

CHECK: Lines should not end with a '('
FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:85:

Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
index f2ef1d641e70..856d3c022f80 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
@@ -82,8 +82,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream,
 }
 
 /* open callback */
-static int snd_bcm2835_playback_open_generic(
-	struct snd_pcm_substream *substream, int spdif)
+static int snd_bcm2835_playback_open_generic(struct snd_pcm_substream *substream, int spdif)
 {
 	struct bcm2835_chip *chip = snd_pcm_substream_chip(substream);
 	struct snd_pcm_runtime *runtime = substream->runtime;
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/5] staging: bcm2835-audio: fix unnecessary space after cast
  2022-04-14 18:16 [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 1/5] staging: bcm2835-audio: fully describe config symbol Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 2/5] staging: bcm2835-audio: fix line ending with '(' Adrien Thierry
@ 2022-04-14 18:16 ` Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 4/5] staging: bcm2835-audio: fix mutex definition without comment Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 5/5] " Adrien Thierry
  4 siblings, 0 replies; 6+ messages in thread
From: Adrien Thierry @ 2022-04-14 18:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolas Saenz Julienne, Florian Fainelli,
	Ray Jui, Scott Branden, bcm-kernel-feedback-list, Maxime Ripard,
	Takashi Iwai
  Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Adrien Thierry

Fix issue reported by checkpatch:

CHECK: No space is necessary after a cast
FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:240:

Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
index 856d3c022f80..68e8d491a7ec 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
@@ -236,7 +236,7 @@ static void snd_bcm2835_pcm_transfer(struct snd_pcm_substream *substream,
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct bcm2835_alsa_stream *alsa_stream = runtime->private_data;
-	void *src = (void *) (substream->runtime->dma_area + rec->sw_data);
+	void *src = (void *)(substream->runtime->dma_area + rec->sw_data);
 
 	bcm2835_audio_write(alsa_stream, bytes, src);
 }
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 4/5] staging: bcm2835-audio: fix mutex definition without comment
  2022-04-14 18:16 [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups Adrien Thierry
                   ` (2 preceding siblings ...)
  2022-04-14 18:16 ` [PATCH v2 3/5] staging: bcm2835-audio: fix unnecessary space after cast Adrien Thierry
@ 2022-04-14 18:16 ` Adrien Thierry
  2022-04-14 18:16 ` [PATCH v2 5/5] " Adrien Thierry
  4 siblings, 0 replies; 6+ messages in thread
From: Adrien Thierry @ 2022-04-14 18:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolas Saenz Julienne, Florian Fainelli,
	Ray Jui, Scott Branden, bcm-kernel-feedback-list, Maxime Ripard,
	Takashi Iwai
  Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Adrien Thierry

Fix issue reported by checkpatch:

CHECK: struct mutex definition without comment
FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c:14:

Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
index d567a2e3f70c..e429b33b4d39 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
@@ -11,7 +11,7 @@ struct bcm2835_audio_instance {
 	struct device *dev;
 	unsigned int service_handle;
 	struct completion msg_avail_comp;
-	struct mutex vchi_mutex;
+	struct mutex vchi_mutex; /* Serialize vchiq access */
 	struct bcm2835_alsa_stream *alsa_stream;
 	int result;
 	unsigned int max_packet;
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 5/5] staging: bcm2835-audio: fix mutex definition without comment
  2022-04-14 18:16 [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups Adrien Thierry
                   ` (3 preceding siblings ...)
  2022-04-14 18:16 ` [PATCH v2 4/5] staging: bcm2835-audio: fix mutex definition without comment Adrien Thierry
@ 2022-04-14 18:16 ` Adrien Thierry
  4 siblings, 0 replies; 6+ messages in thread
From: Adrien Thierry @ 2022-04-14 18:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolas Saenz Julienne, Florian Fainelli,
	Ray Jui, Scott Branden, bcm-kernel-feedback-list, Maxime Ripard,
	Takashi Iwai
  Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Adrien Thierry

Fix issue reported by checkpatch:

CHECK: struct mutex definition without comment
FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835.h:64:

Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
index 51066ac8eea5..38b7451d77b2 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
@@ -61,7 +61,7 @@ struct bcm2835_chip {
 
 	unsigned int opened;
 	unsigned int spdif_status;
-	struct mutex audio_mutex;
+	struct mutex audio_mutex; /* Serialize chip data access */
 
 	struct bcm2835_vchi_ctx *vchi_ctx;
 };
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-04-14 18:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-14 18:16 [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups Adrien Thierry
2022-04-14 18:16 ` [PATCH v2 1/5] staging: bcm2835-audio: fully describe config symbol Adrien Thierry
2022-04-14 18:16 ` [PATCH v2 2/5] staging: bcm2835-audio: fix line ending with '(' Adrien Thierry
2022-04-14 18:16 ` [PATCH v2 3/5] staging: bcm2835-audio: fix unnecessary space after cast Adrien Thierry
2022-04-14 18:16 ` [PATCH v2 4/5] staging: bcm2835-audio: fix mutex definition without comment Adrien Thierry
2022-04-14 18:16 ` [PATCH v2 5/5] " Adrien Thierry

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).