From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: <rafael@kernel.org>, <viresh.kumar@linaro.org>,
<robh+dt@kernel.org>, <krzk+dt@kernel.org>,
<matthias.bgg@gmail.com>
Cc: <jia-wei.chang@mediatek.com>, <roger.lu@mediatek.com>,
<hsinyi@google.com>, <khilman@baylibre.com>,
<angelogioacchino.delregno@collabora.com>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"Andrew-sh . Cheng" <andrew-sh.cheng@mediatek.com>,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH V3 04/15] cpufreq: mediatek: Record previous target vproc value
Date: Fri, 15 Apr 2022 13:59:05 +0800 [thread overview]
Message-ID: <20220415055916.28350-5-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220415055916.28350-1-rex-bc.chen@mediatek.com>
From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
We found the buck voltage may not be exactly the same with what we set
because CPU may share the same buck with other module.
Therefore, we need to record the previous desired value instead of reading
it from regulators.
Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
---
drivers/cpufreq/mediatek-cpufreq.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index ff27f77e8ee6..fa8b193bf27b 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -40,6 +40,7 @@ struct mtk_cpu_dvfs_info {
struct list_head list_head;
int intermediate_voltage;
bool need_voltage_tracking;
+ int pre_vproc;
};
static LIST_HEAD(dvfs_info_list);
@@ -191,11 +192,17 @@ static int mtk_cpufreq_voltage_tracking(struct mtk_cpu_dvfs_info *info,
static int mtk_cpufreq_set_voltage(struct mtk_cpu_dvfs_info *info, int vproc)
{
+ int ret;
+
if (info->need_voltage_tracking)
- return mtk_cpufreq_voltage_tracking(info, vproc);
+ ret = mtk_cpufreq_voltage_tracking(info, vproc);
else
- return regulator_set_voltage(info->proc_reg, vproc,
- vproc + VOLT_TOL);
+ ret = regulator_set_voltage(info->proc_reg, vproc,
+ MAX_VOLT_LIMIT);
+ if (!ret)
+ info->pre_vproc = vproc;
+
+ return ret;
}
static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
@@ -213,7 +220,9 @@ static int mtk_cpufreq_set_target(struct cpufreq_policy *policy,
inter_vproc = info->intermediate_voltage;
pre_freq_hz = clk_get_rate(cpu_clk);
- pre_vproc = regulator_get_voltage(info->proc_reg);
+ pre_vproc = info->pre_vproc;
+ if (pre_vproc <= 0)
+ pre_vproc = regulator_get_voltage(info->proc_reg);
if (pre_vproc < 0) {
dev_err(cpu_dev, "invalid Vproc value: %d\n", pre_vproc);
return pre_vproc;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-15 6:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 5:59 [PATCH V3 00/15] cpufreq: mediatek: Cleanup and support MT8183 and MT8186 Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 01/15] dt-bindings: cpufreq: mediatek: Add MediaTek CCI property Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 02/15] cpufreq: mediatek: Use device print to show logs Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-15 5:59 ` [PATCH V3 03/15] cpufreq: mediatek: Replace old_* with pre_* Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-15 5:59 ` Rex-BC Chen [this message]
2022-04-15 12:24 ` [PATCH V3 04/15] cpufreq: mediatek: Record previous target vproc value AngeloGioacchino Del Regno
2022-04-18 1:37 ` Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 05/15] cpufreq: mediatek: Add opp notification support Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-18 1:38 ` Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 06/15] cpufreq: mediatek: Move voltage limits to platform data Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-15 5:59 ` [PATCH V3 07/15] cpufreq: mediatek: Add .get function Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 08/15] cpufreq: mediatek: Make sram regulator optional Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 09/15] cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking() Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 10/15] cpufreq: mediatek: Add counter to prevent infinite loop when tracking voltage Rex-BC Chen
2022-04-15 6:14 ` Hsin-Yi Wang
2022-04-15 6:29 ` Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-18 1:40 ` Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 11/15] cpufreq: mediatek: Link CCI device to CPU Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-18 1:45 ` Rex-BC Chen
2022-04-20 18:09 ` Kevin Hilman
2022-04-15 5:59 ` [PATCH V3 12/15] cpufreq: mediatek: Add support for MT8186 Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 13/15] arm64: dts: mediatek: Add opp table and clock property for MT8183 cpufreq Rex-BC Chen
2022-04-15 12:24 ` AngeloGioacchino Del Regno
2022-04-18 1:46 ` Rex-BC Chen
2022-04-15 5:59 ` [PATCH V3 14/15] arm64: dts: mediatek: Add MediaTek CCI node for MT8183 Rex-BC Chen
2022-04-15 6:06 ` Hsin-Yi Wang
2022-04-15 6:10 ` Hsin-Yi Wang
2022-04-15 12:23 ` AngeloGioacchino Del Regno
2022-04-15 5:59 ` [PATCH V3 15/15] arm64: dts: mediatek: Add mediatek, cci property for MT8183 cpufreq Rex-BC Chen
2022-04-15 12:23 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415055916.28350-5-rex-bc.chen@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andrew-sh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).