From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A52FC433EF for ; Sat, 16 Apr 2022 16:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fw2vFcrlBBmv8Ku7Bedmpb5IzmiZc+wN468pZqEQTzI=; b=RlDGv6TBAUfxn0 aKuWddYQu5aL0wpbF5IXoQJ3Ix1Z7cvJslzbjE+B7zsz54jPF76U0Q7ctL68GJpRc7w41F6vuzJP1 sLw4LiVsaOya7JMDh1DqyHHTqeFr7KMxyZdXl6OLey9ZVV9hToVWZqU6v69GcBHug10P1mPAQxmUJ DUOqDj4RvdJsZRGjz0p3QRBE/HlW6rLc6l5APxpSfONrL8gduyn0/wNJItTfh4c7KXtoJIicgnN2g +4HR+DAtHjy/aGBIESGK0djV6Lb4innZA2Shw3NqMqenJCOHt7b1P+oUUXsdd5IUxsZoAk/RuquLy VJ0GKY0JdbpsyY1kB52w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nflKD-00DEji-Kf; Sat, 16 Apr 2022 16:31:05 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nflKA-00DEjD-DJ for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 16:31:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650126662; x=1681662662; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZYQl1xcsGRkBXqpNo+f5+Kf+37WBSRVnXdfWEXD1MKI=; b=TFlCz+u9XXE3oil3w6qNhHPMMfs6TmrSbmVphgegjt3y6MFJfGUV/oMf EI/krKww0J2pVXjNRKy43krorPYbuNjHj4d6dQLIxXELB8d4t69ukmLzf Z1RPXcdaIMTOnWz9b5jMmjhE2Za5HkSrYkHYN3WtIbRpgfCCxZ+p61+Qv hmtrAruuB8QTCcBlbrb8tJ608zwxoEadHSntWz4jmH3R7usLtRZVE1eRb yzFXZgP0kWsSdK5Tjqv/UwSt3QUALHMiXL1j8EQdQYYlnphhLC+U6Ptn4 8INSMxGUmGszDhtGIpZQy4nr4LNQrNcv4UPQ3d4y684w4UcyDPdnTFgeo w==; X-IronPort-AV: E=McAfee;i="6400,9594,10318"; a="245191270" X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="245191270" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2022 09:30:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="574873330" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.135]) by orsmga008.jf.intel.com with ESMTP; 16 Apr 2022 09:30:56 -0700 Date: Sun, 17 Apr 2022 00:23:24 +0800 From: Xu Yilun To: Nava kishore Manne Cc: mdf@kernel.org, hao.wu@intel.com, trix@redhat.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH v4 1/5] fpga: zynq: Fix incorrect variable type Message-ID: <20220416162324.GD301222@yilunxu-OptiPlex-7050> References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-2-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220416133719.3382895-2-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220416_093102_529692_9AAE91FD X-CRM114-Status: GOOD ( 21.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 16, 2022 at 07:07:15PM +0530, Nava kishore Manne wrote: > zynq_fpga_has_sync () API is expecting "u8 *" but the > formal parameter that was passed is of type "const char *". > fixes this issue by changing the buf type to "const char *" > > This patch will also update zynq_fpga_has_sync () API description > to align with API functionality. > > Signed-off-by: Nava kishore Manne > --- > Changes for v2: > -None. > Changes for v3: > - Changed arg buf type to "const char *" as suggested by Tom. > - update zynq_fpga_has_sync () API description to align with API > functionality. > Changes for v4: > - None. There are some minor comments in v3, please check it. Thanks, Yilun > > drivers/fpga/zynq-fpga.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index 426aa34c6a0d..ada07eea64bc 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -235,11 +235,11 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) > return IRQ_HANDLED; > } > > -/* Sanity check the proposed bitstream. It must start with the sync word in > - * the correct byte order, and be dword aligned. The input is a Xilinx .bin > - * file with every 32 bit quantity swapped. > +/* Sanity check the proposed bitstream. The sync word must be found in the > + * correct byte order and it should be dword aligned. The input is a > + * Xilinx.bin file with every 32 bit quantity swapped. > */ > -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) > +static bool zynq_fpga_has_sync(const char *buf, size_t count) > { > for (; count >= 4; buf += 4, count -= 4) > if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel