From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2AB0C433EF for ; Sat, 16 Apr 2022 17:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9KVfb3IepGPkQqvGHimSngP/nHHp96CluBq7k63Q9s=; b=tv5VZywah+Y93E 5mraLDwSB+FYtNY4W30bJJUsa5v4Y4haf3NpNpl+tq4gvgdTPRjaJwk4US7WhGPrPCcoKSu/+SfIE VzmREGPDMDXDUAHVC66XuV6tO7AQ3QauAENl8+B06UhAXBdSc2H7LhhO9DNHaWDRG3F3d2LylUeH0 F73KoY9PvIAWxN/GtWqPjo0CQwBadau048/O0UQbAEVBCOQHWozL+9XwKNMAKiyT/zmor19+FkT07 DYQW/4eMjDyQC6sixrrgmlHfDDGhHm8Ji2JrhedMR/OXqGg/Bgv2z8GN/WlwymmGj28F1YA7d4Q0f /HwVxPkYjRTwPLWglsDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfln4-00DHMU-2u; Sat, 16 Apr 2022 17:00:54 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfln0-00DHIu-KX for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 17:00:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650128450; x=1681664450; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=c41hGLHaAehdnBiHkOfPD2fC/yD5IiZ95Pu4yRuFNdQ=; b=Ej2dT8uwhm92pd/6x8liDkzsdYaDPKxHli0sTeH2HZxNIwzyefSegw6b jMRSj+doIU7JJPa+4vdJ9QCc/VT+9hSn5mVQ71rxoI+cD47S7Ip/CI4a+ ZN9cTE5PsYe8j8Wj6ogMHM+bIcIa3KJ4+wR/yfIdjGwGnHeYs3zV2CtRy Mxy3Nrx3C2ZqxMNLeZuIHCHftadyN5+Ui9ijZno6pk4SJB11sgsn2tRKa A59UL/EyeLDubFshoiDylXl2S6JtgpUL7NGO4HyWz7uNX9cJ61Nbb7gYQ XcpGi9Rk1T1mFIv9jBzZ8tVFqlJJaR5asDRrHVFAIneMfhEOgI6P0xeM/ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10318"; a="349757202" X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="349757202" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2022 10:00:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="701369843" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.135]) by fmsmga001.fm.intel.com with ESMTP; 16 Apr 2022 10:00:33 -0700 Date: Sun, 17 Apr 2022 00:53:01 +0800 From: Xu Yilun To: Nava kishore Manne Cc: mdf@kernel.org, hao.wu@intel.com, trix@redhat.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH v4 3/5] fpga: fpga-mgr: fix kernel-doc warnings Message-ID: <20220416165301.GG301222@yilunxu-OptiPlex-7050> References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-4-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220416133719.3382895-4-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220416_100050_717318_75AFF5F5 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 16, 2022 at 07:07:17PM +0530, Nava kishore Manne wrote: > warnings: No description found for return value of 'xxx' > > In-order to fix the above kernel-doc warnings added the > 'Return' description for 'devm_fpga_mgr_register_full()' > and 'devm_fpga_mgr_register()' API's. APIs. > > Signed-off-by: Nava kishore Manne With the minor fix, please add my Acked-by. Acked-by: Xu Yilun > --- > Changes for v2: > -Replaced s/@return:/Return:/ > Changes for v3: > -Updated commit description. > Changes for v4: > -Updated commit description. > > drivers/fpga/fpga-mgr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c > index a699cc8e2fa6..0f2b28538f17 100644 > --- a/drivers/fpga/fpga-mgr.c > +++ b/drivers/fpga/fpga-mgr.c > @@ -730,6 +730,8 @@ static void devm_fpga_mgr_unregister(struct device *dev, void *res) > * @parent: fpga manager device from pdev > * @info: parameters for fpga manager > * > + * Return: fpga manager pointer on success, negative error code otherwise. > + * > * This is the devres variant of fpga_mgr_register_full() for which the unregister > * function will be called automatically when the managing device is detached. > */ > @@ -763,6 +765,8 @@ EXPORT_SYMBOL_GPL(devm_fpga_mgr_register_full); > * @mops: pointer to structure of fpga manager ops > * @priv: fpga manager private data > * > + * Return: fpga manager pointer on success, negative error code otherwise. > + * > * This is the devres variant of fpga_mgr_register() for which the > * unregister function will be called automatically when the managing > * device is detached. > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel