From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 666B8C433F5 for ; Sat, 16 Apr 2022 17:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zq+Q8U5AfDzgtw6Qb4f12NLkv5H67IDwBh6aCrRoRnE=; b=clXDvRetCT8Ypg 1yqlLwKoAvIsd8JZQJfVYaOCTln9fB+nYBC1ajMbfTHOhM98qdxorTzp3uj2PTvwZwEVYYGmdViRF XVU+SE2roGX2yzrdJeEFvV2ahrzQ8WLHY+AkoUx2HwMyu+vlEZ7c14l8nUIGysHsjZ0tGs1iAeTSp 3Or2LetGdhgYCAoASFMJnb3pmfLexXrroDNzVe4o2cBWDLbE0MeYJjFseTw1IQLRHCaW98ERUA5Y/ z+cwEmO1O0I/3n2NJrHdCrF/aYAK23lZ9CrvoThmZO61a7TAjFyJrU94s00NLQCX9tA8VTsB7ibJf ge9qANLcGGlYTrV5q9kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nflwS-00DI2B-BU; Sat, 16 Apr 2022 17:10:36 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nflwO-00DI1m-Q7 for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 17:10:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650129032; x=1681665032; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=unCoICu+tR6XjB3V0LBDQueMtp5vDCI6pFAj0TG4Zsc=; b=acl3Adnmny5qMjhev8LqoS9pt3lhvYHqgAGBvekRwwMd9gj2jpgqBbzc BSljNNeRf3HdMyXNwWmwn+AIlMAqJ84UZlg6WX79Zd9nYRHHGTQ5KUtff dYj0quoccX42mGt0fFF7oDjWv89bPmFtJ+cLN6OWWXPpT/OtR6oVZOf1q hysUMwD3k2fMUbWhJagT53n/a4Lb1yM5pP348iJsL7chSTU9PFyIGXyye usuIWwQYPmdFWHB63AUxez+8T28AIV6zbJEbG/c8pY1Fo0zuQsgR4I63y EqnqyuXfF5sWEyLbOMHGfs5j/67XwfwS6qPczVBcI1X72X8KN7U7tVjx7 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10318"; a="260907177" X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="260907177" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2022 10:10:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,264,1643702400"; d="scan'208";a="553608605" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.135]) by orsmga007.jf.intel.com with ESMTP; 16 Apr 2022 10:10:28 -0700 Date: Sun, 17 Apr 2022 01:02:57 +0800 From: Xu Yilun To: Nava kishore Manne Cc: mdf@kernel.org, hao.wu@intel.com, trix@redhat.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues Message-ID: <20220416170257.GA302575@yilunxu-OptiPlex-7050> References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-3-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220416133719.3382895-3-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220416_101032_961174_67FBFCD3 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 16, 2022 at 07:07:16PM +0530, Nava kishore Manne wrote: > fixes the below checks reported by checkpatch.pl > Lines should not end with a '(' > Alignment should match open parenthesis Please help format the commit log, like: fixes the below checks reported by checkpatch.pl: - Lines should not end with a '(' - Alignment should match open parenthesis > > Signed-off-by: Nava kishore Manne With the minor fixes, please add my Acked-by. Acked-by: Xu Yilun > --- > Changes for v2: > -None. > Changes for v3: > -Fixed similar issue exists in "drivers/fpga/*". > Changes for v4: > -None. > > drivers/fpga/fpga-mgr.c | 4 ++-- > drivers/fpga/fpga-region.c | 7 ++++--- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c > index d49a9ce34568..a699cc8e2fa6 100644 > --- a/drivers/fpga/fpga-mgr.c > +++ b/drivers/fpga/fpga-mgr.c > @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, > if (!mgr->mops->initial_header_size) > ret = fpga_mgr_write_init(mgr, info, NULL, 0); > else > - ret = fpga_mgr_write_init( > - mgr, info, buf, min(mgr->mops->initial_header_size, count)); > + ret = fpga_mgr_write_init(mgr, info, buf, > + min(mgr->mops->initial_header_size, count)); > > if (ret) { > dev_err(&mgr->dev, "Error preparing FPGA for writing\n"); > diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c > index b0ac18de4885..3864bf4f8920 100644 > --- a/drivers/fpga/fpga-region.c > +++ b/drivers/fpga/fpga-region.c > @@ -18,9 +18,10 @@ > static DEFINE_IDA(fpga_region_ida); > static struct class *fpga_region_class; > > -struct fpga_region *fpga_region_class_find( > - struct device *start, const void *data, > - int (*match)(struct device *, const void *)) > +struct fpga_region *fpga_region_class_find(struct device *start, > + const void *data, > + int (*match)(struct device *, > + const void *)) > { > struct device *dev; > > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel