public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@denx.de>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Peng Fan <peng.fan@nxp.com>, NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: imx8mm: Add i.MX8M Mini Toradex Verdin based Menlo board
Date: Mon, 18 Apr 2022 20:25:00 +0800	[thread overview]
Message-ID: <20220418122500.GM391514@dragon> (raw)
In-Reply-To: <20220414124421.12008-2-marex@denx.de>

On Thu, Apr 14, 2022 at 02:44:21PM +0200, Marek Vasut wrote:
> Add new board based on the Toradex Verdin iMX8M Mini SoM, the MX8Menlo.
> The board is a compatible replacement for i.MX53 M53Menlo and features
> USB, multiple UARTs, ethernet, LEDs, SD and eMMC.
> 
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> V2: - Add dedicated 20 MHz clock representing Xtal on custom carrier board
>     - Drop all the I2C clock limitation due to errata ERR007805, this is
>       fixed by separate driver patch:
>       i2c: imx: Implement errata ERR007805 or e7805 bus frequency limit
>     - Drop uart-has-rtscts from uart2, this is in verdin dtsi already
> V3: - Drop can@0 gpio-controller property
>     - Add RB by Fabio
> V4: - Drop can@0 status="okay" property too, this is default
>     - Add RB by Francesco
> ---
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../boot/dts/freescale/imx8mm-mx8menlo.dts    | 321 ++++++++++++++++++
>  2 files changed, 322 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 85c2c9ba51103..9a720343edeab 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -56,6 +56,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-mx8menlo.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen-r2.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-tqma8mqml-mba8mx.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> new file mode 100644
> index 0000000000000..c2ba608844bae
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> @@ -0,0 +1,321 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> +/*
> + * Copyright 2021-2022 Marek Vasut <marex@denx.de>
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8mm-verdin.dtsi"
> +
> +/ {
> +	model = "MENLO MX8MM EMBEDDED DEVICE";
> +	compatible = "menlo,mx8menlo",
> +		     "toradex,verdin-imx8mm",
> +		     "fsl,imx8mm";
> +
> +	/delete-node/ gpio-keys;
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_led>;
> +
> +		user1 {
> +			label = "TestLed601";
> +			gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "mmc0";
> +		};
> +
> +		user2 {
> +			label = "TestLed602";
> +			gpios = <&gpio4 10 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +
> +	beeper {
> +		compatible = "gpio-beeper";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_beeper>;
> +		gpios = <&gpio5 3 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	/* Fixed clock dedicated to SPI CAN on carrier board */
> +	clk_xtal20: clk-xtal20 {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <20000000>;
> +	};
> +};
> +
> +&ecspi1 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi1>;
> +	cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +
> +	/* CAN controller on the baseboard */
> +	canfd: can@0 {
> +		compatible = "microchip,mcp2518fd";
> +		clocks = <&clk_xtal20>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> +		reg = <0>;
> +		spi-max-frequency = <2000000>;
> +	};
> +
> +};
> +
> +&ecspi2 {
> +	pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_gpio1>;
> +	cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>, <&gpio3 4 GPIO_ACTIVE_LOW>;
> +	status = "disabled";
> +};
> +
> +&ethphy0 {
> +	max-speed = <100>;
> +};
> +
> +&fec1 {
> +	status = "okay";
> +};
> +
> +&flexspi {
> +	status = "okay";
> +
> +	flash@0 {
> +		reg = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "jedec,spi-nor";
> +		spi-max-frequency = <66000000>;
> +		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <4>;
> +	};
> +};
> +
> +&gpio1 {
> +	gpio-line-names =
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "";
> +};
> +
> +&gpio2 {
> +	gpio-line-names =
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "";
> +};
> +
> +&gpio3 {
> +	gpio-line-names =
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "DISP_reset", "KBD_intI",
> +		"", "", "", "",
> +		"", "", "", "";
> +};
> +
> +&gpio4 {
> +	/*
> +	 * CPLD_D[n] is ARM_CPLD[n] in schematic
> +	 * CPLD_int is SA_INTERRUPT in schematic
> +	 * CPLD_reset is RESET_SOFT in schematic
> +	 */
> +	gpio-line-names =
> +		"CPLD_D[1]", "CPLD_int", "CPLD_reset", "",
> +		"", "CPLD_D[0]", "", "",
> +		"", "", "", "CPLD_D[2]",
> +		"CPLD_D[3]", "CPLD_D[4]", "CPLD_D[5]", "CPLD_D[6]",
> +		"CPLD_D[7]", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "KBD_intK",
> +		"", "", "", "";
> +};
> +
> +&gpio5 {
> +	gpio-line-names =
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "",
> +		"", "", "", "";
> +};
> +
> +&gpio_expander_21 {
> +	status = "okay";
> +};
> +
> +&hwmon {
> +	status = "okay";
> +};
> +
> +&i2c3 {
> +	status = "okay";
> +};
> +
> +&i2c4 {
> +	/* None of this is present on the SoM. */
> +	/delete-node/ bridge@2c;
> +	/delete-node/ hdmi@48;
> +	/delete-node/ touch@4a;
> +	/delete-node/ sensor@4f;
> +	/delete-node/ eeprom@50;
> +	/delete-node/ eeprom@57;
> +};
> +
> +&iomuxc {
> +	pinctrl-0 = <&pinctrl_gpio7>, <&pinctrl_gpio_hog1>,
> +		    <&pinctrl_gpio_hog2>, <&pinctrl_gpio_hog3>;
> +
> +	pinctrl_beeper: beepergrp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_SPDIF_TX_GPIO5_IO3			0x1c4
> +		>;
> +	};
> +
> +	pinctrl_ecspi1: ecspi1grp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK		0x4
> +			MX8MM_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI		0x4
> +			MX8MM_IOMUXC_ECSPI1_MISO_ECSPI1_MISO		0x1c4
> +			MX8MM_IOMUXC_ECSPI1_SS0_GPIO5_IO9		0x1c4
> +		>;
> +	};
> +
> +	pinctrl_led: ledgrp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_SAI1_TXD6_GPIO4_IO18		0x1c4
> +			MX8MM_IOMUXC_SAI1_TXFS_GPIO4_IO10		0x1c4
> +		>;
> +	};
> +
> +	pinctrl_uart4_rts: uart4rtsgrp {
> +		fsl,pins = <
> +			/* SODIMM 222 */
> +			MX8MM_IOMUXC_GPIO1_IO09_GPIO1_IO9		0x184
> +		>;
> +	};
> +};
> +
> +&pinctrl_gpio1 {
> +	fsl,pins = <
> +		/* SODIMM 206 */
> +		MX8MM_IOMUXC_NAND_CE3_B_GPIO3_IO4			0x1c4
> +	>;
> +};
> +
> +&pinctrl_gpio_hog1 {
> +	fsl,pins = <
> +		/* SODIMM 88 */
> +		MX8MM_IOMUXC_SAI1_MCLK_GPIO4_IO20			0x1c4
> +		/* CPLD_int */
> +		MX8MM_IOMUXC_SAI1_RXC_GPIO4_IO1				0x1c4
> +		/* CPLD_reset */
> +		MX8MM_IOMUXC_SAI1_RXD0_GPIO4_IO2			0x1c4
> +		/* SODIMM 94 */
> +		MX8MM_IOMUXC_SAI1_RXD1_GPIO4_IO3			0x1c4
> +		/* SODIMM 96 */
> +		MX8MM_IOMUXC_SAI1_RXD2_GPIO4_IO4			0x1c4
> +		/* CPLD_D[7] */
> +		MX8MM_IOMUXC_SAI1_RXD3_GPIO4_IO5			0x1c4
> +		/* CPLD_D[6] */
> +		MX8MM_IOMUXC_SAI1_RXFS_GPIO4_IO0			0x1c4
> +		/* CPLD_D[5] */
> +		MX8MM_IOMUXC_SAI1_TXC_GPIO4_IO11			0x1c4
> +		/* CPLD_D[4] */
> +		MX8MM_IOMUXC_SAI1_TXD0_GPIO4_IO12			0x1c4
> +		/* CPLD_D[3] */
> +		MX8MM_IOMUXC_SAI1_TXD1_GPIO4_IO13			0x1c4
> +		/* CPLD_D[2] */
> +		MX8MM_IOMUXC_SAI1_TXD2_GPIO4_IO14			0x1c4
> +		/* CPLD_D[1] */
> +		MX8MM_IOMUXC_SAI1_TXD3_GPIO4_IO15			0x1c4
> +		/* CPLD_D[0] */
> +		MX8MM_IOMUXC_SAI1_TXD4_GPIO4_IO16			0x1c4
> +		/* KBD_intK */
> +		MX8MM_IOMUXC_SAI2_MCLK_GPIO4_IO27			0x1c4
> +		/* DISP_reset */
> +		MX8MM_IOMUXC_SAI5_RXD1_GPIO3_IO22			0x1c4
> +		/* KBD_intI */
> +		MX8MM_IOMUXC_SAI5_RXD2_GPIO3_IO23			0x1c4
> +		/* SODIMM 46 */
> +		MX8MM_IOMUXC_SAI5_RXD3_GPIO3_IO24			0x1c4
> +	>;
> +};
> +
> +&pinctrl_uart1 {
> +	fsl,pins = <
> +		/* SODIMM 149 */
> +		MX8MM_IOMUXC_SAI2_RXFS_UART1_DCE_TX			0x1c4
> +		/* SODIMM 147 */
> +		MX8MM_IOMUXC_SAI2_RXC_UART1_DCE_RX			0x1c4
> +		/* SODIMM 210 */
> +		MX8MM_IOMUXC_UART3_RXD_UART1_DTE_RTS_B			0x1c4
> +		/* SODIMM 212 */
> +		MX8MM_IOMUXC_UART3_TXD_UART1_DTE_CTS_B			0x1c4
> +	>;
> +};
> +
> +&reg_usb_otg1_vbus {
> +	/delete-property/ enable-active-high;
> +	gpio = <&gpio1 12 GPIO_ACTIVE_LOW>;
> +};
> +
> +&reg_usb_otg2_vbus {
> +	/delete-property/ enable-active-high;
> +	gpio = <&gpio1 14 GPIO_ACTIVE_LOW>;
> +};
> +
> +&sai2 {
> +	status = "disabled";
> +};
> +
> +&uart1 {
> +	uart-has-rtscts;
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	status = "okay";
> +};
> +
> +&uart4 {
> +	pinctrl-0 = <&pinctrl_uart4 &pinctrl_uart4_rts>;
> +	linux,rs485-enabled-at-boot-time;
> +	rts-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
> +	status = "okay";
> +};
> +
> +&usbotg1 {
> +	dr_mode = "gadget";

Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt says:

- dr_mode: One of "host", "peripheral" or "otg". Defaults to "otg"

Or am I looking at a wrong binding doc?

Shawn

> +	status = "okay";
> +};
> +
> +&usbotg2 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
> +&usdhc2 {
> +	status = "okay";
> +};
> -- 
> 2.35.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-18 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 12:44 [PATCH v4 1/2] dt-bindings: arm: Add i.MX8M Mini Toradex Verdin based Menlo board Marek Vasut
2022-04-14 12:44 ` [PATCH v4 2/2] arm64: dts: imx8mm: " Marek Vasut
2022-04-18 12:25   ` Shawn Guo [this message]
2022-04-18 13:20     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220418122500.GM391514@dragon \
    --to=shawnguo@kernel.org \
    --cc=festevam@denx.de \
    --cc=francesco.dolcini@toradex.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox