From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA2EFC433EF for ; Tue, 19 Apr 2022 09:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gRvPnk6twaFfanB8YJ3UB3ZeBc64SkUaIdryDkLI/L0=; b=LfzBv48561q8UJ jQz4Fvr996VYpR/iknNGGhzZmhoPEwr23LD4zi4RiZKNZcVHtoKnx4mN7RvjTuyFkirQ5QOOWzvmr ql+Q8EfxbGltUkhdCpLb14ueTJyLOnYpxpLDgMLM4QjwkN2CjTTx/+MkCGWiJV6omaWdkfFsGaiZ/ a1WfBl4DlTfla3Y9Bu3YfoRH+42bqX46piwIiqntMeKqVRI6daKvlCXsf1eA6oqB106fN9NQLbqVq e03zrKJZaFcCp/DW5C77vitO86GXAXyGHVe0zK9v1gBfmGZYZiM+7oK6gRD52nA/FT15c2iYFaV6k Bs6D/51opTHAgEBrtK2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngkaX-002exF-UE; Tue, 19 Apr 2022 09:56:02 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngkY6-002dVp-Nq for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 09:53:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650362010; x=1681898010; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jfHt7wB5XGMSPzgSoV7ck75X/YUam3lD2caa7ddZDys=; b=TOq+XBbm1i4G7AZUmFVNibYgXihjyu8FeKcyZEB/wfI5k6kAshFT3qDv ztjoEm5/uASNtaf0RO0LSTaMhTu3EmoxeBScEf9hrUq2Jk6zc0y1Qb8nv 3OP4qg0s0qwdHIafWMH2H9oL4/tRRsMo3ntCYivsUpdIHnD15Et/PbyFJ qJaGQumgEXy+kpIOQaUwaLGQtNXrf6e07NpCjazSLJ7PQIMOvQaOnBp7t pID9R8CZjhPcFMu5scq0D5L4pVp8iH2ATDLK3ETe+cUt7K3XPeY+OMJmc JPZgzXH/Zn2d6OE+9ekW0cSmcguFy/1hcRDSGlDyW/Sc4Ez6A1hnYQGOY g==; X-IronPort-AV: E=McAfee;i="6400,9594,10321"; a="262585828" X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="262585828" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 02:53:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="576022673" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.135]) by orsmga008.jf.intel.com with ESMTP; 19 Apr 2022 02:52:57 -0700 Date: Tue, 19 Apr 2022 17:45:21 +0800 From: Xu Yilun To: Nava kishore Manne Cc: Joe Perches , "mdf@kernel.org" , "hao.wu@intel.com" , "trix@redhat.com" , Michal Simek , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , git Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues Message-ID: <20220419094521.GA322948@yilunxu-OptiPlex-7050> References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-3-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_025330_841894_83EEBBB9 X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 08:15:57AM +0000, Nava kishore Manne wrote: > Hi Joe, > > Please find my response inline. > > > -----Original Message----- > > From: Joe Perches > > Sent: Monday, April 18, 2022 6:04 PM > > To: Nava kishore Manne ; mdf@kernel.org; > > hao.wu@intel.com; yilun.xu@intel.com; trix@redhat.com; Michal Simek > > ; linux-fpga@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git > > > > Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues > > > > On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote: > > > Hi Joe, > > > > > > Please find my response inline. > > > > > > > -----Original Message----- > > > > From: Joe Perches > > > > Sent: Saturday, April 16, 2022 10:29 PM > > > > > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote: > > > > > fixes the below checks reported by checkpatch.pl Lines should not > > > > > end with a '(' > > > > > Alignment should match open parenthesis > > > > > > > > in fpga-mgr: > > > > Another possibillty would be to change the function arguments > > > > > > This API is there for a long back. Not sure changing the function arguments is fine or Not. > @yilun: Is it ok to change the function arguments? Joe's example code below doesn't actually change any function definition. It just tries to store the value of 'min(mgr->mops->initial_header_size, count)' in 'count', thus to reduce the length of the 'fpga_mgr_write_init(...)' expression. So I think it is OK. Thanks, Yilun > > > > > and > > > > > > > > in fpga-region: > > > > Ideally keep the include declaration and definition styles synced > > > > > Will fix it in next version. > > Regards, > Navakishore. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel