From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDF67C433F5 for ; Wed, 20 Apr 2022 08:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zFmFrcgPLogdPOYf+GnX3qpvLE2m2fGEJ9uibnIpah8=; b=4BPRs3yMQCJkoQ KCkUVhGYVQJh4yrGKtwt3cDo5vRLnVBS0MkdRsr3CZD7GzaBVJmIL6VDInUprznPFtqYUPc3hDfEw u2UUHQqCuuAVwSk61CQzu+5N14CE0tS7lfAPa5oWGqbutGKdqxMJrmHD+nF0Jfc4mrikEPc0qPDmT m2MyrE7mI0wLYurdxakgtc5vKOeaPuWA7bUjrIt3LjP90jWsX4tYtvISVaZM62feBL0+MLQfeXgPy 9/pDu83r6C5gm40OIv4HP7jOxJ7PDFeAS9sTQOV+TJfBGKy71MeqUEyaFr8fqO/qh86GOtqC2Bp2X flu/rDjZ3LbW+HrN0TuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh5cW-00848w-2q; Wed, 20 Apr 2022 08:23:28 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh5cT-00843C-B1 for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 08:23:26 +0000 Received: by mail-ej1-x62e.google.com with SMTP id g13so1964810ejb.4 for ; Wed, 20 Apr 2022 01:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xr/nwtWLJ4TVu51kmsxUrzU9/ydN9NkiuHnUJzHV7fM=; b=HdpM/EEKgkbRipP0cAc3Eq561sf8la7DC871v+kRQo5yDV0HaXu0mE1BYlFEDMHvyA JSq91bpiBkpSofh7MNm/eIWm7xhqUdahyWYtQT19REhiexB3m+0w1Ro9/zwbmopG79Is Sg/Wc3V23gXKMNfDszhod1Xp6jkO/JEj/Ua/+J4W7cGyvx33kCA40eWNiNlhMoKeN8Ww 9r92eQn+3e2xKGxfCMokEfE8G+H6tTbXr14BZtDdE2fSUWUCUNyTXq633K4fbu+ggvU/ tGNLFH1G9tT1uWBIHhvEqwQWjY1W/QJpWE80CJad6Bbq/w4Whn+XWT4FqFikd3SGdOqf 0lNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xr/nwtWLJ4TVu51kmsxUrzU9/ydN9NkiuHnUJzHV7fM=; b=vl+pGQyqUB7Xpz6QH7rcrLE/ofkvSveJPPPgi/AIyHW9lsEcc3X21QGY/AcUV4boGc Qi0/k7szDikg2jxEGbQZvzpTJ7/wfORzXu/0oh8pM9VOWQ3uRQzbJF3Y7vCImK/EEwsH Qii+V0KZHeTo88Sa6M94L2qUmTEutejtIOkCH/S3yKwumWplqKaRMSwGT28ptdxJsdWL J6Sd3V9MrPwa3bcZ/2CtIFG3eoYPzoMnJ9kOOBVBAILnXW3adffrfabNjzpT46Zl+SLX r/70nCsf72y6BgbQ4HfxJ+3CMPYElYMnDvb09QkirfWcIhHO94sMx0FCn4NmaQgi8+vf 9c+w== X-Gm-Message-State: AOAM533tASbBl2SrxNCvHY8mJktmFFDWI/YiijD+bH6LnmAsYvIwaM1o prBv3H7GfT3sLGnaCzltoF2Xog== X-Google-Smtp-Source: ABdhPJxmVvwxaASEaA16ZHiFrG8KB1I8Px1ZRIfmaCjtMBOMeQ0BQ3KZfr0IsdqGObsczZkGlCfPjw== X-Received: by 2002:a17:907:7da3:b0:6f0:d63:69bd with SMTP id oz35-20020a1709077da300b006f00d6369bdmr482243ejc.289.1650442998280; Wed, 20 Apr 2022 01:23:18 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id h8-20020a1709066d8800b006e09a49a713sm6500926ejt.159.2022.04.20.01.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 01:23:17 -0700 (PDT) Date: Wed, 20 Apr 2022 16:23:11 +0800 From: Leo Yan To: German Gomez Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, acme@kernel.org, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v5 3/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Message-ID: <20220420082311.GB843168@leoy-ThinkPad-X240s> References: <20220408195344.32764-1-alisaidi@amazon.com> <20220408195344.32764-4-alisaidi@amazon.com> <39448754-adf5-f1ba-25e7-8ee3d76f0159@arm.com> <47ec29fe-75ea-62ef-447b-1164569616de@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <47ec29fe-75ea-62ef-447b-1164569616de@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_012325_404047_783A92D3 X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 03:35:52PM +0100, German Gomez wrote: > > On 11/04/2022 11:26, German Gomez wrote: > > On 08/04/2022 20:53, Ali Saidi wrote: > >> Add a flag to the perf mem data struct to signal that a request caused a > >> cache-to-cache transfer of a line from a peer of the requestor and > >> wasn't sourced from a lower cache level. The line being moved from one > >> peer cache to another has latency and performance implications. On Arm64 > >> Neoverse systems the data source can indicate a cache-to-cache transfer > >> but not if the line is dirty or clean, so instead of overloading HITM > >> define a new flag that indicates this type of transfer. > > I think it's fine to merge this and the previous commit rather than have > > two commits with the same msg. > > > > I take it back. It has been pointed out to me that having the separation > is normal/ok. So my comment doesn't apply. Yeah, it's good that we split these two patches since it's easier for maintainer to pick up separately :) Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel