From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 908DCC433EF for ; Wed, 20 Apr 2022 09:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BBIUDt2Jl5TBGQt71y7qbQoQfJq8a0IgEiCceTqZdYI=; b=KkQWFLEgvld6eB WhP6DLGzekZ5HB4wgSfv1Q7iJ21hdAPa7Xsw8Dgmk+hGLkFtoF60k+H3vcAIPTMbyOELI8COKJmV3 UpWb+vwsrGpMHyyfM2pbsp8BAY5IXQyef8zIHxxesyZ+LouABxMDlq7gI0fP5GoN8pHUvaxxU4cQ0 YGV31xKrhb6LRQy5qHAxgRRiqH7aHu+dy3yNR4PZvcsk7LrCwwUEoWnQB6Atdn4NBliiw/B8jeZHl 9KAqYA7CnxiVWNZyncwAP6Un4fVENMOcNDIcMSu/grOA4O+VLvm1hJzEpppf0sUdsXZsJwpfnXKkl EdpvckQyP+oRIFjXWziA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh6bx-008K5J-Gd; Wed, 20 Apr 2022 09:26:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh6bu-008K3z-NO for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 09:26:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B2B961698; Wed, 20 Apr 2022 09:26:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B3A8C385A8; Wed, 20 Apr 2022 09:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650446809; bh=PTHNSj/YL/+mHRk2KR0myt9wg4Rc6o3VFjDgsWtfPKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kNNT1juDdncKbnCAdE1OXKdD8Mdy9Z4sfT15otlheeryRSKbuAxUmA2aTGtWVzWbd tlJpo6d/vuIfdJwWCA4xoyny89aiyX2umfwCw77uDFPYyoRGj1fCWYooJlkfmwQ2Ti 16rM6Yqf9CChcThaJKYeX1RslPRGIv4/qoeSY1qHUcF69H8vg2BAtVQeDCg/oH9uX3 9hLWUNCOxxwbc1COydBOdy3baZQ+eqRSOuH+w0Z04YJcRJOh1wv29z36RVvWhZlQ7g Zp4Y650kTXLWv3fbLoYL+QUcwwD+GhzkBwVv3BCCvGRmKm2UPR5uR2GjCN0zNCA9Dj A52J/jouVH1lg== Date: Wed, 20 Apr 2022 10:26:45 +0100 From: Will Deacon To: Ilkka Koskinen Cc: Robin Murphy , mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] perf/arm-cmn: Add CMN-650 support Message-ID: <20220420092644.GA6954@willie-the-truck> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_022654_839725_7368AD85 X-CRM114-Status: GOOD ( 29.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 04:47:11PM -0700, Ilkka Koskinen wrote: > On Tue, 19 Apr 2022, Ilkka Koskinen wrote: > > On Mon, 18 Apr 2022, Robin Murphy wrote: > > > Add the identifiers and events for CMN-650, which slots into its > > > evolutionary position between CMN-600 and the 700-series products. > > > Imagine CMN-600 made bigger, and with most of the rough edges smoothed > > > off, but that then balanced out by some bonkers PMU functionality for > > > the new HN-P enhancement in CMN-650r2. > > > > > > Most of the CXG events are actually common to newer revisions of CMN-600 > > > too, so they're arguably a little late; oh well. > > > > > > Signed-off-by: Robin Murphy > > > --- > > > drivers/perf/arm-cmn.c | 222 ++++++++++++++++++++++++++++++++--------- > > > 1 file changed, 176 insertions(+), 46 deletions(-) > > > > > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > > > index 9c1d82be7a2f..cce8516d465c 100644 > > > --- a/drivers/perf/arm-cmn.c > > > +++ b/drivers/perf/arm-cmn.c > > > > > @@ -1979,6 +2108,7 @@ MODULE_DEVICE_TABLE(of, arm_cmn_of_match); > > > #ifdef CONFIG_ACPI > > > static const struct acpi_device_id arm_cmn_acpi_match[] = { > > > { "ARMHC600", CMN600 }, > > > + { "ARMHC650", CMN650 }, > > > > Not the great place for this comment but there probably isn't any better. > > > > Based on DEN0093 v1.1, CMN's DSDT entries have been changed since > > CMN-600. ROOTNODEBASE seems to be specific for CMN-600. Moreover, if you > > compare the address maps in TRMs' Discovery chapters, you can see the > > difference. > > > > I'm thinking, at the minimal the second platform_get_resource() call has > > to be skipped and zero returned in arm_cmn600_acpi_probe(), if the model > > is cmn650 (probably also for cmn-700) > > Uh, if only I had read the code more carefully, I had noticed that's what > the driver does indeed. > > > Anyway, so far it everything works fine. I test the driver a little more > (and review the patches more carefully) and will let know how it goes. Thanks for giving it a spin! Please reply with a Tested-by if/when you're happy with them, then I can queue them up (you've still got a couple of weeks, so no rush). Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel