From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E671DC433F5 for ; Fri, 22 Apr 2022 01:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Homelra3Qnpxxk9tdEzbZcWf157bEhF6yPlhcZtzWg=; b=KjkmufHSptHPwI hlt3O8PzQfwzcDg44kTfuXCxFcalSGMXTEK1w0grGQB6yZtGR170lNehIEB4WK5HDMpcA35sDau6q jkcsFWJC8sf8VbHdBfEexYxtZLsjUFPF+zbw2ZTPosI2LHDH3cK+f+gzaOyUvm9iCECAiroFVzjQr DgXE6BGjUGV4ngZc1jSO0r9DFzcqXAtjDCeQEmvliasBbzkUpgO9A7HL3iJZ3yxwTPU0CY6webkma vQM4IVb2E3X2qEiSkGF5u4zfbkbdttgBCzDCFSFr6/5gzeG7f0LzrMZlj/8WrneFlStA4Lj5yzi7Y HJMYJexeHWPkxwZE5Z9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhhys-00FXPD-MK; Fri, 22 Apr 2022 01:21:06 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhhyo-00FXMr-T4 for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 01:21:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93F47B828C8; Fri, 22 Apr 2022 01:21:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52267C385A5; Fri, 22 Apr 2022 01:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650590459; bh=ZGP6Dc5HcbyYx3f99nyxqazx+rsBw8MPomaGNK5aG6g=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=FImYl/5UrR4i0m6nCKBrz+z1VN3Zg730BK0ue7KWi4bLydZ/F70wJMb9JLwLTZL8n f1sahHwn759HtZb2fXH9ZQ4ltig1/8Xa6pZsuoGpbaofsbFNgyCtRCcIt199ELfRhk pLBm88zhb+xq12fw1k9DoavfM2G09U9+nuC+g/UB2vS+KqURyHuBryqI4kfX8CkDlq OhUkt6E8cAPFdg7t7Prdl7NVsUupxvDpDlMatUTbaQnXni8fgY+6ORw8m8BjQB3hDx VDkXpQqAQ/Fwq/9blwMnrpVlI/5Ev/GNZ7XPHdWFconE4rTxwSWdKIPmA4qiqYi9xb 5GCb3j8kdj1Nw== MIME-Version: 1.0 In-Reply-To: <20220412065719.17735-1-linmq006@gmail.com> References: <20220412065719.17735-1-linmq006@gmail.com> Subject: Re: [PATCH] clk: imx: scu: Fix pm_runtime_get_sync() error checking From: Stephen Boyd Cc: linmq006@gmail.com To: Abel Vesa , Dong Aisheng , Fabio Estevam , Miaoqian Lin , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 21 Apr 2022 18:20:57 -0700 User-Agent: alot/0.10 Message-Id: <20220422012059.52267C385A5@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_182103_102641_F7ABA749 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Miaoqian Lin (2022-04-11 23:57:18) > If the device is already in a runtime PM enabled state > pm_runtime_get_sync() will return 1, so a test for negative > value should be used to check for errors. Maybe it should use pm_runtime_resume_and_get() instead? > > Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") > Signed-off-by: Miaoqian Lin > --- > drivers/clk/imx/clk-scu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c > index 083da31dc3ea..18c6190eeffd 100644 > --- a/drivers/clk/imx/clk-scu.c > +++ b/drivers/clk/imx/clk-scu.c > @@ -529,7 +529,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev) > pm_runtime_enable(dev); > > ret = pm_runtime_get_sync(dev); > - if (ret) { > + if (ret < 0) { > pm_genpd_remove_device(dev); > pm_runtime_disable(dev); > return ret; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel