From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tom Rix <trix@redhat.com>
Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com,
gregkh@linuxfoundation.org, stefan.wahren@i2se.com,
gascoar@gmail.com, ojaswin98@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static
Date: Fri, 22 Apr 2022 17:44:23 +0300 [thread overview]
Message-ID: <20220422144423.GI2462@kadam> (raw)
In-Reply-To: <20220418164356.3532969-1-trix@redhat.com>
On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote:
> Smatch reports this issue
> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init'
> was not declared. Should it be static?
This is a Sparse warning, not Smatch.
Use this command for Smatch
~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
And this command for Sparse
~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-22 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 16:43 [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static Tom Rix
2022-04-18 22:58 ` kernel test robot
2022-04-18 23:19 ` kernel test robot
2022-04-19 12:14 ` Greg KH
2022-04-22 14:44 ` Dan Carpenter [this message]
2022-04-22 15:32 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422144423.GI2462@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=stefan.wahren@i2se.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).