From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA661C433EF for ; Sat, 23 Apr 2022 02:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=MMAW8jA4VsPN6v1RZlmhY0NbQLX5doJnpWFWwljKyn4=; b=zZjIDg7O2A9I5aGtwK1mCjjE6n +1F/PxyttnbA/W8KgFazun/EjMECbnQnizs7Ty97jfdPJfXuksnqlTrtZPcBq9jDt7m8cKpXz9fQq byGSW8fhgVv+R7krZ4RhKDFArvGL/KBm+qkVbIl246yArefROdrbBQnrvBy/+WLJFFdY1CKFbN9x1 krc/PindrmKHRqnS3YOd6x0I0X5Om1H3zDIdm00GqClSHbaBvZ9yPRVZXv1iXVtOHh0rb9z85jFuu 9DsM/joLmIeT/T1BZlBRqW6VOVFVivlfOUYE4QpMLrOS/0tAqIRq88dbLGAP/8Q59EBgm6BaiF8Yi dqhXpt4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni5Qw-003Glh-9Q; Sat, 23 Apr 2022 02:23:38 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni5Qt-003Gl5-Rr for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 02:23:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12913B83219; Sat, 23 Apr 2022 02:23:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C04D6C385A0; Sat, 23 Apr 2022 02:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650680612; bh=haZUNetI18mwticLWcDQIHl1eNz0IU+GIiz4lHFqO2o=; h=In-Reply-To:References:Subject:From:To:Date:From; b=NJVBlWtCwHJSzgU8Bjes7Sdh8ZHwb3qWfO2cph12yW4KJKdJ3CgqbEvh0q/SzGTTf CdqygZJCDjvDSpo0lvse2ZJEwUCi6xSlmYwE5TnvilFFZ5dz/ksZgfPd/CNhd7uRuY TJir3f622QHjlMRS4GOxI7zjKvjyybz4GJZRacem74bO+/3PnWPmOGN1Fc4Ppybp4t fmLJOwMSg6Lk+t252b5EC5t35QxapQRpjLkstpdlctW82g3XD8DvGazuepzK4PFA4F lS/cJB/zUlCW63iKpc/SDog9tbXpueL3eU2vk0eecxsDLJsn1MfIzQAP3YRQV8RHKJ bpDp6ZBUcJJtQ== MIME-Version: 1.0 In-Reply-To: <8e893363-3e47-2abe-7111-b3fb0888d4fc@gmail.com> References: <20220422012059.52267C385A5@smtp.kernel.org> <20220422013317.30362-1-linmq006@gmail.com> <20220422014411.4F96BC385A7@smtp.kernel.org> <8e893363-3e47-2abe-7111-b3fb0888d4fc@gmail.com> Subject: Re: [PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage From: Stephen Boyd To: Abel Vesa , Dong Aisheng , Fabio Estevam , Miaoqian Lin , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 22 Apr 2022 19:23:30 -0700 User-Agent: alot/0.10 Message-Id: <20220423022332.C04D6C385A0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_192336_090298_D50B74C9 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Miaoqian Lin (2022-04-21 18:59:54) > > On 2022/4/22 9:44, Stephen Boyd wrote: > > Quoting Miaoqian Lin (2022-04-21 18:33:16) > >> If the device is already in a runtime PM enabled state > >> pm_runtime_get_sync() will return 1. > >> > >> Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() > >> fails, so use pm_runtime_resume_and_get() instead. this function > >> will handle this. > >> > >> Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") > >> Signed-off-by: Miaoqian Lin > >> --- > > Please don't send patches as replies to previous versions of the patch. > > Sorry, I thought I should keep them in one thread, to provide the context Please link back to previous revisions with lore. https://lore.kernel.org/r/ and then add a change log below the triple dash referencing that lore link and anything that has changed since that revision. > > for other people to follow up. Am I suppose to resend it? Yes. Might as well practice making a changelog at the same time. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel