From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49FACC433F5 for ; Sun, 24 Apr 2022 11:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YmW9JRhebHYAQhfG1HCG3cviwE5lKEVsiq+MU4KHPXI=; b=k7ZUR82pzT2Inn /B58wSJDJNNi+hhy7gvh+WifvnFY5Gm1lBZdZHH985foM+J4nCSxG0eXGsNmsTeGOD6Rf4o7z7gpj lanmX8L+YTBRhCWjR3kltkEewiCw4qYdfQ5m0BzqNtAS3tkWakrYYn+st7tuAbqBtH5s2yjjvGXgX PAHAXOsS65USVJmlQV14s1xQ0NRPGqWZVXEERvdM6TqmFiF7FhEuw4P+0vMRDzMPSfSBP5j+JFjKe QTxjRmGQwwT991MoiUXFyGYrIuGVpXHO8DwgVnC0yxB5SM2LxEPUiE0hC1N8vgkixVqaBTSLZpvAi lLO1V1S/q2gF9dM6vGUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niae3-006Uoj-Nj; Sun, 24 Apr 2022 11:43:15 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niae0-006UnY-A0 for linux-arm-kernel@lists.infradead.org; Sun, 24 Apr 2022 11:43:13 +0000 Received: by mail-ed1-x533.google.com with SMTP id g20so15418294edw.6 for ; Sun, 24 Apr 2022 04:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vR6QyTXKzjneeimQgI3lYac2uhU+48R8rf60k+wC+NM=; b=K+eVy8LHU3Vs4eoXT0+qrRxAlQ6jVP2PJ/1UCE45qSIvmR9J0w19LAWrPbrfpkKaP0 a+mfTOLAdPdmq8mtU1R407jZrmLBptYOTWYKm4bBBYVSCtMn7OkfZIC2UAev6uqZ/UZB H7jus/W4yKHDqFintBj9nBAgEPyEzumxjlQ60xsqq+ZlAy6LQUA4sqBIHkaNsdvJDmx3 vq0hGl6iG3XztLrb9msBBk6+uHXoYQozfpjFsck/0mSWryAPPYzXSbPVGMopHvxPxQ51 sdV5GgJgA9Az7I4ciBT6YXFRMfraH2vZz5dEWsWdOiFW7IhTLhB7MtUoZies6/Gudw4a 6Ypw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vR6QyTXKzjneeimQgI3lYac2uhU+48R8rf60k+wC+NM=; b=5pGwsD8vS0rmQyZ1JMne3Z77t3BbYNhcAyIXAyiRG4ORcsGzXyi9IqtoIM1nEBu8gu Mi8N8fa4wEJzN3Ed+KjfuDOtK7CH+sIHU9LdRvGplr8NhFtvPHKG5DDwzCGn7OYESGGM S4qkeoY7DCUMtWU+vrP5w2r0+0bhEQLHeWTi07itRoZuQHMBd1f7ezE/gqhN6bffuuII bzOuGLALSmmkdOun4cA1eyicwVCTSTHUpmIV7xAnRm9czrIIcR4yHoaZWxqfDBHwQkXq koXjft2ThLpFQ6zGwBAkV3qEBahVgLtnvXuzGtgut+MeZnSoBvfR9/JVAXbvPkWM47no 9TvQ== X-Gm-Message-State: AOAM530cMWqe0wE3830/POiiXfnw3597TzSNytEqOShSEiaCOMxjNzSW cH6e2cetrvO8bWSv+1YYlTD95A== X-Google-Smtp-Source: ABdhPJxy5Rbwg1eY20BNgqRD5xxDnNA3PThlSvyPpivCD2BUoRplRnX1hWPmo7UhMrbaXgw37YMxHA== X-Received: by 2002:a50:baa8:0:b0:415:b0bc:6353 with SMTP id x37-20020a50baa8000000b00415b0bc6353mr13999510ede.220.1650800589299; Sun, 24 Apr 2022 04:43:09 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id o3-20020aa7c7c3000000b0042237eda622sm3189324eds.83.2022.04.24.04.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Apr 2022 04:43:08 -0700 (PDT) Date: Sun, 24 Apr 2022 19:43:02 +0800 From: Leo Yan To: Andi Kleen Cc: Ali Saidi , kan.liang@linux.intel.com, Nick.Forrington@arm.com, acme@kernel.org, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, benh@kernel.crashing.org, german.gomez@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v5 2/5] perf: Add SNOOP_PEER flag to perf mem data struct Message-ID: <20220424114302.GB978927@leoy-ThinkPad-X240s> References: <20220422212249.22463-1-alisaidi@amazon.com> <20220423063805.GA559531@leoy-ThinkPad-X240s> <8e09af67-a416-4ead-b406-6c8b998de344@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8e09af67-a416-4ead-b406-6c8b998de344@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220424_044312_480535_79206056 X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 23, 2022 at 05:53:28AM -0700, Andi Kleen wrote: > > > Except SNOOPX_FWD means a no modified cache snooping, it also means it's > > a cache conherency from *remote* socket. This is quite different from we > > define SNOOPX_PEER, which only snoop from peer CPU or clusters. > > > > If no objection, I prefer we could keep the new snoop type SNOOPX_PEER, > > this would be easier for us to distinguish the semantics and support the > > statistics for SNOOPX_FWD and SNOOPX_PEER separately. > > > > I overlooked the flag SNOOPX_FWD, thanks a lot for Kan's reminding. > > Yes seems better to keep using a separate flag if they don't exactly match. > > It's not that we're short on flags anyways. Thanks for confirmation. Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel