From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2A1EC433EF for ; Mon, 25 Apr 2022 22:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uJp9i/96p+Z9SarMaQP2+LV7qupJJjk5CyBu1qZKm34=; b=c0gCXGf8/FaWPt aqbronU6U8/ODMK+0N1qfhF34e1WYXPIFw7hpx2s1fOXZNuVF9gfq0yCY6Ppeub/zhw92rIqaQjLH NehQlMao7ngH6T/85mqafBNSBho45QHRiRTEfYrB0vBw9+1ZU4Xh3LdjYqxpDLiOCm6DEyYQZlJ3T k0s5GJLL9LdE+gEijPZsB/jn3efUrYlyDCWIyOr8J/sDyRU93geC3ChUOBVJYVC9uFdGAEcA+5yIO JD785KfDkLO0D7eq/6xY4YLbMVi1GY/185bWmLAzat7d85wBBve10LwNtW2tl+CZQm+jpa/T7Mqmo mKnI7AcCy1woyLwZ6GFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj7ap-00BgFO-LJ; Mon, 25 Apr 2022 22:54:07 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj7am-00BgEX-QZ for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 22:54:06 +0000 Received: by mail-pg1-x530.google.com with SMTP id g9so14517760pgc.10 for ; Mon, 25 Apr 2022 15:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1Q+RJPi5324M1G6R92MlojY1RDxai3y1EeSAyZxabSw=; b=mwaY4tFFCUPbFZ9IDIp5vPVzIHchfx6du0rPPb25oDWZ0A9ngIKi75lz+toEJiKH67 UKsgX8v25kVY6GexOHFAemNMGbyqWLf2E6EkMTPB/Ll9YBUQCLryNor337fzamre81O9 iZjwAYNILcJ/rKfacKBNMBwi0Gj/JrfR+Qurk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1Q+RJPi5324M1G6R92MlojY1RDxai3y1EeSAyZxabSw=; b=zTSxEPF692lNNveJuG6LOot17c+s2soGijBg3gS63w7Gd1k226bKtykBeHISz2ysPx ux3o2OFg/7LuJAYtP0jgU+mPhmXpYvfQwSTVgZyNB7sF2KJEKkzKmwg2DWMl5n3uhPOK NiIhzFy+OmwteHCfenTFJ/Ljt7+6ZeSpenr4GmyKwvQurCKns/nmOQq4RUsfnYk8CIWd msgpvgiKRM/CqV9CJNWth+Xm7Ziy9kpffl3Llz1BMsSI9Tb7ig6+zx2Har05JrbwvUv3 HoTwyOeOAGyGFw/BfixTbbJmrPICB5EnNxTLjUsRlj79q0WbJAmQVGRR+boRG69Faf0a MPJw== X-Gm-Message-State: AOAM531M+VeoIOqSlvMFh4wgK3lSotKckQcri+uVfD8jV4A6Tlk0vINW TkehgLyzez8NyKuzKJ9T79AhfA== X-Google-Smtp-Source: ABdhPJwngwfKHLdu4op5pfvRAi/1xES2NPHwu26aj463LNBFZYSMll1pfv1ZZ2acFGnJ0p/NXO5NNw== X-Received: by 2002:a05:6a02:105:b0:381:fd01:330f with SMTP id bg5-20020a056a02010500b00381fd01330fmr16697414pgb.483.1650927241923; Mon, 25 Apr 2022 15:54:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f14-20020a63380e000000b0038253c4d5casm10729293pga.36.2022.04.25.15.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 15:54:01 -0700 (PDT) Date: Mon, 25 Apr 2022 15:54:00 -0700 From: Kees Cook To: Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, alex.popov@linux.com, catalin.marinas@arm.com, luto@kernel.org, will@kernel.org Subject: Re: [PATCH 0/8] stackleak: fixes and rework Message-ID: <202204251551.0CFE01DF4@keescook> References: <20220425115603.781311-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220425115603.781311-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_155404_915387_3902A1F5 X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 25, 2022 at 12:55:55PM +0100, Mark Rutland wrote: > This series reworks the stackleak code. The first patch fixes some > latent issues on arm64, and the subsequent patches improve the code to > improve clarity and permit better code generation. This looks nice; thanks! I'll put this through build testing and get it applied shortly... > While the improvement is small, I think the improvement to clarity and > code generation is a win regardless. Agreed. I also want to manually inspect the resulting memory just to make sure things didn't accidentally regress. There's also an LKDTM test for basic functionality. -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel