From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A4A3C433F5 for ; Tue, 26 Apr 2022 15:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MZ8/0hn1Wvo40chw5A6W5PtFq5x+xk4pXaXv5shSh0o=; b=Y4WUBcTRqp3AuM 2Kk8qzrfEKxHAN/mNbF6SYUWmeOqTDjcXj7LaNluD4Kiht2/m0QQddkeTfguuJwuvFGBnbzhyiFAc U/iEc+YkmZxWxorzl/rPDDFHjslHxLBj4QCdYhY3PMQ0Yd0ad5Ah820jcB1MJwCboATWA2mkIY++o eaZMT9yV301Re7UeQj3aufIbwx7W7XVRuaWGK8Ns59DqzpT4apgAhaZxww9+ouDVVo3+OLoIjHdZB 6sCn620810Qobm2LWx7smViDwfy+gvR8iYdTt4ltxYmGzBuQ9YWxYar2NkpTSDwh0Znhm4ddbLlQp cK07znWdN/GT7UUADstA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNE1-00FAgp-2z; Tue, 26 Apr 2022 15:35:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNDy-00FAgN-9W for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 15:35:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 68B0623A; Tue, 26 Apr 2022 08:35:32 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 343163F73B; Tue, 26 Apr 2022 08:35:31 -0700 (PDT) Date: Tue, 26 Apr 2022 16:35:28 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH 02/22] firmware: arm_scmi: Make protocols init fail on basic errors Message-ID: <20220426153528.bhskpchq2huhjtjk@bogus> References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-3-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220330150551.2573938-3-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_083534_398646_DCD5E6EC X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 30, 2022 at 04:05:31PM +0100, Cristian Marussi wrote: > Bail out of protocol initialization routine early when basic information > about protocol version and attributes could not be retrieved: failing to > act this way can lead to a successfully initialized SCMI protocol which > is in fact not fully functional. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/base.c | 5 ++++- > drivers/firmware/arm_scmi/clock.c | 8 ++++++-- > drivers/firmware/arm_scmi/perf.c | 10 +++++++--- > drivers/firmware/arm_scmi/power.c | 10 +++++++--- > drivers/firmware/arm_scmi/reset.c | 10 +++++++--- > drivers/firmware/arm_scmi/sensors.c | 4 +++- > drivers/firmware/arm_scmi/system.c | 5 ++++- > 7 files changed, 38 insertions(+), 14 deletions(-) > > @@ -370,7 +372,9 @@ static int scmi_clock_protocol_init(const struct scmi_protocol_handle *ph) > if (!cinfo) > return -ENOMEM; > > - scmi_clock_protocol_attributes_get(ph, cinfo); > + ret = scmi_clock_protocol_attributes_get(ph, cinfo); > + if (ret) > + return ret; Does this result in removal of scmi_dev associated with devm_* calls ? Otherwise we may need to free the allocated buffers ? I am not sure if the dev here is individual scmi_dev or the platform scmi device. I assume latter and it is unlikely to be removed/freed with the error in the above path. Similarly in couple of other instances/protocols. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel