From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25082C433F5 for ; Tue, 26 Apr 2022 14:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HEe5HNurZG3kIWBjtbEP7xpF5S/ZMfvJR/8Fc452lD4=; b=fkydwJ/AxnE0Yc 9ijYi4AWjekgMgM0jf4GDlIUxjeijEfTvZgITWHUCbR8svlHjAI6Y4lrSeHxU8qFLrHUwLEOD1Wd4 bmALiXwAiyFUU5BI/VUPwhWjHYpqqoHbI39ejLq2W53ZJT7ABXmrKSuYb06kkeucG/N1YqqwDCGKI h9p588szgBxY7Za1QYVkHB7LkpFlHm5Yvi08sJqOFCz1nA+uxcR7Ig/Vz4nsUcs8PCKJcxYu9mEJW LW8B0xkDx+6JzyRwoGDNzhGJIO5BG2PPuAClllLycXPHrILfrmbHQ5n3Bw0BdvH/PutF5BNyAjbKA nI5pvXW8jHrT+nYYFcfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLt5-00Et21-4j; Tue, 26 Apr 2022 14:09:55 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLla-00Epu4-E4 for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 14:02:12 +0000 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 78A2BC0008; Tue, 26 Apr 2022 14:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650981728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7PQZCwiv2zEHTrq79VR/VdsVP2v14TZgynrsHMuTV/0=; b=GqrophupVFhOrusBv9A1zJ+E8bt3QYe/6VKg+dF4uAcEDBOcMdPM/ms2t2RY7ms+XfPhqE TKY4kXPXOQxkdjJ9AocBAj4EHj2bGV+Iox7dkQtp4mcFwCBv+15WFpRXnBqyzXo1yG1TWI lcv+9wSjnqcjjiiVWzWmgKgAH86bZCUfQ7QgQHTlQzYALRjxuc2zBNHwstmIrCY0b7WhQ8 mCORk9Kzwq5iFkouEnUyEYEzNqArXLc1B98EoHbOZHaWhlAeE0hqRqjL1X0PYS3B088MDy COySCDCntcmYyoWU3Cd35fvgbjT49Ov9b+H4AFQRCCKUBdYlGgdCJ5wdqDDpFg== Date: Tue, 26 Apr 2022 16:02:06 +0200 From: Maxime Chevallier To: Krzysztof Kozlowski Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Message-ID: <20220426160206.1a8d425c@pc-19.home> In-Reply-To: <34d3bfdc-cf8c-bf63-4f67-57c8d6c9b780@linaro.org> References: <20220422180305.301882-1-maxime.chevallier@bootlin.com> <20220422180305.301882-5-maxime.chevallier@bootlin.com> <34d3bfdc-cf8c-bf63-4f67-57c8d6c9b780@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_070210_905906_BF6DEDE6 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof On Sat, 23 Apr 2022 19:49:30 +0200 Krzysztof Kozlowski wrote: Thanks a lot for the review, I'll address all your comments in a V2. > On 22/04/2022 20:03, Maxime Chevallier wrote: > > Add the DT binding for the IPQESS Ethernet Controller. This is a > > simple controller, only requiring the phy-mode, interrupts, clocks, > > and possibly a MAC address setting. > > > > Signed-off-by: Maxime Chevallier > > --- > > .../devicetree/bindings/net/qcom,ipqess.yaml | 94 > > +++++++++++++++++++ 1 file changed, 94 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml new file > > mode 100644 index 000000000000..8fec5633692f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > @@ -0,0 +1,94 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/qcom,ipqess.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm IPQ ESS EDMA Ethernet Controller Device Tree > > Bindings > > s/Device Tree Bindings// > > > + > > +allOf: > > + - $ref: "ethernet-controller.yaml#" > > allOf goes after maintainers. > > > + > > +maintainers: > > + - Maxime Chevallier > > + > > +properties: > > + compatible: > > + const: qcom,ipq4019e-ess-edma > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 2 > > + maxItems: 32 > > + description: One interrupt per tx and rx queue, with up to 16 > > queues. + > > + clocks: > > + maxItems: 1 > > + > > + phy-mode: true > > + > > + fixed-link: true > > + > > + mac-address: true > > You don't need all these three. They come from ethernet-controller and > you use unevaluatedProperties. > > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - phy-mode > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + gmac: ethernet@c080000 { > > + compatible = "qcom,ipq4019-ess-edma"; > > + reg = <0xc080000 0x8000>; > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + > > + status = "okay"; > > No status in the example. > > > + > > + phy-mode = "internal"; > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + pause; > > + asym-pause; > > + }; > > + }; > > + > > +... > > > Best regards, > Krzysztof Best Regards, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel