From: Leo Yan <leo.yan@linaro.org>
To: Ali Saidi <alisaidi@amazon.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, german.gomez@arm.com,
acme@kernel.org, benh@kernel.crashing.org,
Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com,
andrew.kilroy@arm.com, james.clark@arm.com,
john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com,
lihuafei1@huawei.com, mark.rutland@arm.com,
mathieu.poirier@linaro.org, mingo@redhat.com,
namhyung@kernel.org, peterz@infradead.org, will@kernel.org
Subject: Re: [PATCH v7 5/5] perf arm-spe: Use SPE data source for neoverse cores
Date: Wed, 27 Apr 2022 23:59:34 +0800 [thread overview]
Message-ID: <20220427155934.GC562576@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20220426135937.18497-6-alisaidi@amazon.com>
On Tue, Apr 26, 2022 at 01:59:37PM +0000, Ali Saidi wrote:
> When synthesizing data from SPE, augment the type with source information
> for Arm Neoverse cores. The field is IMPLDEF but the Neoverse cores all use
> the same encoding. I can't find encoding information for any other SPE
> implementations to unify their choices with Arm's thus that is left for
> future work.
>
> This change populates the mem_lvl_num for Neoverse cores as well as the
> deprecated mem_lvl namespace.
>
> Signed-off-by: Ali Saidi <alisaidi@amazon.com>
I tested this patch and also did the integration testing with perf ć2c
tool, this patch looks good to me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Tested-by: Leo Yan <leo.yan@linaro.org>
James, German, it's better if this patch set can get the green light
from you. So please take a look, thanks!
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-27 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 13:59 [PATCH v4 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Ali Saidi
2022-04-26 13:59 ` [PATCH v7 1/5] perf: Add SNOOP_PEER flag to perf mem data struct Ali Saidi
2022-04-26 13:59 ` [PATCH v7 2/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Ali Saidi
2022-04-26 13:59 ` [PATCH v7 3/5] perf mem: Print snoop peer flag Ali Saidi
2022-04-26 13:59 ` [PATCH v7 4/5] perf arm-spe: Don't set data source if it's not a memory operation Ali Saidi
2022-05-03 10:20 ` German Gomez
2022-04-26 13:59 ` [PATCH v7 5/5] perf arm-spe: Use SPE data source for neoverse cores Ali Saidi
2022-04-27 15:59 ` Leo Yan [this message]
2022-05-03 9:58 ` German Gomez
2022-05-04 16:22 ` Ali Saidi
2022-05-05 15:12 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427155934.GC562576@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=Nick.Forrington@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alisaidi@amazon.com \
--cc=andrew.kilroy@arm.com \
--cc=benh@kernel.crashing.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox