From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 943E5C433EF for ; Thu, 28 Apr 2022 13:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p1vG7t0c0danMQc9/Lf3srmO5olkZcY5SGJMT6sqYuw=; b=OwD7hWJqCDoXTR arcMBDNhOe/J0XalfQ6Hvir+hwvmowlVGQQdNLH9wZWoDNbhAcjwVD1e1AwYA3DScLCMswJkj9wvs Dh2bNKlG0MQG0IVcwpqK/a9kwGq3Mo1VPyyTG5Zql/cdiR4MidU07wbWBVL8K7v4wCOzKsxq0I4+b 98ngJBK2ihWozsL19HWwhwwatpSWNuIipTQA2uZ39gjh+IbzGQsvQyqGpWuahFbRY0EhgHjAgD2CT aNJxNTZ2/u+mdollA5JDHUz/ebRLuakA3+vYbNRuz+QUprbbQA122tkjuL3uC23foB8Ye9s+lZpwR wa+SYYaVQj3J5msmkCrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk4Ju-0076Xr-Ap; Thu, 28 Apr 2022 13:36:34 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk4Dc-0073WD-Mq for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 13:30:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2009060BD6; Thu, 28 Apr 2022 13:30:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35295C385A0; Thu, 28 Apr 2022 13:30:01 +0000 (UTC) Date: Thu, 28 Apr 2022 09:29:59 -0400 From: Steven Rostedt To: Sai Prakash Ranjan Cc: , , , , , , , , , , Bjorn Andersson Subject: Re: [PATCHv13 9/9] soc: qcom: geni: Disable MMIO tracing for GENI SE Message-ID: <20220428092959.175b48ae@gandalf.local.home> In-Reply-To: <3b2fb1e02f7a9836b2388b9f2ce2184c5a0cd444.1651149615.git.quic_saipraka@quicinc.com> References: <3b2fb1e02f7a9836b2388b9f2ce2184c5a0cd444.1651149615.git.quic_saipraka@quicinc.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_063004_836440_E9C03C07 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 Apr 2022 18:14:12 +0530 Sai Prakash Ranjan wrote: > Disable MMIO tracing for geni serial engine driver as it is a > high frequency operation with many register reads/writes and > not very useful to log all MMIO traces and prevent excessive > logging. This states what it does but does not really state why. Are you using MMIO tracing in other locations and this is causing too much noise? What is the real issue. Just saying "excessive logging" is not sufficient. That would be a reason to disable function tracing ;-) -- Steve > > Cc: Bjorn Andersson > Signed-off-by: Sai Prakash Ranjan > --- > drivers/soc/qcom/qcom-geni-se.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index 28a8c0dda66c..a0ceeede450f 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -1,6 +1,9 @@ > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > > +/* Disable MMIO tracing to prevent excessive logging of unwanted MMIO traces */ > +#define __DISABLE_TRACE_MMIO__ > + > #include > #include > #include _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel