From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE5D5C433EF for ; Thu, 28 Apr 2022 10:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iCZUv452LZhZuIT1fmwPIWbkT62IhLe/fiQkHJKpHqg=; b=4okDADA1zMZRrk fLIROdnv05cUxST8BHZXVyfkQlxI9nrXvn0lMwjIslBBaIYl0E2HJIhlGSOhIlJvFzdwyuOZfF3vr KDQG7Hfcjc3BxaoeNapNEAJkSBwknfNm1ZY+jQycjUSL45gN3L4ctfhhbS3Lz/L8iMXe6Zq2KG28M AtZ2Y8csq9FBQCI6T/eisLTnNA/Te1an9zNIeH2Tdb6Fb7Ihk8Z5WtGFntxSM0IPGPd/O+GEdREdO VSSI0/RfpS/jMPENAXPQHqSEYpQSsjtyrPP9IuwrqiEZRnwH4qGxAVlc3WTfSRr8Tn6VhLzh8Oxx4 AKnX6+WMgXmVScaF5EpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1LB-0067lq-0k; Thu, 28 Apr 2022 10:25:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1L5-0067io-FH for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 10:25:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C334B1474; Thu, 28 Apr 2022 03:25:31 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9729B3F774; Thu, 28 Apr 2022 03:25:29 -0700 (PDT) Date: Thu, 28 Apr 2022 11:25:24 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH 02/22] firmware: arm_scmi: Make protocols init fail on basic errors Message-ID: <20220428102524.s37xg2ytjkcgkq3e@bogus> References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-3-cristian.marussi@arm.com> <20220426153528.bhskpchq2huhjtjk@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_032535_642644_B5BB626A X-CRM114-Status: GOOD ( 28.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMjYsIDIwMjIgYXQgMDU6MjU6MjhQTSArMDEwMCwgQ3Jpc3RpYW4gTWFydXNz aSB3cm90ZToKPiBPbiBUdWUsIEFwciAyNiwgMjAyMiBhdCAwNDozNToyOFBNICswMTAwLCBTdWRl ZXAgSG9sbGEgd3JvdGU6Cj4gPiBPbiBXZWQsIE1hciAzMCwgMjAyMiBhdCAwNDowNTozMVBNICsw MTAwLCBDcmlzdGlhbiBNYXJ1c3NpIHdyb3RlOgo+ID4gPiBCYWlsIG91dCBvZiBwcm90b2NvbCBp bml0aWFsaXphdGlvbiByb3V0aW5lIGVhcmx5IHdoZW4gYmFzaWMgaW5mb3JtYXRpb24KPiA+ID4g YWJvdXQgcHJvdG9jb2wgdmVyc2lvbiBhbmQgYXR0cmlidXRlcyBjb3VsZCBub3QgYmUgcmV0cmll dmVkOiBmYWlsaW5nIHRvCj4gPiA+IGFjdCB0aGlzIHdheSBjYW4gbGVhZCB0byBhIHN1Y2Nlc3Nm dWxseSBpbml0aWFsaXplZCBTQ01JIHByb3RvY29sIHdoaWNoCj4gPiA+IGlzIGluIGZhY3Qgbm90 IGZ1bGx5IGZ1bmN0aW9uYWwuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENyaXN0aWFuIE1h cnVzc2kgPGNyaXN0aWFuLm1hcnVzc2lAYXJtLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJz L2Zpcm13YXJlL2FybV9zY21pL2Jhc2UuYyAgICB8ICA1ICsrKystCj4gPiA+ICBkcml2ZXJzL2Zp cm13YXJlL2FybV9zY21pL2Nsb2NrLmMgICB8ICA4ICsrKysrKy0tCj4gPiA+ICBkcml2ZXJzL2Zp cm13YXJlL2FybV9zY21pL3BlcmYuYyAgICB8IDEwICsrKysrKystLS0KPiA+ID4gIGRyaXZlcnMv ZmlybXdhcmUvYXJtX3NjbWkvcG93ZXIuYyAgIHwgMTAgKysrKysrKy0tLQo+ID4gPiAgZHJpdmVy cy9maXJtd2FyZS9hcm1fc2NtaS9yZXNldC5jICAgfCAxMCArKysrKysrLS0tCj4gPiA+ICBkcml2 ZXJzL2Zpcm13YXJlL2FybV9zY21pL3NlbnNvcnMuYyB8ICA0ICsrKy0KPiA+ID4gIGRyaXZlcnMv ZmlybXdhcmUvYXJtX3NjbWkvc3lzdGVtLmMgIHwgIDUgKysrKy0KPiA+ID4gIDcgZmlsZXMgY2hh bmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gPiA+Cj4gCj4gSGkgU3Vk ZWVwLAo+IAo+IHRoYW5rcyBmb3IgdGhlIHJldmlldyBmaXJzdCBvZiBhbGwuLi4KPiAKPiA+ID4g QEAgLTM3MCw3ICszNzIsOSBAQCBzdGF0aWMgaW50IHNjbWlfY2xvY2tfcHJvdG9jb2xfaW5pdChj b25zdCBzdHJ1Y3Qgc2NtaV9wcm90b2NvbF9oYW5kbGUgKnBoKQo+ID4gPiAgCWlmICghY2luZm8p Cj4gPiA+ICAJCXJldHVybiAtRU5PTUVNOwo+ID4gPgo+ID4gPiAtCXNjbWlfY2xvY2tfcHJvdG9j b2xfYXR0cmlidXRlc19nZXQocGgsIGNpbmZvKTsKPiA+ID4gKwlyZXQgPSBzY21pX2Nsb2NrX3By b3RvY29sX2F0dHJpYnV0ZXNfZ2V0KHBoLCBjaW5mbyk7Cj4gPiA+ICsJaWYgKHJldCkKPiA+ID4g KwkJcmV0dXJuIHJldDsKPiA+IAo+ID4gRG9lcyB0aGlzIHJlc3VsdCBpbiByZW1vdmFsIG9mIHNj bWlfZGV2IGFzc29jaWF0ZWQgd2l0aCBkZXZtXyogY2FsbHMgPwo+ID4gT3RoZXJ3aXNlIHdlIG1h eSBuZWVkIHRvIGZyZWUgdGhlIGFsbG9jYXRlZCBidWZmZXJzID8gSSBhbSBub3Qgc3VyZQo+ID4g aWYgdGhlIGRldiBoZXJlIGlzIGluZGl2aWR1YWwgc2NtaV9kZXYgb3IgdGhlIHBsYXRmb3JtIHNj bWkgZGV2aWNlLgo+ID4gSSBhc3N1bWUgbGF0dGVyIGFuZCBpdCBpcyB1bmxpa2VseSB0byBiZSBy ZW1vdmVkL2ZyZWVkIHdpdGggdGhlIGVycm9yIGluCj4gPiB0aGUgYWJvdmUgcGF0aC4KPiA+IAo+ ID4gU2ltaWxhcmx5IGluIGNvdXBsZSBvZiBvdGhlciBpbnN0YW5jZXMvcHJvdG9jb2xzLgo+IAo+ IFNvLCBwaC0+ZGV2IHVzZWQgaW4gdGhlIGFib3ZlIGRldm1fIGlzIGluZGVlZCB0aGUgYXJtX3Nj bWkgcGxhdGZvcm0gZGV2aWNlCj4gYW5kIEkgd2FzICphbG1vc3QqIGdvbm5hIHRlbGwgeW91ICdH b29kIGNhdGNoJywgQlVUIHRoZW4sIHJlcmVhZGluZyBteSBvd24KPiBjb2RlIChPX28pLCBJIHNh dy9yZW1lbWJlcmVkIHRoYXQgd2hlbiBhIHByb3RvY29sIGluc3RhbmNlIGlzIGluaXRpYWxpemVk IG9uCj4gaXQgZmlyc3QgdXNhZ2UsIHRoZXJlIGlzIGluZGVlZCBhIGRldnJlc19ncm91cCBpbnRl cm5hbGx5IG1hbmFnZWQgYnkKPiB0aGUgU0NNSSBjb3JlLCBzbyB0aGF0Ogo+IAo+IHNjbWlfZ2V0 X3Byb3RvY29sX2luc3RhbmNlKCkKPiAKPiAJQGZpcnN0X3Byb3RvY29sX3VzYWdlIChyZWZjb3Vu dCBwaS0+dXNlcnMpOgo+IAo+IAktLT4gc2NtaV9nZXRfcHJvdG9jb2woKSAvLyBqdXN0IGluIGNh c2Ugd2FzIExLTSBwcm90bwo+IAktLT4gc2NtaV9hbGxvY19pbml0X3Byb3RvY29sX2luc3RhbmNl KCkKPiAJCWdpZCA9IGRldnJlc19vcGVuX2dyb3VwKGhhbmRsZS0+ZGV2LCBOVUxMLCBHRlBfS0VS TkVMKTsKPiAKPiAgIAkJcmV0ID0gcGktPnByb3RvLT5pbnN0YW5jZV9pbml0KCZwaS0+cGgpOwo+ IAkJICA9PT09Pj4+IGkuZS4gc2NtaV9jbG9ja19wcm90b2NvbF9pbml0KHBoKQo+IAkJaWYgKHJl dCkKPiAJCQlnb3RvIGNsZWFuOwo+IAkuLi4uLgo+IAo+IAkgICBjbGVhbjoKPiAJICAgCWRldnJl c19yZWxlYXNlX2dyb3VwKGhhbmRsZS0+ZGV2LCBnaWQpOwo+IAo+IAo+IFNvIGJhc2ljYWxseSBh bGwgdGhhdCBoYXBwZW5zIGF0IGluaXRpYWxpemF0aW9uIHRpbWUgaW4gc2NtaV9jbG9ja19wcm90 b2NvbF9pbml0LAo+IEJVVCBhbHNvIGV2ZXJ5dGhpbmcgdGhhdCBoYXBwZW5zIGltcGxpY2l0bHkg aW5zaWRlIHNjbWlfYWxsb2NfaW5pdF9wcm90b2NvbF9pbnN0YW5jZQo+IGR1cmluZyB0aGF0IHBy b3RvY29sIGluaXRpYWxpemF0aW9uIChsaWtlIHRoZSBldmVudHMgcmVnaXN0cmF0aW9uKSBpcyB1 bmRvbmUgb24KPiBmYWlsdXJlIHRyYW5zcGFyZW50bHkgYnkgdGhlIFNDTUkgY29yZSBpbml0L2Zy ZWUgbWFuYWdlbWVudCBmdW5jdGlvbnMKPiAodmlhIGRldnJlc18gZ3JvdXBzLi4uKQo+IAo+IEFs bCBvZiB0aGUgYWJvdmUgaXMgYmVjYXVzZSBlYWNoIHByb3RvY29sIGlzIGluaXRpYWxpemVkIG9u bHkgb25jZSBvbgo+IGl0cyBmaXJzdCB1c2FnZSwgbm8gbWF0dGVyIGhvdyBtYW55IFNDTUkgZHJp dmVyIHVzZXJzIChhbmQgc2NtaV9kZXZzKSBhcmUKPiB1c2luZyBpdC4uLm9ubHkgaW4gY2FzZSAo dW5zdXBwb3J0ZWQpIHdlIGhhdmUgbXVsdGlwbGUgU0NNSSBpbnN0YW5jZXMKPiAocGxhdGZvcm1z KSB0aGVyZSB3aWxsIGJlIG9uZSBpbnN0YW5jZSBvZiBwcm90b2NvbCBpbml0aWFsaXplZCBwZXIg U0NNSQo+IHNlcnZlci4KPiAKPiAuLi4gaGF2aW5nIHNhaWQgdGhhdCwgbm93IEknbGwgZ28gYW5k IGRvdWJsZSBjaGVjayAodGVzdCkgdGhpcyBiZWhhdmlvdXIgc2luY2UgSQo+IGV2ZW4gaGFkIGZv cmdvdCBhYm91dCBoYXZpbmcgaW1wbGVtZW50ZWQgdGhpcyBraW5kIG9mIGRlc2lnbiA6UAo+IAoK TWFrZXMgc2Vuc2UsIHRoYW5rcyBmb3IgdGhlIGRldGFpbGVkIGV4cGxhbmF0aW9uLiBJIGhhZCB0 b3RhbGx5IGZvcmdvdHRlbiBob3cKZGV2cmVzX2dyb3VwIHdvcmtzIPCfmYEsIG15IGJhZC4KCi0t IApSZWdhcmRzLApTdWRlZXAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK