From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17766C433F5 for ; Thu, 28 Apr 2022 10:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gBn/DZ6EbNSBmwmTARS7ayMCO+yvYLIRw4fQrwuBI0U=; b=yQvgjN6AH55bH8 lF3lNe5UM6JrUYF0p5d5nPFd0Gggv7Vg56UHPKVGgW+oC+EMoM41hNw2cdYJDJBAYT/LIQ9vZ5WxW suXR8nN2N04iWBMm5Qo+dEEAKEWoiP6ARytRKtE36ROqfJpClvAeKklcCaDtMPML9yGgtI53ZDzse 0AjAUZOt8rWS/IDUhQYfUM/O6XmyhE8vj+4ga60FZwl1gqnFuxpNrEbltUeTDjea8TzU14D+GPYmR d7PiTPzD7rM6yLAf8CA9JROjYM5IFQ37voTL0LkAIK5DAFbaabBFQsw4LIcalhRxWS2OFmovlxjtH 1dRS9gcyqJtkMf3a188g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1NB-0068ZL-7u; Thu, 28 Apr 2022 10:27:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1N4-0068XK-W1 for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 10:27:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A51091474; Thu, 28 Apr 2022 03:27:37 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EC483F774; Thu, 28 Apr 2022 03:27:35 -0700 (PDT) Date: Thu, 28 Apr 2022 11:27:30 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH 05/22] firmware: arm_scmi: Dynamically allocate protocols array Message-ID: <20220428102730.n65fsfvei7pbwetp@bogus> References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-6-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220330150551.2573938-6-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_032739_150791_98C190B2 X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 30, 2022 at 04:05:34PM +0100, Cristian Marussi wrote: > Move away from a statically allocated array for holding the current set of > protocols implemented by the platform in favour of allocating it > dynamically based on the number of protocols effectively advertised by the > platform via BASE protocol exchanges. > > While at that, rectify the BASE_DISCOVER_LIST_PROTOCOLS loop iterations to > terminate only when a number of protocols equal to the advertised ones has > been received, instead of looping till the platform returns no more > protocols descriptors: this new behaviour is better compliant with the > specification and it has been tested to work equally well against an SCMI > stack running on top of an official SCP firmware on a JUNO board. > Nice, no idea why I forgot that we have num_protocols from the another command when I originally wrote this. I may be carried away with the way OPP or even the clock rate list works I guess. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel