From: Jakub Kicinski <kuba@kernel.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: davem@davemloft.net, joabreu@synopsys.com,
alexandre.torgue@st.com, peppe.cavallaro@st.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node
Date: Thu, 28 Apr 2022 18:40:54 -0700 [thread overview]
Message-ID: <20220428184054.3dd72784@kernel.org> (raw)
In-Reply-To: <20220429004605.1010751-1-jay.xu@rock-chips.com>
On Fri, 29 Apr 2022 08:46:05 +0800 Jianqun Xu wrote:
> The driver use the value of property 'snps,rx-queues-to-use' to loop
> same numbers child nodes as queues, such as:
>
> gmac {
> rx-queues-config {
> snps,rx-queues-to-use = <1>;
> queue0 {
> // nothing need here.
> };
> };
> };
I think you mean tx, not rx, given the code.
>
> queue++;
> }
> - if (queue != plat->tx_queues_to_use) {
> + if (queue != plat->tx_queues_to_use && of_get_child_count(tx_node)) {
> ret = -EINVAL;
> dev_err(&pdev->dev, "Not all TX queues were configured\n");
> goto out;
Also what about the init to defaults I asked about?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-29 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 1:09 [PATCH RESEND] ethernet: stmmac: fix for none child queue node for tx node Jianqun Xu
2022-04-28 22:40 ` Jakub Kicinski
2022-04-29 0:46 ` [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node Jianqun Xu
2022-04-29 0:56 ` Andrew Lunn
2022-04-29 1:54 ` jay.xu
2022-04-29 12:14 ` Andrew Lunn
2022-05-01 1:40 ` jay.xu
2022-04-29 1:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428184054.3dd72784@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=jay.xu@rock-chips.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).