From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C10B1C433EF for ; Tue, 3 May 2022 16:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DIO2IQQ4tm2G2RKbJoZLf9ccE0Hsc7vU8s9IaSlihao=; b=aNEiSMSMLZE5gnmOeTJKlTKvQ/ ISo9hymjkqyl1cfWAPcqSOx8V5gukpWuBr2INf1kG7ebkVIvxwhUMEDhKR0v8Ukkx8RcCHWI34Z3N vh7auL+HOLeD6/FHoid5ctHdfA/Ptjs+UeuLYAvswotp3LGmF0XSmuptDWOjnUD2riP9Z82GuqrOQ ZiM/T/08RqFeBhrpwsDzVS4CcF29YhMEB9n9bCmOagFRIIyvzF7W0Eoexqt0pI8kLfFxQ/UTczP7X 4iwcx2vzrFSc4u6gV6RWdANRywVEaNnIfFqvFMt/soRcR1h6yHu9YgInEKclIFPpWUKJc/LhuVhK6 hzrR3+Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlv3h-006evd-7O; Tue, 03 May 2022 16:07:29 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlv3d-006erw-Qw for linux-arm-kernel@lists.infradead.org; Tue, 03 May 2022 16:07:27 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C3F01320090F; Tue, 3 May 2022 12:07:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 May 2022 12:07:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1651594038; x=1651680438; bh=S6jBLD8l+m Ir0OzRt6qgeH2J1Vwk8FdNOOo2AvGlnGY=; b=JgC0htdr53/McvizUOUop1w8ra AuLKzW+TMwSdIZ9dcpvFAveVzIoEQ1oyzQpV4UbEEcKkJZSgE0flClZhE6XUaO5c JvXgr0JLR55CgDMEr7A0zRicW1gsyejasG75Yyu/cvmmlIy95gV9HLbVH2VROK8Y sSs/r6uI/RhBWZ9Yh0rsCAazxV8gNd8GZbVNFaFAdAUN9Rt1jmuiX84OJiLs6E/1 hPUCB1FpT5NovLjp/jSzQFji2W42x9ItMMav9BC4rckpEp/I3W1m1ucYsj5J7ies uAG871iwoViNQSg3ZWKVvSNA6WofWPdoCKwlvIQRX+YZoNE/jm2wdiI2zGRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651594038; x= 1651680438; bh=S6jBLD8l+mIr0OzRt6qgeH2J1Vwk8FdNOOo2AvGlnGY=; b=X j5+twy5OwmxFkKSCwC9YvG0wzd1S04zkqRgBtdGTgO+UivtzlFLA+UD5X6ZTxyt/ fMxAEIR4DPtJld4z5IIvLxIHyuKtK/+rKIwwMYms/bMllDHl7yBJ+q0GLMUc0Cb3 KnswFDzG6wnfHevEruUdJlMO8NU1EzDa20PK3gHcq01YQzWeDbwjNvKjQat7mfOA EW9pNy78y7KaTDddDBEz1AhsJcxj12LVwTynw4bGva9N6kxZAgmoJoPu9kqQvNZV +MaiQ2U8xDW2PlZuT3jnG/JbRH4//5xwTNaQoZ78LSwsHaA4F3BWGrRYD94mPIF3 KFw2SwHQg+zUhy5Otf5fA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepteefffefgfektdefgfeludfgtdejfeejvddttdekteeiffejvdfgheehfffh vedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 May 2022 12:07:16 -0400 (EDT) Date: Tue, 3 May 2022 18:07:13 +0200 From: Maxime Ripard To: Ruslan Zalata Cc: Guenter Roeck , Jean Delvare , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2] hwmon: (sun4i-lradc) Add driver for LRADC found on Allwinner A13/A20 SoC Message-ID: <20220503160713.7kdikhd5kkgkotcp@houat> References: <20220428210906.29527-1-rz@fabmicro.ru> <20220502110010.q7vvdkdpaiz5acjl@houat> <6009fbef45a8b77caa4fc137093a1e23@fabmicro.ru> MIME-Version: 1.0 In-Reply-To: <6009fbef45a8b77caa4fc137093a1e23@fabmicro.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_090726_556173_8438E356 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7784905796513518143==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7784905796513518143== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="o7q6542x2x5bfqc5" Content-Disposition: inline --o7q6542x2x5bfqc5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, May 03, 2022 at 01:50:39PM +0500, Ruslan Zalata wrote: > > I guess a better path forward would be to either register an hwmon > > device in the original driver, or convert that driver to iio and use > > iio-hwmon. >=20 > My first idea was to add hwmon to sun4i-lradc-keys.c driver. But soon as I > began hacking the driver I quickly realized that it would be a mess since > keyboard and hwmon belong to two different subsystems. That's not really an issue in itself. There's plenty of drivers in Linux that register into two frameworks. > Besides we would need to invent a way to control which way the driver > works (new bindings?). I got confused there, and thought you were adding temperature reading that is in another ADC on those SoCs, sorry. Yeah, that doesn't make much sense to have both in the same drivers here. Maxime --o7q6542x2x5bfqc5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYnFTMQAKCRDj7w1vZxhR xSoRAP9r204XnvG9FZ4a7NWbYj251o27k2mVVJqIz+t4Sa+vUAEA4W71CIx9ZBaA 7muZe/5EDx4iJnaVyoBUgq/XK0A4wgQ= =tNMn -----END PGP SIGNATURE----- --o7q6542x2x5bfqc5-- --===============7784905796513518143== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7784905796513518143==--